已关闭
完成第二部分修改,提交代码 #10842
chen-wei43创建于 2 天前关闭于 2 天前
完成第二部分修改,提交代码 #10842
已关闭
chen-wei43创建于 2 天前关闭于 2 天前
chen-wei43
chen-wei43
2 天前

描述

部分代码不符合编程规范,还有部分函数过大,没达到CleanCode要求。

关联的Issue

https://gitcode.com/cann/ops-transformer/issues/4698

测试

二级冒烟

文档更新

不涉及

类型标签

likedislike
当前Pull Request已关闭, 关闭人@chen-wei43
chen-wei43chen-wei43
2 天前 创建了 pull request,commit c8fa6dba
chen-wei43chen-wei43
2 天前 update merge request[project id: 7673863, iid: 10842, commit_id: 52dd7b6ed3a8098548b84cbdb27cf6457ffdc8d7] virtual merging success
chen-wei43chen-wei43
2 天前 推送  62 个提交:c8fa6dba-61 commits from branch master90fae29c-Merge branch 'master' of git@gitcode.com:weixin_54263091/ops-transformer.git into 'master'
chen-wei43chen-wei43
2 天前 update merge request[project id: 7673863, iid: 10842, commit_id: 64a609e190675398e37e1604d4c0cc406c9707aa] virtual merging success
CANN-robotCANN-robot成员
2 天前 添加了label:cann-cla/no
CANN-robotCANN-robot成员
2 天前 添加了label:stat/needs-squash
CANN-robot
CANN-robot成员
2 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)

Module Approval Details

module lgtm status approve status
gmm ❌ (0/2)(You can also ask: 俞郑中, 马兵, 陈康, 蒋礼锐, 黄俊健) ❌ (0/1)(You can also ask: juyangokok, 陈康, 唐超, 刘丹, 蒋礼锐)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Guide

@weixin_54263091 , thanks for your pull request.

The following commit(s) have not signed Contributor License Agreement (CLA).

Commit Reason
90fae29c Merge branch 'master' of git@git... the email is not signed for CLA! please check if it is correct and the same as your signed email.

If you need to sign CLA, you can click here to sign the CLA.

If you need to check if the email is set up correctly, you can click here to do it in the FAQs.

After signing the CLA or updating the email, you must comment /check-cla to check the CLA status again.

likedislike
CANN-robotCANN-robot成员
2 天前 将chenkang30,juyangokok,monologue815,chaotang233,wuyi_huawei,chen-linxin4,jiang-lirui,Allan_Yu,liudan12,shi-rui,cc-z,kknan,wenxin_fight,mabing1118设为评审人
CANN-robotCANN-robot成员
2 天前 将chenkang30,juyangokok,monologue815,chaotang233,wuyi_huawei,chen-linxin4,jiang-lirui,Allan_Yu,liudan12,shi-rui,cc-z,kknan,wenxin_fight,mabing1118设为审查人
chen-wei43chen-wei43
2 天前 修改了pull request 的描述
chen-wei43chen-wei43
2 天前 修改了pull request 的描述
chen-wei43chen-wei43
2 天前 修改了pull request 的描述
chen-wei43chen-wei43
2 天前 关闭了 pull request