Pull Request已成功合入, 合并人@CANN-robot
(感谢 yifuxiong 的贡献)变更摘要
该 PR 根据关联 Issue(#3782)删除 quant_all_reduce 与 quant_reduce_scatter 两个算子的 aclnn 接口实现。mc2/quant_all_reduce/op_api/aclnn_quant_all_reduce.cpp 和 mc2/quant_reduce_scatter/op_api/aclnn_quant_reduce_scatter.cpp 中原有的参数校验(空指针、K-G/MX 量化 dtype 支持、format、group 长度等检查)、内部接口声明及 NnopbaseSetHcclServerType 调用被整体删除,公开入口 aclnnQuantAllReduceGetWorkspaceSize/aclnnQuantAllReduce 与 aclnnQuantReduceScatterGetWorkspaceSize/aclnnQuantReduceScatter 的函数体被改为直接返回 ACLNN_SUCCESS;同时删除对应的示例程序和 UT 测试,并更新了 README.md。
主要改动
- aclnn 接口实现置空:在
aclnn_quant_all_reduce.cpp与aclnn_quant_reduce_scatter.cpp中删除全部参数校验函数(如QuantAllReduceCheckParams、CheckParams及各 dtype/format 检查)、内部接口声明(aclnnInnerQuantAllReduceGetWorkspaceSize、aclnnInnerQuantReduceScatterGetWorkspaceSize等)和NnopbaseSetHcclServerType调用,两个公开入口接口均改为直接return ACLNN_SUCCESS;,不再执行实际算子逻辑。 - 删除示例程序:删除
mc2/quant_all_reduce/examples/test_aclnn_quant_all_reduce.cpp与mc2/quant_reduce_scatter/examples/test_aclnn_quant_reduce_scatter.cpp两个多设备(多线程)aclnn 调用示例,其中包含 aclrt 资源管理、HcclComm 通信域初始化及两阶段接口调用流程。 - 删除 UT 测试:删除
mc2/quant_all_reduce/tests/ut/op_api/test_aclnn_quant_all_reduce.cpp的全部测试用例(dtype 正常/异常、私有 format、group 长度边界、空指针等用例);mc2/quant_reduce_scatter/tests/ut/op_api/test_aclnn_quant_reduce_scatter.cpp中的测试用例同样被移除,仅保留文件头注释。 - 文档更新:根据 PR 描述同步更新了
README.md,移除与上述两个算子 aclnn 接口相关的内容。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/README.md | ✅ 蒋礼锐, wang-minbo, libohao6, 蔡雯雯, chenjunjian11 (5/2) | ✅ 蔡雯雯 (1/1) |
| */*/docs/acl*.md | ✅ 蔡雯雯, chenjunjian11, 蒋礼锐, wang-minbo, libohao6 (5/2) | ✅ 蔡雯雯 (1/1) |
| docs | ✅ 蒋礼锐, wang-minbo (2/2) | ✅ 蒋礼锐, wang-minbo (2/1) |
| mc2 | ✅ wang-minbo, libohao6, 蒋礼锐, chenjunjian11 (4/2) | ✅ 蒋礼锐, wang-minbo, libohao6 (3/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
xiongyifu, thanks for your pull request. All authors of the commits have signed the CLA. 👍


compile


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


compile


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


/lgtm
/approve


/lgtm


/approve
/lgtm


/lgtm
/approve


描述
删除quant_all_reduce和quant_reduce_scatter算子aclnn接口实现
关联的Issue
https://gitcode.com/cann/ops-transformer/issues/3782
测试
不涉及
文档更新
更新了README.md文件
类型标签