Merged
bsa接口文档及示例修复 #13293
bsa接口文档及示例修复 #13293
Merged
Xu-XuePengAdd on Sep 30
Xu-XuePeng
Xu-XuePengCollaborators
Sep 30

描述

1.修改文档拼写错误 attentionMaskOptional应为attenMaskOptional
2.示例参数传递 aclrtDestroyStream(stream)修复为aclrtDestroyStream(*stream)
3.修复文档 约束说明中错误描述innerPrecise

关联的Issue

#5774

测试

bsa example 正常运行
image.png

文档更新

attention/block_sparse_attention/README.md
attention/block_sparse_attention/docs/aclnnBlockSparseAttention.md
attention/block_sparse_attention/docs/aclnnBlockSparseAttentionV2.md
attention/block_sparse_attention/docs/aclnnBlockSparseAttentionV3.md

experimental/attention/block_sparse_attention/README.md
experimental/attention/block_sparse_attention/docs/aclnnBlockSparseAttention.md
experimental/attention/block_sparse_attention/docs/aclnnBlockSparseAttentionV2.md
experimental/attention/block_sparse_attention/docs/aclnnBlockSparseAttentionV3.md

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for Xu-XuePeng's contribution.)
Xu-XuePengXu-XuePengCollaborators
Sep 30 Created pull request, commit 7f26546f
Xu-XuePengXu-XuePengCollaborators
Sep 30 Associated issue: [Requirement|需求建议]: 合并 flash_attn arch35 DN/ND kernel 并整理 block 重复代码
atomgit-bot
atomgit-bot
Sep 30 Comments:

变更摘要

本次改动是针对 BSA(block sparse attention)相关 aclnn 接口的文档/示例修正。从已提供的补丁看,核心修正是将示例中销毁流的调用 aclrtDestroyStream(stream) 改为 aclrtDestroyStream(*stream),使在该 FreeResource 场景下传入的实际是流句柄而非流的地址,从而与接口参数要求一致。该修正同时覆盖正式目录与 experimental 目录下的同名示例文件,属于接口调用用法上的同步修正。

主要改动

  • attention/block_sparse_attention 示例释放资源修正: 在 test_aclnn_block_sparse_attention.cpp 的 FreeResource 中,将 aclrtDestroyStream(stream) 改为 aclrtDestroyStream(*stream),按接口要求传入解引用后的流句柄。
  • experimental/attention/block_sparse_attention 示例同步修正: 在 experimental 下的同名示例文件中做完全一致的改动,使两处示例的 aclrtDestroyStream 调用方式保持一致。
likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Sep 30 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Sep 30 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/README.md ✅ 蔡雯雯, L_Euler, cc-z (3/2) ✅ 蔡雯雯 (1/1)
*/*/docs/acl*.md ✅ 蔡雯雯, L_Euler, cc-z (3/2) ✅ 蔡雯雯 (1/1)
attention ✅ L_Euler, cc-z (2/2) ✅ cc-z, L_Euler (2/1)
experimental/attention ✅ cc-z, L_Euler (2/2) ✅ cc-z, L_Euler (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

IceBearPolar, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
57 messages are collapsed here。 See more
赵臣臣Collaborators
29 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
29 days ago Added label: approved
Han-XiaobinCollaborators
29 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
29 days ago Added label: lgtm
CANN-robotCANN-robotCollaborators
29 days ago Merged pull request