已合并
chore: remove deprecated PTO ISA interfaces #1453
zhywang创建于 15 天前
chore: remove deprecated PTO ISA interfaces #1453
已合并
zhywang创建于 15 天前
zhywang
15 天前

Created-by: zhhywang
Commit-by: zhhywang
Merged-by: cann-robot
Description: Remove deprecated PTO ISA public interfaces, clean residual consumers, and regenerate synchronized ISA documentation and SVG diagrams.

描述

382 files changed, 20457 insertions(+), 33280 deletions(-)。

  • 范围:涉及 docsincludekernelstestsagents/skills。移除清理清单中的 TSYNCTSUBVIEWTADDCTADDSCTSUBCTSUBSCTSUBRELUTFUSEDMULADDRELUTADDReluConvTAddDeqReluTPairReduceSumTGET_SCALE_ADDRTSUBRELUCONV 公开接口、文档页、测试入口和实现引用。
  • 问题:已删除接口仍残留在公共 API、实现 include、Cost Model、ST 用例、文档索引和生成资产中;复审指出双输出 TEXTRACT 仍调用已删除 TSYNC(events...),文档存在机械替换后的伪接口说明,且部分新增 SVG 缺失或与代码语义不一致。
  • 修复:将内部同步调用改为 detail::PtoWaitEvents(events...);移除残留消费者和悬空测试入口;补充 PtoSyncOpPtoWaitEventsPtoSubTileView 内部 helper 边界说明;更新删除接口迁移说明;修复 gen_isa_indexes.pygen_isa_svgs.py,重新生成 ISA README、虚拟手册矩阵和 14 个新增 SVG,并补齐 FMA 旧 dst 输入绘制。
  • 影响:上述接口不再作为公开 PTO ISA/API 暴露;仓内保留的同步等待和子视图逻辑仅作为内部实现 helper 使用;文档生成结果与 manifest、代码和已删除接口范围保持同步。

关联的Issue

测试

  • python3 -m py_compile docs/tools/gen_isa_svgs.py
    • 结果:PASS
  • python3 docs/tools/gen_isa_svgs.py && python3 docs/tools/gen_isa_svgs.py --check
    • 结果:PASS
  • python3 docs/tools/gen_isa_indexes.py --check
    • 结果:PASS
  • python3 docs/tools/gen_virtual_manual_matrix.py --check
    • 结果:PASS
  • git diff --check && git diff --cached --check
    • 结果:PASS
  • rg -n "diagram template not implemented|\(implementation-defined\)|op\(src|set transform mode|backend mode|src0 \* dst \+ src1|src0 \* src1 \+ dst" docs/figures/isa/{SYNCALL,SET_QUANT_SCALAR,SET_QUANT_VECTOR,TAXPY,TPREFETCH_ASYNC,TMATMUL_MX_HIF4,TQUANT_DN,TQUANT_HIF4,TDEQUANT,THISTOGRAM,TALLOC,TPUSH,TPOP,TFREE}.svg
    • 结果:PASS,未发现占位文案或旧错误公式残留
  • bash -n tests/run_st.sh
    • 结果:PASS
  • cmake --build tests/npu/a2a3/src/st/build --target textract_ndto2xnz_kernel
    • 结果:PASS
  • cmake --build tests/npu/a5/src/st/build --target textract_ndto2xnz_kernel_mix
    • 结果:PASS

文档更新

已更新 ISA README、PTOISA 索引、mkdocs 导航、虚拟手册指令族矩阵、删除接口迁移说明、相关编程文档和 ISA SVG 图示。

类型标签

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 zhywang 的贡献)
Zzhywang
15 天前 创建了 pull request,commit 7a1f37be
atomgit-bot
atomgit-bot
15 天前 评论:

🤖 正在生成合并请求摘要,请稍候…

likedislike
atomgit-bot
atomgit-bot
15 天前 评论:

🤖 AI 代码检视正在进行中,请稍候…

likedislike
CANN-robotCANN-robot成员
15 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
15 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
docs 周若愚, csjlchen (2/2) 周若愚 (1/1)
repo-cann/pto-isa 周若愚, csjlchen (2/2) 周若愚 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

zhhywang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
此处折叠了260条消息 查看更多
CANN-robotCANN-robot成员
2 天前 添加了label:ci-pipeline-running
shengxinchen成员
2 天前 评论:

/approve

likedislike
CANN-robotCANN-robot成员
2 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
2 天前 添加了label:ci-pipeline-passed
CANN-robotCANN-robot成员
2 天前 合入了pull request