已合并
fix(.gitcode): 修正 ISSUE_TEMPLATE 模板中的英文拼写错误 #1697
fix(.gitcode): 修正 ISSUE_TEMPLATE 模板中的英文拼写错误 #1697
已合并
廖氏如神创建于 10 天前
廖氏如神
廖氏如神
10 天前

修正 .gitcode/ISSUE_TEMPLATE/feature-request.yml 中的英文拼写/语法错误:

  • Thanks for sending an requirement! → Thanks for sending a requirement!(requirement 以辅音音素开头,冠词应为 a)
  • label: Backgroud(背景信息) → label: Background(背景信息)(该字段名会直接渲染在 Issue 创建页上)

说明:master 中 Background 已为正确拼写,本次仅剩冠词错误待修正。

关联 Issue: #593

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 廖氏如神 的贡献)
廖氏如神廖氏如神
10 天前 创建了 pull request,commit ec220f99
廖氏如神廖氏如神
10 天前 关联了issue:[Documentation|文档反馈]: .gitcode/ISSUE_TEMPLATE/feature-request.yml 模板拼写错误 2 处(Backgroud / an requirement)
atomgit-bot
atomgit-bot
10 天前 评论:

变更摘要

本 PR 针对 .gitcode/ISSUE_TEMPLATE/feature-request.yml 中的英文文案做拼写/语法修正,属于文档模板类的文字修复。改动集中在 type: markdown 字段的 value 引导文案上,将 Thanks for sending an requirement! 修正为 Thanks for sending a requirement!,使冠词与 requirement 的辅音音素开头相匹配。PR 背景中提到的 Background 拼写在 master 中已正确,本次不再涉及。

主要改动

  • 修正引导文案冠词: 在 feature-request.yml 中将 Thanks for sending an requirement! 改为 Thanks for sending a requirement!,仅调整冠词 an → a,其余文案保持不变。
  • 影响 Issue 创建页展示文案: 该 markdown 类型的 value 会直接渲染在 Issue 创建页面上,修正后用户看到的英文提示更符合语法规范。
likedislike
不准确?
CANN-robot
CANN-robot成员
10 天前 评论:

Hi @gcw_Z57idahf, welcome to submitting your first PR to pto-isa!

PR Merge Steps

1. CLA Signing

If the current PR label includes cann-cla/yes, it means you have signed the CLA and can proceed to the next step. If the label includes cann-cla/no, please sign the CLA first. If you have any questions, please refer to the FAQ.

2. CI Check

Please comment /compile to trigger the CI pipeline check. If the CI run is successful, the PR will be tagged with ci-pipeline-passed and you can proceed to the next step. If the CI run fails, the PR will be tagged with ci-pipeline-failed, please check the CI logs to fix the issues in the PR. If you have any questions, please refer to the FAQ.

3. Code Review

After CI passes, please refer to the PR Approval Progress and proactively @ the committers in the table to review the code. After approval, committers will comment /lgtm and /approve. Once the lgtm and approved labels are successfully added, the PR will be merged automatically.

likedislike
atomgit-bot
atomgit-bot
10 天前 评论:

代码审查

✅ 未发现问题

likedislike
不准确?
CANN-robotCANN-robot成员
10 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
10 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
.gitcode/** ✅ tanghaoran7, zhangjian_hz11 (2/2) ✅ tanghaoran7 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

gcw_Z57idahf, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
10 天前 将mywaaagh_admin,songchangxia,tanghaoran7,zhangjian_hz11,csjlchen,zhezhou,shentukangjun,bluesky901,changxianyu,Zhanghaijian,Larry_liuyi,syfeng,yinjie27_,zhoubotcam,HuangXingYuan_777,linjiashu,WenboCodes,qukelin,ChanKaLok,kerwinair,echo_stone设为评审人
CANN-robotCANN-robot成员
10 天前 将mywaaagh_admin,songchangxia,tanghaoran7,shentukangjun,Larry_liuyi设为审查人
廖氏如神
廖氏如神
10 天前 评论:

/compile

likedislike
廖氏如神廖氏如神
10 天前 预合并成功(commit_id: d903a0b4180c70c3241aceda14a7b7b41e7126d9)
CANN-robot
CANN-robot成员
10 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
10 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
10 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
10 天前 添加了label:ci-pipeline-passed
廖氏如神
廖氏如神
10 天前 评论:

@ChanKaLok @bluesky901 @shentukangjun @Larry_liuyi
各位committer好。
cla和ci已经通过了。麻烦各位老师帮忙看下PR,如果有问题我会继续更改。
当前合入还需 2 个 /lgtm 与 1 个 /approve,谢谢!

likedislike
zhangjian_hz11成员
3 天前 评论:

/approve

likedislike
zhangjian_hz11成员
3 天前 评论:

/lgtm

likedislike
shane成员
3 天前 评论:

/lgtm
/approve

likedislike
tanghaoran
tanghaoran成员
3 天前 评论:

/approve

likedislike
CANN-robot
CANN-robot成员
3 天前 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
/approve: zhangjian_hz11, hanxiaolong
/lgtm: hanxiaolong

likedislike
CANN-robotCANN-robot成员
3 天前 添加了label:lgtmapproved
CANN-robotCANN-robot成员
3 天前 删除了label:ci-pipeline-passed
CANN-robot
CANN-robot成员
3 天前 评论:

The following label is not ready.

ci-pipeline-passed: The ci-pipeline-passed label is expired as added over 72 hours. Please use /compile to recompile.

likedislike
范泽清
范泽清
3 天前 评论:

/compile

likedislike
廖氏如神廖氏如神
3 天前 virtual merging failed, update merge request[project_id: 8827531, iid: 1697, target_commit_sha: 6ca6b0e21c1caae17479b3278418609390b9ec3c], message: You are not allowed to merge to this ref
廖氏如神廖氏如神
3 天前 virtual merging failed, update merge request[project_id: 8827531, iid: 1697, target_commit_sha: 6ca6b0e21c1caae17479b3278418609390b9ec3c], message: You are not allowed to merge to this ref
CANN-robot
CANN-robot成员
3 天前 评论:
❌ CI 流水线启动失败
🚫 权限不足: 触发者 f290384664 非仓库成员(需 push 及以上权限或由 PR 创建者本人触发)
处理: 由 PR 创建者或有 push 权限的成员触发
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
3 天前 添加了label:ci-pipeline-failed
tanghaoran
tanghaoran成员
3 天前 评论:

compile

likedislike
廖氏如神廖氏如神
3 天前 预合并成功(commit_id: 8d8b981086f1a05c62ef94bd8f3b80f74df61442)
CANN-robot
CANN-robot成员
3 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
3 天前 删除了label:ci-pipeline-failed
CANN-robotCANN-robot成员
3 天前 添加了label:ci-pipeline-running
shentukangjun成员
3 天前 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
3 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
3 天前 添加了label:ci-pipeline-passed
CANN-robotCANN-robot成员
3 天前 合入了pull request