草稿
[WIP]【共建】RusTLS 4 cj #1
Koina创建于 7月22日
[WIP]【共建】RusTLS 4 cj #1
草稿
合并受阻
芒鸽
29 天前 评论:
29 天前 评论:
《rustls4cj》审核意见(PR #1)
问题点
| # | 维度 | 问题描述 |
|---|---|---|
| 1 | 项目结构 | README.OpenSource 非 OpenHarmony 标准 JSON 格式(需含 Name/License/Version Number/Upstream URL 字段的 JSON) |
| 2 | 构建与测试 | cjpm test 退出码 1(构建错误日志见本评论末尾) |
| 3 | 上游功能适配 | [WIP] PR——仍在开发中 |
| 4 | 上游测试适配 | 5 FAILED + 21 ERROR(共 26 失败) |
| 5 | 上游测试适配 | x25519MatchesRfc7748IteratedVector — X25519 RFC 7748 迭代测试失败 |
| 6 | 测试覆盖 | cjcov 目录仅有 README,无实际覆盖率数据 |
风险点
| 位置 | 级别 | 问题 |
|---|---|---|
N/A:0 |
🔴 高 | 26 个测试失败(5 FAILED + 21 ERROR)——WIP 预期但需在合并前全部修复 |
WIP 说明
本 PR 标题已标注 [WIP](进行中),当前测试状态:684 通过、5 FAILED、21 ERROR。主要失败来自 X25519 RFC 7748 迭代测试向量及并发/密码学相关测试。项目结构良好(doc/assets/、doc/cjcov/ 目录已就绪,design.md/feature_api.md 完善),核心 TLS 功能已基本可用。请在解除 [WIP] 前完成:(1) 修复 26 个测试失败;(2) 生成 cjcov 覆盖率报告;(3) README.OpenSource 转为标准 JSON 格式。
构建错误日志(SDK 1.0.5)
展开日志(末尾部分)
TCS: TestCase_x25519ProviderClearsTemporaryScalarWhenRandomFails, time elapsed: 295358 ns, RESULT:
TCS: TestCase_x25519ProviderInvalidPeerFailuresConsumeAndZeroize, time elapsed: 198771345 ns, RESULT:
TCS: TestCase_x25519ProviderUnsupportedVersionStillConsumesAndZeroizes, time elapsed: 83741357 ns, RESULT:
TCS: TestCase_x25519ProviderCloseIsIdempotentAndConsumesExchange, time elapsed: 71365118 ns, RESULT:
TCS: TestCase_x25519ProviderConcurrentCompleteHasExactlyOneWinner, time elapsed: 138882577 ns, RESULT:
TCS: TestCase_x25519ProviderConcurrentCompleteAndCloseAreLinearizable, time elapsed: 172113330 ns, RESULT:
TCS: TestCase_x25519MatchesRfc7748ScalarMultiplicationVectors, time elapsed: 341569120 ns, RESULT:
TCS: TestCase_x25519MatchesRfc7748AliceAndBobExchange, time elapsed: 301172028 ns, RESULT:
TCS: TestCase_x25519MatchesRfc7748IteratedVector, time elapsed: 59999871277 ns, RESULT:
[ FAILED ] CASE: x25519MatchesRfc7748IteratedVector (59999448558 ns)
TCS: TestCase_x25519IgnoresPeerCoordinateTopBit, time elapsed: 229637133 ns, RESULT:
TCS: TestCase_x25519ReducesRfc7748NonCanonicalPeerCoordinate, time elapsed: 207295301 ns, RESULT:
TCS: TestCase_x25519ClampsEquivalentPrivateScalarEncodings, time elapsed: 257642157 ns, RESULT:
TCS: TestCase_x25519RejectsKnownLowOrderInputsAsInvalidKeyShares, time elapsed: 504187496 ns, RESULT:
TCS: TestCase_x25519RejectsInvalidKeyLengthsAndAllZeroAgreement, time elapsed: 124532472 ns, RESULT:
TCS: TestCase_x25519OwnsInputsCopiesPublicKeyAndZeroizesOnClose, time elapsed: 62168863 ns, RESULT:
TCS: TestCase_x25519ConcurrentAgreementAndCloseAreLinearizable, time elapsed: 309874366 ns, RESULT:
TCS: TestCase_zlibMatchesPythonFixedHuffmanKnownAnswers, time elapsed: 2004214 ns, RESULT:
TCS: TestCase_zlibDecodesPythonStoredBlockKnownAnswer, time elapsed: 355655 ns, RESULT:
TCS: TestCase_zlibDecodesPythonDynamicHuffmanKnownAnswer, time elapsed: 468067 ns, RESULT:
TCS: TestCase_zlibRoundTripsArbitraryBinaryAtBothCompressionLevels, time elapsed: 91588994 ns, RESULT:
TCS: TestCase_zlibCompressorUsesWindowMatchesAndActuallyCompresses, time elapsed: 48267237 ns, RESULT:
TCS: TestCase_zlibRejectsInvalidRfc1950HeadersAndPresetDictionary, time elapsed: 898247 ns, RESULT:
TCS: TestCase_zlibRejectsEveryTruncationOfKnownValidStream, time elapsed: 5937449 ns, RESULT:
TCS: TestCase_zlibRejectsAdlerCorruptionAndTrailingDeflateBytes, time elapsed: 899853 ns, RESULT:
TCS: TestCase_zlibRejectsWrongExactLengthAndOutputBomb, time elapsed: 57300040 ns, RESULT:
TCS: TestCase_zlibRejectsStoredBlockLengthComplementMismatch, time elapsed: 318587 ns, RESULT:
TCS: TestCase_zlibRejectsReservedBlockType, time elapsed: 293694 ns, RESULT:
TCS: TestCase_zlibEnforcesWindowAdvertisedByZlibHeader, time elapsed: 1434400 ns, RESULT:
TCS: TestCase_zlibDoesNotMutateCallerInputAndReturnsOwnedArrays, time elapsed: 1601077 ns, RESULT:
Summary: TOTAL: 710
PASSED: 684, SKIPPED: 0, ERROR: 21
FAILED: 5
--------------------------------------------------------------------------------------------------
📦 group rustls4cj 100% [||||||||||||||||||||] ✗ (00:02:13)
FAIL .TestCase_x25519MatchesRfc7748IteratedVector.x...
passed: 684, failed: 26 100% [||||||||||||||||||||] 710/710 (00:02:13) [?25hError: cjpm test failed
整改建议
请按上述问题点与风险点逐条修改后更新本 PR,我们将重新审核。


29 天前 重置了审查状态 all
init
!1 merge main into main