| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
fix bool-like conditions Many functions return 0/-1 for success/failure. Check their return values explicitly for clarity. | 4 个月前 | |
iwyu: fix headers | 1 年前 | |
iwyu: fix headers | 1 年前 | |
autocrypt: move globals to AutocryptModuleData Move AutocryptDefaultKey, AutocryptSignAs, AutocryptDB, and 9 sqlite3_stmt* globals into AutocryptModuleData struct. | 5 个月前 | |
module: pass data into helpers Update helper functions reached from module init/cleanup paths so callers pass the module-owned fields they use, or the module data pointer when several fields are needed. This removes extra neomutt_get_module_data() lookups from attach, autocrypt, color, conn, gui, history, hooks, key, menu, ncrypt, and sidebar helpers, and updates the affected tests to match. | 5 个月前 | |
autocrypt: refactor to use enabled/disabled instead of active/inactive - Rename toggle_active() to toggle_enabled() - Rename OP_AUTOCRYPT_TOGGLE_ACTIVE to OP_AUTOCRYPT_TOGGLE_ENABLED - Update function name from 'toggle-active' to 'toggle-enabled' - Update menu label from 'Tgl Active' to 'Tgl Enabled' - Update user-visible strings from 'active/inactive' to 'enabled/disabled' - Update comments and help text throughout This provides clearer terminology and better aligns with the account->enabled field that's used internally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> | 1 个月前 | |
autocrypt: refactor to use enabled/disabled instead of active/inactive - Rename toggle_active() to toggle_enabled() - Rename OP_AUTOCRYPT_TOGGLE_ACTIVE to OP_AUTOCRYPT_TOGGLE_ENABLED - Update function name from 'toggle-active' to 'toggle-enabled' - Update menu label from 'Tgl Active' to 'Tgl Enabled' - Update user-visible strings from 'active/inactive' to 'enabled/disabled' - Update comments and help text throughout This provides clearer terminology and better aligns with the account->enabled field that's used internally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> | 1 个月前 | |
iwyu: fix headers | 1 年前 | |
autocrypt: refactor to use enabled/disabled instead of active/inactive - Rename toggle_active() to toggle_enabled() - Rename OP_AUTOCRYPT_TOGGLE_ACTIVE to OP_AUTOCRYPT_TOGGLE_ENABLED - Update function name from 'toggle-active' to 'toggle-enabled' - Update menu label from 'Tgl Active' to 'Tgl Enabled' - Update user-visible strings from 'active/inactive' to 'enabled/disabled' - Update comments and help text throughout This provides clearer terminology and better aligns with the account->enabled field that's used internally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> | 1 个月前 | |
menu: move globals to MenuModuleData - store menu definitions and submenus on per-module data - update callers to fetch module data instead of extern globals - re-enable module init/cleanup where the data is now required | 5 个月前 | |
bugprone: add default cases for switch-missing-default-case Fixes the second of the three categories flatcap flagged as good candidates on #4970 (55 sites across 33 files, matching his count exactly). Each switch was read in full to determine the semantically correct default, not just silenced mechanically: - Most are op/command dispatchers or menu-choice switches (event->op, mw_multi_choice() results, single-letter responses) where the existing code already has an implicit fallback after the switch (a later return, or falling through to shared code) -- these get `default: break;` to make that explicit without changing behaviour. - A few (external.c, muttlib.c, send/send.c) explicitly mirror the existing "abort" case's behaviour, since leaving the loop/function state unchanged on an impossible value would otherwise risk an infinite loop or a silently-wrong return. - pattern/exec.c's two large op-table dispatchers already had an explicit "unknown op" error path after the switch; the new default falls through to it, matching the existing intent exactly. - A handful (pop/auth.c, pop/lib.c, pop/pop.c) switch on documented function return codes; checked each callee's own @retval doc comment to confirm every case was genuinely covered, and matched the default to whichever existing case already represents "no specific outcome" for that function. No case does more than reproduce behaviour the code already had implicitly -- this is a defensiveness/documentation change, not a behaviour change. Verification: `clang-tidy -p . <file> --checks='-*,bugprone-switch-missing-default-case'` now reports 0 warnings across all 55 sites (was 55). Full clean build, `make test` passes (all suites), `clang-format --dry-run -Werror` clean on every changed file (one pre-existing, unrelated violation in autocrypt/gpgme.c confirmed via `git stash` before and after -- not introduced by this change). AI assistance: mechanical location of all 55 sites and the semantic analysis of each switch (tracing callee return contracts, existing fallback behaviour, and loop-safety implications) was done by Claude Code; I reviewed the reasoning and diff before this went up. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> | 1 个月前 | |
iwyu: fix includes | 3 个月前 | |
module: tidy cleanup Pass the Module Data to the Module on cleanup() | 5 个月前 | |
module: add Notify object to each globals Add a 'struct Notify *notify' member to every ModuleData struct. Create it with notify_new() in each Module.init() function, set its parent to NeoMutt->notify, and free it in Module.cleanup(). For modules that previously had commented-out init/cleanup code, uncomment the mod_data allocation and deallocation. | 5 个月前 | |
module: pass data into helpers Update helper functions reached from module init/cleanup paths so callers pass the module-owned fields they use, or the module data pointer when several fields are needed. This removes extra neomutt_get_module_data() lookups from attach, autocrypt, color, conn, gui, history, hooks, key, menu, ncrypt, and sidebar helpers, and updates the affected tests to match. | 5 个月前 | |
autocrypt: move globals to AutocryptModuleData Move AutocryptDefaultKey, AutocryptSignAs, AutocryptDB, and 9 sqlite3_stmt* globals into AutocryptModuleData struct. | 5 个月前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 4 个月前 | ||
| 1 年前 | ||
| 1 年前 | ||
| 5 个月前 | ||
| 5 个月前 | ||
| 1 个月前 | ||
| 1 个月前 | ||
| 1 年前 | ||
| 1 个月前 | ||
| 5 个月前 | ||
| 1 个月前 | ||
| 3 个月前 | ||
| 5 个月前 | ||
| 5 个月前 | ||
| 5 个月前 | ||
| 5 个月前 |