0
代码
代码
Issues
Pull Requests
讨论
Wiki
分析
0
ZYQ5333ZYQ5333fix(mcp-stdio): correct discovery and invocation logic for stdio MCP plugins
0bb6bbc4创建于 15 天前历史提交
文件最后提交记录最后更新时间
__init__.py
n8n converter phase 1 Co-authored-by: michaelhuawei<michael.atamuk@huawei.com> Co-authored-by: nizzan<nizzan.kimhi@huawei.com> Co-authored-by: nikita-mee<nikita.merkulov1@huawei.com> Co-authored-by: aharonamir1<amir.aharon@huawei.com> # message auto-generated for no-merge-commit merge: !871 merge n8n_converter_phase1 into develop n8n converter phase 1 Created-by: aharonamir1 Commit-by: michaelhuawei;Michael;@aharonamir1;nikita-mee;aharonamir1;nizzan Merged-by: ZYQ5333 Description: **What type of PR is this?** <!-- 选择下面一种标签替换下方 /kind <label>，可选标签类型有： - /kind bug - /kind task - /kind feature - /kind refactor - /kind clean_code 如PR描述不符合规范，修改PR描述后需要/check-pr重新检查PR规范。 --> /kind task this PR contains all the PRs in the feature/n8n-converter of phase 1, merged with develop and resolved all conflicts **Self-checklist**:（**请自检，在[ ]内打上x，我们将检视你的完成情况，否则会导致pr无法合入**） + - [ ] **设计**：PR对应的方案是否已经经过Maintainer评审，方案检视意见是否均已答复并完成方案修改 + - [ ] **测试**：PR中的代码是否已有UT/ST测试用例进行充分的覆盖，新增测试用例是否随本PR一并上库或已经上库 + - [ ] **验证**：PR描述信息中是否已包含对该PR对应的Feature、Refactor、Bugfix的预期目标达成情况的详细验证结果描述 + - [ ] **接口**：是否涉及对外接口变更，相应变更已得到接口评审组织的通过，API对应的注释信息已经刷新正确 + - [ ] **文档**：是否涉及官网文档修改，如果涉及请及时提交资料到Doc仓 <!-- **Special notes for your reviewers**: --> <!-- + - [ ] 是否导致无法前向兼容 --> <!-- + - [ ] 是否涉及依赖的三方库变更 --> See merge request: openJiuwen/agent-studio!8712 个月前
plugin_mgr.py
n8n converter phase 1 Co-authored-by: michaelhuawei<michael.atamuk@huawei.com> Co-authored-by: nizzan<nizzan.kimhi@huawei.com> Co-authored-by: nikita-mee<nikita.merkulov1@huawei.com> Co-authored-by: aharonamir1<amir.aharon@huawei.com> # message auto-generated for no-merge-commit merge: !871 merge n8n_converter_phase1 into develop n8n converter phase 1 Created-by: aharonamir1 Commit-by: michaelhuawei;Michael;@aharonamir1;nikita-mee;aharonamir1;nizzan Merged-by: ZYQ5333 Description: **What type of PR is this?** <!-- 选择下面一种标签替换下方 /kind <label>，可选标签类型有： - /kind bug - /kind task - /kind feature - /kind refactor - /kind clean_code 如PR描述不符合规范，修改PR描述后需要/check-pr重新检查PR规范。 --> /kind task this PR contains all the PRs in the feature/n8n-converter of phase 1, merged with develop and resolved all conflicts **Self-checklist**:（**请自检，在[ ]内打上x，我们将检视你的完成情况，否则会导致pr无法合入**） + - [ ] **设计**：PR对应的方案是否已经经过Maintainer评审，方案检视意见是否均已答复并完成方案修改 + - [ ] **测试**：PR中的代码是否已有UT/ST测试用例进行充分的覆盖，新增测试用例是否随本PR一并上库或已经上库 + - [ ] **验证**：PR描述信息中是否已包含对该PR对应的Feature、Refactor、Bugfix的预期目标达成情况的详细验证结果描述 + - [ ] **接口**：是否涉及对外接口变更，相应变更已得到接口评审组织的通过，API对应的注释信息已经刷新正确 + - [ ] **文档**：是否涉及官网文档修改，如果涉及请及时提交资料到Doc仓 <!-- **Special notes for your reviewers**: --> <!-- + - [ ] 是否导致无法前向兼容 --> <!-- + - [ ] 是否涉及依赖的三方库变更 --> See merge request: openJiuwen/agent-studio!8712 个月前
plugin_tools.py
fix(mcp-stdio): correct discovery and invocation logic for stdio MCP plugins Co-authored-by: michaelhuawei<michael.atamuk@huawei.com> # message auto-generated for no-merge-commit merge: !1074 merge fix/mcp-stdio-plugin-params into develop fix(mcp-stdio): correct discovery and invocation logic for stdio MCP plugins Created-by: michaelhuawei Commit-by: michaelhuawei Merged-by: ZYQ5333 Description: **What type of PR is this?** /kind bug **What does this PR do / why do we need it**: This PR fixes **stdio MCP plugin discovery and invocation**, which were still broken even after the fix for #835. The root cause was that the backend constructed incorrect params for stdio plugins, and the invocation path attempted to execute the .py script directly instead of running it via Python. --- ## ✔ 1. Fix: Stdio discovery was broken ### **Root cause** _build_safe_stdio_params incorrectly used: args = [config.url] But for stdio plugins: - config.url is always "" - The actual script path is stored in: - config.params["command"] - config.params["args"] - config.params["env"] ### **Fix** Discovery now uses: script_path = params["command"] or config.url or "" args = params["args"] env = params["env"] This matches what StdioClient expects. --- ## ✔ 2. Fix: Stdio invocation was broken ### **Root cause** plugin_tools.py passed: command = params["command"] # e.g. "/path/to/server.py" This caused: because the .py file was executed directly instead of via Python. ### **Fix** Invocation now treats: - params["command"] as the **script path** - sys.executable as the **actual executable** Updated logic: script_path = params["command"] extra_args = params["args"] mcp_params["command"] = sys.executable mcp_params["args"] = [script_path] + extra_args Now the process launches as: python /path/to/server.py "arg1" "arg2" --- ## 🎉 Result - Stdio plugin **discovery works** - Stdio plugin **invocation works** - Both discovery and execution now correctly use: - Python interpreter - Script path from DB - Args and env from DB This completes the stdio MCP plugin support. --- **Which issue(s) this PR fixes**: Follow‑up to [#835](https://gitcode.com/openJiuwen/agent-studio/issues/835) --- **Code review checklist**: + - [ ] whether to verify the function's return value + - [ ] Whether to comply with **SOLID principle / Demeter's law** + - [ ] Whether there is UT test case && the test case is valid (if no test case, explain why) + - [ ] Whether the API change is involved + - [ ] Whether official document modification is involved See merge request: openJiuwen/agent-studio!107415 天前