"""
A tool for checking the consistency between multiple SIG information and sigs.yaml, and validation of fields for every
SIG information.
"""
import argparse
import os
import time
import requests
import re
import sys
import yaml
SIG_INFO_FIELDS = ['name', 'description', 'mailing_list', 'meeting_url', 'mature_level', 'mentors', 'maintainers',
'repositories', 'created_on', "branches"]
SIG_INFO_REQUIRED_FIELDS = ['name', 'maintainers']
SIG_INFO_SECONDARY_FIELDS = ['repo', 'committers', 'contributors', 'repo_admin']
MEMBER_FIELDS = ['gitee_id', 'name', 'email', 'organization']
def load_yaml(file_path):
"""
Load yaml file
:param file_path: path of the yaml file ready to load
:return: content of the file
"""
try:
with open(file_path, 'r', encoding='utf-8') as f:
content = yaml.load(f.read(), Loader=yaml.Loader)
return content
except yaml.MarkedYAMLError as e:
print('YAML FORMAT ERROR!')
print(e)
sys.exit(1)
def check_diff_files(owner, repo, number):
"""
Check the differences between the current Pull Request and master branch
:param owner: owner of Pull Request
:param repo: repo of Pull Request
:param number: number of Pull Request
:return: a list of different files
"""
diff_url = 'https://gitee.com/{0}/{1}/pulls/{2}.diff'.format(owner, repo, number)
response = requests.get(diff_url)
if response.status_code != 200:
print('Can not get differences from diff_url, diff_url:', diff_url)
sys.exit(1)
diff_files = [{'from': x.split(' ')[0][2:], 'to': x.split(' ')[1][2:].split('\n')[0]} for x in
response.text.split('diff --git ')[1:]]
return diff_files
def check_gitee_id(gitee_id, access_token):
"""
Check validation of gitee_id
:param gitee_id: login id of gitee
:param access_token: access_token of gitee
:return: gitee_id_errors
"""
gitee_id_errors = 0
url = 'https://gitee.com/api/v5/users/{}?access_token={}'.format(gitee_id, access_token)
for i in range(5):
try:
r = requests.get(url)
if r.status_code == 404:
print('ERROR! Check gitee_id: invalid gitee_id {}.'.format(gitee_id))
gitee_id_errors += 1
return gitee_id_errors
except Exception as e:
print("ERROR! Check gitee_id:{}, e:{}".format(gitee_id, e))
time.sleep(3)
else:
gitee_id_errors += 1
return gitee_id_errors
def check_fields(sig_info):
"""
Check fields of sig-info.yaml
:param sig_info: content of sig-info.yaml
:return: fields_errors
"""
fields_errors = 0
fields = list(sig_info.keys())
for field in fields:
if field not in SIG_INFO_FIELDS:
print('ERROR! Find unexpected field [{}] in sig-info'.format(field))
fields_errors += 1
for sig_info_field in SIG_INFO_REQUIRED_FIELDS:
if sig_info_field not in fields:
print('ERROR! Current sig-info has no field {} yet'.format(sig_info_field))
fields_errors += 1
repositories = sig_info.get('repositories')
if not repositories:
return fields_errors
for repos in repositories:
repos_keys_list = list(repos.keys())
for repos_key in repos_keys_list:
if repos_key not in SIG_INFO_SECONDARY_FIELDS:
print('ERROR! The secondary field "{}" is invalid. It must be "repo", "committers",'
'"contributors" or "repo_admin".'.format(repos_key))
fields_errors += 1
continue
if not isinstance(repos.get(repos_key), list):
print('ERROR! The key of secondary field "{}" must be type of list.'.format(repos_key))
fields_errors += 1
continue
if repos_key == 'repo':
for item in repos.get(repos_key):
if not isinstance(item, str):
print('ERROR! The type of every repo should be string.')
fields_errors += 1
continue
if not (item.startswith('src-openeuler/') or item.startswith('openeuler/')):
print('ERROR! The value of {} should startswith "src-openeuler" or '
'"openeuler".'.format(item))
fields_errors += 1
else:
for item in repos.get(repos_key):
if not isinstance(item, dict):
print('ERROR! The type of every {} should be dict.'.format(repos_key))
fields_errors += 1
continue
for member_field in item.keys():
if member_field not in MEMBER_FIELDS:
print('ERROR! Invaild third key {}'.format(member_field))
fields_errors += 1
return fields_errors
def check_sig_name(sig, sig_info):
"""
Check sig name of sig-info.yaml
:param sig: name of the sig
:param sig_info: content of sig-info.yaml
:return: sig_name_error
"""
sig_name_error = 0
name = sig_info.get('name')
if name != sig:
print('ERROR! The name must be equal to sig name, but sig-info name={}, sig={}'.format(name, sig))
sig_name_error += 1
return sig_name_error
def check_email(email_address):
"""
Check validation of email address
:param email_address: the target email address
:return: errors
"""
if not re.match(r'^[a-zA-Z0-9_\-.]+@[a-zA-Z0-9_-]+(\.[a-zA-Z0-9_-]+)+$', email_address):
print('WARNING! It seems that {} is not a email address'.format(email_address))
def check_member(member, access_token):
"""
Check validation of a member
:param member: a dict of member info
:param access_token: access_token of gitee
:return: member_errors
"""
member_errors = 0
gitee_id = member.get('gitee_id')
email = member.get('email')
member_errors += check_gitee_id(gitee_id, access_token)
if email:
check_email(email)
return member_errors
def check_maintainers(maintainers, access_token, errors):
"""
Check validation of maintainers
:param maintainers: a list of maintainers
:param access_token: access_token of gitee
:param errors: issues number
:return: errors
"""
if not maintainers:
print('ERROR! The SIG must has at least 1 maintainer')
errors += 1
return errors
if not isinstance(maintainers, list):
print('ERROR! The maintainers must be a list')
errors += 1
return errors
errors_count = 0
for maintainer in maintainers:
check_error = check_member(maintainer, access_token)
errors_count += check_error
return errors_count
def check_committers(committers, access_token, errors):
"""
Check validation of committers
:param committers: a list of committers
:param access_token: access_token of gitee
:param errors: issues number
:return: errors
"""
if not isinstance(committers, list):
print('ERROR! The committers must be a list')
errors += 1
return errors
errors_count = 0
for committer in committers:
check_error = check_member(committer, access_token)
if check_error:
errors_count += check_error
return errors_count
def check_contributors(contributors, access_token, errors):
"""
Check validation of contributors
:param contributors: a list of contributors
:param access_token: access_token of gitee
:param errors: issues number
:return: errors
"""
if not isinstance(contributors, list):
print('ERROR! The contributors must be a list')
errors += 1
return errors
errors_count = 0
for contributor in contributors:
check_error = check_member(contributor, access_token)
errors_count += check_error
return errors_count
def check_branch_keeper(branches, access_token):
"""
Check validation of branch_keeper
:param branches: a list of contributors
:param access_token: access_token of gitee
:return: errors
"""
err_msg = list()
if not isinstance(branches, list):
err_msg.append("ERROR! The branches must be a list")
if len(err_msg):
print(",".join(err_msg))
return len(err_msg)
for branch in branches:
if branch.get("repo_branch") is None:
err_msg.append("ERROR! The repo_branch must be not empty")
continue
if not isinstance(branch.get("repo_branch"), list):
err_msg.append("ERROR! The repo_branch must be a list")
continue
if branch.get("keeper") is None:
err_msg.append("ERROR! The keeper must be not empty")
continue
if not isinstance(branch.get("keeper"), list):
err_msg.append("ERROR! The keeper must be a list")
continue
for repo in branch["repo_branch"]:
if repo is None:
err_msg.append("ERROR! The keeper must be not empty")
continue
if not isinstance(repo, dict):
err_msg.append("ERROR! The repo_branch must be a dict")
continue
if "repo" not in repo.keys() or "branch" not in repo.keys():
err_msg.append("ERROR! The repo_branch must include the repo and branch fileds")
continue
for keeper in branch["keeper"]:
if keeper is None:
err_msg.append("ERROR! The keeper must be not empty")
continue
if not isinstance(keeper, dict):
err_msg.append("ERROR! The keeper must be a dict")
continue
if "gitee_id" not in keeper.keys():
err_msg.append("ERROR! The keeper must include the gitee_id fileds")
continue
errors = check_member(keeper, access_token)
if errors != 0:
err_msg.append("ERROR! The invalid gitee_id")
if len(err_msg):
print(",".join(err_msg))
return len(err_msg)
def get_sig_info_repos(sig_info_repos):
"""
Get all repositories list in sig-info.yaml
:param sig_info_repos: field repositories of sig-info.yaml
:return: a list of repositories all list in sig-info.yaml
"""
all_sig_info_repos = []
all_sig_info_committers = []
all_sig_info_contributors = []
if not sig_info_repos:
print('WARNING! There is no repository in sig-info.yaml of the SIG yet.')
return all_sig_info_repos, all_sig_info_committers, all_sig_info_contributors
for each_group_repos in sig_info_repos:
if isinstance(each_group_repos.get("repo"), list):
for each_repo in each_group_repos.get("repo"):
all_sig_info_repos.append(each_repo)
if each_group_repos.get("committers") and isinstance(each_group_repos.get("committers"), list):
for each_committers in each_group_repos.get("committers"):
all_sig_info_committers.append(each_committers)
if each_group_repos.get("contributors") and isinstance(each_group_repos.get("contributors"), list):
for each_contributors in each_group_repos.get("contributors"):
all_sig_info_contributors.append(each_contributors)
return all_sig_info_repos, all_sig_info_committers, all_sig_info_contributors
def get_sig_repos(sig_dir_path):
"""
Get all repositories under directories of the sig
:param sig_dir_path: sig directory path
:return: a list of repositories all belong to the sig
"""
sig_dir_repos = []
for root, _, files in os.walk(sig_dir_path):
for f_name in files:
sub_dir_yaml_file = os.path.join(root, f_name)
org_name = sub_dir_yaml_file.split("/")[-3]
repo_name = sub_dir_yaml_file.split("/")[-1].split(".yaml")[0]
repo_full_name = "{}/{}".format(org_name, repo_name)
sig_dir_repos.append(repo_full_name)
return sig_dir_repos
def check_repos_consistency(sig_info_repos, sig_repos):
"""
Check consistency between sig_info_repos and sig_repos
:param sig_info_repos: all repositories list in sig-info.yaml
:param sig_repos: all repositories under directories of the sig
:return: repos_consistency_errors
"""
repos_consistency_errors = 0
repeat_repos = []
for sig_info_repo in sig_info_repos:
if sig_info_repos.count(sig_info_repo) > 1 and sig_info_repo not in repeat_repos:
repeat_repos.append(sig_info_repo)
for repeat_repo in repeat_repos:
print('ERROR! Find the same repo `{}` appears in sig-info.yaml for multiple times'.format(repeat_repo))
repos_consistency_errors += 1
for sig_info_repo in sig_info_repos:
if sig_info_repo not in sig_repos:
print('ERROR! Find extra repo {} list in sig-info.yaml'.format(sig_info_repo))
repos_consistency_errors += 1
return repos_consistency_errors
def check_info_repositories(sig_repositories):
"""
Check validation of sig_info_repos
:param sig_repositories: repositories of sig-info.yaml
:return: sig_info_repositories_errors
"""
sig_info_repositories_errors = 0
if not sig_repositories:
print('WARNING! There is no repository in sig-info.yaml of the SIG.')
return sig_info_repositories_errors
if not isinstance(sig_repositories, list):
print('ERROR! Check sig_repositories: sig_repositories should be a list type')
sig_info_repositories_errors += 1
for each_group_repos in sig_repositories:
if not (isinstance(each_group_repos, dict) and 'repo' in each_group_repos.keys()):
print('ERROR! Check repo: every repo should be a dictionary type and at least one key should '
'be repo.')
sig_info_repositories_errors += 1
if not isinstance(each_group_repos.get("repo"), list):
print('ERROR! Check each repo: repo should be a list type')
sig_info_repositories_errors += 1
if each_group_repos.get("committers") and not isinstance(each_group_repos.get("committers"), list):
print('ERROR! Check committers: committers should be a list type')
sig_info_repositories_errors += 1
if each_group_repos.get("contributors") and not isinstance(each_group_repos.get("contributors"), list):
print('ERROR! Check contributors: contributors should be a list type')
sig_info_repositories_errors += 1
return sig_info_repositories_errors
def get_all_sig_dir_data(sig_dir_path):
sig_dir_repos = []
openeuler = os.path.join(sig_dir_path, "openeuler")
src_openeuler = os.path.join(sig_dir_path, "src-openeuler")
if os.path.exists(openeuler):
sig_dir_openeuler_repos = get_sig_repos(openeuler)
sig_dir_repos.extend(sig_dir_openeuler_repos)
if os.path.exists(src_openeuler):
sig_dir_src_openeuler_repos = get_sig_repos(src_openeuler)
sig_dir_repos.extend(sig_dir_src_openeuler_repos)
return sig_dir_repos
def check_sig_info(sig, access_token):
print('\nStarting to check sig info of sig {}'.format(sig))
sig_info_errors = 0
sig_info_path = os.path.join("community", 'sig', sig, 'sig-info.yaml')
sig_dir_path = os.path.join("community", 'sig', sig)
if not os.path.exists(sig_info_path):
print('WARNING! sig {} has no sig-info.yaml file'.format(sig))
return sig_info_errors
sig_info = load_yaml(sig_info_path)
print('\nCheck 1: Check fields of sig-info')
check1 = check_fields(sig_info)
if check1 != 0:
return check1
else:
print('PASS WITHOUT ISSUES FOUND.')
print('\nCheck 2: Check sig name')
check2 = check_sig_name(sig, sig_info)
if check2 != 0:
return check2
else:
print('PASS WITHOUT ISSUES FOUND.')
print('\nCheck 3: Check maintainers')
maintainers = sig_info['maintainers']
check3 = check_maintainers(maintainers, access_token, sig_info_errors)
if check3 != 0:
return check3
else:
print('PASS WITHOUT ISSUES FOUND.')
sig_repositories = sig_info.get('repositories')
print('\nCheck 4: Check repositories')
check4 = check_info_repositories(sig_repositories)
sig_info_errors += check4
if check4 == 0:
print('PASS WITHOUT ISSUES FOUND.')
print('\nCheck 5: Check repositories consistency')
all_sig_info_repos, _, _ = get_sig_info_repos(sig_repositories)
sig_dir_repos = get_all_sig_dir_data(sig_dir_path)
check5 = check_repos_consistency(all_sig_info_repos, sig_dir_repos)
sig_info_errors += check5
if check5 == 0:
print('PASS WITHOUT ISSUES FOUND.')
print('\nCheck 6: Check committers')
_, all_sig_info_committers, _ = get_sig_info_repos(sig_repositories)
if all_sig_info_committers:
check6 = check_committers(all_sig_info_committers, access_token, sig_info_errors)
sig_info_errors += check6
if check6 == 0:
print('PASS WITHOUT ISSUES FOUND.')
else:
print('There is no committer in the SIG yet, skip Check 6.')
print('\nCheck 7: Check contributors')
_, _, all_sig_info_contributors = get_sig_info_repos(sig_repositories)
if all_sig_info_contributors:
check7 = check_contributors(all_sig_info_contributors, access_token, sig_info_errors)
sig_info_errors += check7
if check7 == 0:
print('PASS WITHOUT ISSUES FOUND.')
else:
print('There is no contributor in the SIG yet, skip Check 7.')
print('\nCheck 8: Check branch_keeper')
branches = sig_info.get('branches')
if branches is not None:
check8 = check_branch_keeper(branches, access_token)
sig_info_errors += check8
if check8 == 0:
print('PASS WITHOUT ISSUES FOUND.')
else:
print('There is no branch_keeper in the SIG yet, skip Check 8.')
return sig_info_errors
def parse_arguments():
parser = argparse.ArgumentParser(
description='A tool for checking the consistency between multiple SIG information'
' and sigs.yaml, and validation of fields for every SIG information.')
parser.add_argument('-o', '--owner', help='owner of Pull Request', required=True)
parser.add_argument('-r', '--repo', help='repo of Pull Request', required=True)
parser.add_argument('-n', '--number', help='number of Pull Request', required=True)
parser.add_argument('-t', '--token', help='access_token', required=True)
args = parser.parse_args()
return args
def main():
args = parse_arguments()
owner = args.owner
repo = args.repo
number = args.number
access_token = args.token
diff_files = check_diff_files(owner, repo, number)
change_sigs = []
for diff_file in diff_files:
from_file = diff_file['from']
to_file = diff_file['to']
if len(from_file) > 2 and from_file.split('/')[0] == 'sig':
change_sigs.append(from_file.split('/')[1])
if len(to_file) > 2 and to_file.split('/')[0] == 'sig':
change_sigs.append(to_file.split('/')[1])
change_sigs = sorted(list(set(change_sigs)))
errors = 0
for change_sig in change_sigs:
if change_sig == 'sig-template':
print('The SIG sig-template is used only as an example, skip the check.')
continue
if os.path.exists(os.path.join("community", 'sig', change_sig, 'OWNERS')):
print('WARNING! sig {} has OWNERS file yet, found {} warnings'.format(change_sig, errors))
continue
errors += check_sig_info(change_sig, access_token)
if errors != 0:
print('\nCheck sig info failed: Find {} errors.'.format(errors))
sys.exit(1)
print('\nCheck sig info: PASS :)')
if __name__ == '__main__':
main()
