Tthestig@chromium.orgRoll DEPS for Breakpad r1020:1052.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Add rendering support to the TestShell. - Tie the Compositor into the TestShell. - Tie a really basic Tab into the TestShell. BUG=http://crbug.com/136786 Review URL: https://chromiumcodereview.appspot.com/10968003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-save XIB files using Xcode 4.4.1 on Mac OS X 10.8.1. This also adds a PRESUBMIT check to enforce the policy described here: http://dev.chromium.org/developers/design-documents/mac-xib-files BUG=149763 TEST=Build chrome target on 10.6 with Xcode 3.2. Chromium.app launches and works. TBR=mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157690 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Converted policy_prefs_ui.py pyauto test to a browser_test. This is a reland of http://codereview.chromium.org/10905223/ after parameterizing the tests so they don't timeout on chromeos debug bots. BUG=143637 Review URL: https://chromiumcodereview.appspot.com/10918263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157346 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the obsolete string : IDS_LOCALE_GTK ChromeOS does not use GTK any more. BUG=NONE TEST=ChromeOS Chrome is built without any problem. Review URL: https://chromiumcodereview.appspot.com/10928133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Updated fullscreen icon. TBR=sky BUG=151574 Review URL: https://codereview.chromium.org/10982034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158649 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert "Revert 155950 - Add initial Chromium TestShell support for Android" Fixed build breakages: -Had to add DEPS file for testshell/java. -Something changed with ant from the time I tested and the time my CL got committed. Had to move sdk-targets.xml import in the ant file to the end of the file. This reverts commit 2d30dc03dc0bd0723236c549313774119f163056. BUG= Review URL: https://chromiumcodereview.appspot.com/10905209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156458 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add chrome to the repository. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Add * to chrome/app/OWNERS to enable commit access to generated_resources.grd BUG=none TEST=Adding new strings should not require LGTM from src/chrome/app owners Review URL: https://chromiumcodereview.appspot.com/10823078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148958 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. The LSMinimumSystemVersion must be of the form |n.n.n| [1] but the MACOSX_DEPLOYMENT_TARGET is only |n.n|, so add an extra |.0| to the value in the plist key. [1] https://developer.apple.com/library/mac/#documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html BUG=137676 TEST=none TBR=mac people Review URL: https://chromiumcodereview.appspot.com/10810031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147607 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv(). This allows dead code stripping to be turned back on for the main executables and for the NXArgc and NXArgv symbols to be stripped. BUG=139902 Review URL: https://chromiumcodereview.appspot.com/10837149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150419 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv(). This allows dead code stripping to be turned back on for the main executables and for the NXArgc and NXArgv symbols to be stripped. BUG=139902 Review URL: https://chromiumcodereview.appspot.com/10837149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150419 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
After delegating to chrome.exe (i.e. to launch a packaged app) check if app_host is out-of-date and, if so, invoke the Chrome Binaries installer to update it. R=erikwright,grt TBR=brettw BUG=138315 NOTRY=True TEST=Install Chrome vX at system level. Install App Host vY at user-level, where Y < X. Launch app_host.exe. Inspect "Properties" of app_host.exe and verify that it has been updated to vX. Review URL: https://chromiumcodereview.appspot.com/10905238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156934 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. The LSMinimumSystemVersion must be of the form |n.n.n| [1] but the MACOSX_DEPLOYMENT_TARGET is only |n.n|, so add an extra |.0| to the value in the plist key. [1] https://developer.apple.com/library/mac/#documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html BUG=137676 TEST=none TBR=mac people Review URL: https://chromiumcodereview.appspot.com/10810031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147607 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Mac: Enable WebAppShortcutCreatorTest.CreateShortcut unit test * Mock out code to reveal generated app bundle in Finder. * Change how we fill in the template plist to a variable substitution model. * Clean app_mode-Info.plist to remove unneeded keys. BUG=112651 TEST=WebAppShortcutCreatorTest.CreateShortcut should pass. Review URL: http://codereview.chromium.org/9426030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124174 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Rename all of experiments_helper to variations_helper, including files, namespaces, and various function names. TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/10795060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151357 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Roll DEPS for Breakpad r1020:1052. BUG=152278 Review URL: https://codereview.chromium.org/10982049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158883 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Breakpad support for ASan: take 2. This is an updated version of https://chromiumcodereview.appspot.com/10703116/ which got reverted. When the code is built with ASan, Chrome should register a callback which notifies the browser about a memory error. The error report message is passed to the crash handler and is then sent to the crash server along with the minidump. BUG=143657 Review URL: https://chromiumcodereview.appspot.com/10860006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152989 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Do Keychain reauthorization at update time. In addition to the at-launch reauthorization, this adds an at-update reauthorization step. It only runs for users not on a system Keystone ticket, because the updater runs as root when on a system ticket, and root can't read individual user's Keychains. The at-update reauthorization is intended to handle the reauthorization for users who rarely restart Chrome and might miss out on the at-launch step during the window where Chrome is signed by the old certificate but has the new reauthorization code in place. The at-update reauthorization step can remain in place even after the certificate switch occurs by shipping an old reauthorization stub binary signed with the old certificate. BUG=108238 TEST=none Review URL: https://chromiumcodereview.appspot.com/10377173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137501 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update Breakpad to r842, picking up: ------------------------------------------------------------------------ r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines Use a bootstrap subset port for the inspector, tying the subset to the lifetime of the task to be monitored, the invoking task. This allows the bootstrap server (in launchd) to automatically clean up the Mach server registration when the task being monitored exits, avoiding leaks of com.Breakpad.Inspector(pid) ports in "launchctl bslist". BUG=chromium:28547 TEST=Handler should still crash catches, but inspector ports should no longer show up in "launchctl bslist". They should show up under a subset port in "launchctl bstree" instead. "launchctl bstree" must be invoked as root. Review URL: http://breakpad.appspot.com/306001 ------------------------------------------------------------------------ This gives each Breakpad instance its own bootstrap subset port as a subset of the process' bootstrap port, and places the Breakpad inspector port into the bootstrap subset port. This completely eliminates leaks of on-demand Mach services advertised via the bootstrap server. This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate the leak. The temporary hacks were never completely effective against Breakpad ports leaking from child processes. DestructCrashReporter at process shutdown was deemed unnecessary and is being removed. As this was the last caller to that function, the implementation is removed as well. This is addressed in Breakpad rather than Chrome because a mechanism to fix it without changing the process' bootstrap port was discovered. It was determined that the rohitfork port is already immune to leaks of the sort that the Breakpad inspector port experiences. A previous attempt to fix this bug was r103089, but that caused bug 98550. This strategy is safer. The forked Breakpad module.cc is updated to match upstream r835, which allows the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to dump_syms is now available and used by the dump_product_syms script. BUG=28547 TEST=1. "launchctl bslist" should no longer show on-demand com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad on) ports. 2. "launchctl bstree" (as root) should reveal a bootstrap subset for each process as a child of the per-user/per-session bootstrap namespace if crash reporting is on. One com.Breakpad.Inspector port should show up as a child of each bootstrap subset. As each process exits (even if mercilessly killed by "kill -9"), the associated subsets and inspector ports should disappear. 3. Breakpad reports should be generated on crashes. For example, about:crash and about:inducebrowsercrashforrealz should each cause a minidump to be written in ~/Library/Application Support/Google/Chrome/Crash Reports when Breakpad is enabled. This tests that the Breakpad ports are functioning properly. 4. The browser process should be able to access child process data. Window:Task Manager should show valid values for the Memory, CPU, and Network columns for all child processes. This tests that the rohitfork port is functioning properly. Note that this version of the change does not change the handling of rohitfork ports at all, but this test case was useful in a previous version of this patch. 5. Test case from bug 98550: Have a link in a web browser window (in a different browser) and drag it into Chrome. Expect the drag operation to operate properly in both the tab strip and in web content. See bug 98550 for details. 6. Unreported test case that failed in r103089: browser relaunch should work. Visit chrome://flags, change some flags to get the "Relaunch Now" button at the bottom (you can put the flags back to how you found them initially), and click "Relaunch Now". The browser should close and then be relaunched. Review URL: http://codereview.chromium.org/8120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Rename all of experiments_helper to variations_helper, including files, namespaces, and various function names. TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/10795060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151357 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Render/pepper hang debugging: generate dumps for the browser and renderer processes if users kill a hung pepper plugin. This CL collects information in order to diagnose inter-process pepper deadlocks. - We don't crash those renderers or the browser. - We only do this on the Windows Canary channel for 20% of pepper plugin hangs, if there are not too many renderers (<4). BUG=147593 TEST=None Review URL: https://chromiumcodereview.appspot.com/10983028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158717 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
WinDDK ATL and MSVC express 2008/2005 compatability Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Second attempt to land ffmpeg roll. Attempt 2 at landing http://codereview.chromium.org/9317096/ Same as before except for fixes in checkperms/ However, fixes have landed elsewhere for: - mp3 decode issue. - FrameRateNoVsyncCanvasInternalTest.fishbowl/0 BUG=110776 TEST=unittests, layouttests, trybots, perf tests... Review URL: https://chromiumcodereview.appspot.com/9447029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124501 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a manifest to chrome.dll. Review URL: http://codereview.chromium.org/14128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7019 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Fix delay loaded dependencies. BUG=11651 TEST=Build Google Chrome branded Release configuration of chrome.exe and it should not throw deps check fail error. Review URL: http://codereview.chromium.org/113234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15810 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Revert 153268 - Refactor manifests to allow all executables to use the same base manifests as AdditionalManifestFiles Introduce additional.manifest with app compatibility guids and UAC asInvoker property (this is the same as the old chrome.exe.manifest, but without the non-common parts, see chrome.manifest below). Introduce chrome.manifest to keep a property that was set in the previous chrome.(exe|dll).manifest to declare usage of ComCtl32.dll version 6 as is required per http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175(v=vs.85).aspx to get visual styles. BUG=127765 (not really fixing it, but a follow up to the CL for it) TEST=Manifests embedded in chrome.exe, chrome.dll, setup.exe, mini_installer.exe in a VS2010 static build are the exact same as before. Review URL: https://chromiumcodereview.appspot.com/10879020 TBR=gab@chromium.org Review URL: https://chromiumcodereview.appspot.com/10880059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153389 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Uses FFmpeg in chrome/renderer - Have chrome/renderer to use FFmpeg - Added using_media.vsprops to all affected projects that depends on chrome/renderer. - Added lib path "$(OutDir)\lib" to essential.vsprops Review URL: http://codereview.chromium.org/48118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12071 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Add "inspect background page" to platform app right-click menu. BUG=148470 Review URL: https://chromiumcodereview.appspot.com/10907243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157645 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make F12 toggle the DevTools window in the Windows port BUG=139581 TEST=press F12 in any page, make sure the new DevTools window is undocked, press F12 again. The DevTools window should close. Review URL: https://chromiumcodereview.appspot.com/10916110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154938 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make ws2_32.dll delay load again - In r13569 I removed it from delay load in using_libxml.vsprops - Here I put it back in a more logical place BUG=10012 TBR=maruel Review URL: http://codereview.chromium.org/67073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13574 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Split out command IDs from chrome_dll_resource.h. The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix delay loaded dependencies. BUG=11651 TEST=Build Google Chrome branded Release configuration of chrome.exe and it should not throw deps check fail error. Review URL: http://codereview.chromium.org/113234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15810 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
More aura build fixes BUG=None TEST=None Review URL: http://codereview.chromium.org/8094001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103473 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Set the default ASan options for the Official Chrome build. Review URL: https://chromiumcodereview.appspot.com/10823038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153652 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't build the main executable binaries as Objective-C. The operative portion of this change simply renames chrome/app/chrome_exe_main_mac.mm to chrome/app/chrome_exe_main_mac.cc. The main executables never used any Objective-C anyway. I named the files with .mm a long time ago because at the time it meant that I didn't need to add a separate GYP 'exclude' rule to keep other platforms from seeing the file. That was before we added the rules to automatically exclude files based on platform suffix like _mac. This change also adds a "verify" step to the targets that build our main executables. The verify step will cause a build failure if this ever regresses. This works around a bug in 10.5 CFBundlePreflightExecutable, which crashes when called in a process whose main executable has slid due to PIE when the main executable also contains an __OBJC,__image_info section. We enabled PIE at r91243. BUG=88697 TEST=No more crashes inside CFBundlePreflightExecutable (on our call from webkit::npapi::PluginLib::ReadWebPluginInfo) on 10.5 Review URL: http://codereview.chromium.org/7726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98122 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Schedule an APC to trigger the thread cap The loader eats our exceptions during the attach, so we need to schedule an APC to trigger an exception after loading is done. Review URL: https://codereview.chromium.org/10908279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157034 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support sharing of ContentMain and BrowserMain code with embedded use cases (try #3). For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately. To support sharing of this code the following changes were required: 1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions. 2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions. 3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code. BUG=112507 TEST=none Review URL: https://chromiumcodereview.appspot.com/9375017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121454 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Infrastructure to improve app mode stub <-> Chrome main communication. We currently modify the command line to communicate from the launcher to ChromeMain(), this seems like a bad idea in the long run. The aim of this CL is to provide infrastructure to help us going forward. * Add an IsRunningInAppMode() function we an use to determine that we're using app mode rather than having each callsite check the command line. * Mac: Add a function to allow access to the ChromeAppModeInfo struct from anywhere in the code, so we don't need to plumb it down to individual callsites. TEST=Covered by existing tests. BUG=None Review URL: http://codereview.chromium.org/9618021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125302 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Made chrome_main_delegate match the base class's definition. BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156761 Review URL: https://chromiumcodereview.appspot.com/10915268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156853 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Made chrome_main_delegate match the base class's definition. BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156761 Review URL: https://chromiumcodereview.appspot.com/10915268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156853 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Transition to base/mac/bundle_locations.h step 1 Initial transition steps, trying to do this in small steps so it's easier to review. foundation_util.h: * Remove SetOverride*() methods and modify all callsites to use bundle_location.h version. * MainAppBundle() - call through to bundle_location version as an interim step. * Rename PathForFrameworkBundleResource() and modify callers. * Remove one instance of [NSBundle mainBundle]. BUG=None TEST=Chrome/Mac should launch correctly and all unit tests should pass. Review URL: http://codereview.chromium.org/9187053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118284 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Correct in-app copyright messages per new policy, matching source. Review URL: https://codereview.chromium.org/10913307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cause chrome.exe to introspect to find the version of chrome.dll to load. This should ensure that mismatched exe and dll versions never occur. Also, wstring -> string16. BUG=140779 TEST=Install Chrome, smash Omaha registry keys, Chrome still runs. Review URL: https://chromiumcodereview.appspot.com/10825213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150282 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cause chrome.exe to introspect to find the version of chrome.dll to load. This should ensure that mismatched exe and dll versions never occur. Also, wstring -> string16. BUG=140779 TEST=Install Chrome, smash Omaha registry keys, Chrome still runs. Review URL: https://chromiumcodereview.appspot.com/10825213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150282 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
EN, mf, DO YOU SPEAK IT? No more symbolic links in the .app. Except for the ones that codesign adds. The en_US.lproj directory should not exist, there should be only en.lproj. Formerly, there was a symbolic link from en.lproj to en_US.lproj. BUG=25578, 19165 TEST= - find C.app -name en_US.lproj should return nothing. - find C.app -name en.lproj should show en.lproj in C.app, C F.framework, and C H.app. - find C.app -type l should return nothing, however, on a signed build, it will still show symbolic links for CodeResources. - Say "What" again. Say "What" again. I dare you. I double-dare you. - With English or U.S. English as the top or only choices in the International (10.5) or Language & Text (10.6) system preference pane's Language tab, the localized language should be English. - In this configuration, the Accept-Language header field should be "en-US,en;q=0.8". See http://whatsmyuseragent.com/ and look for HTTP_ACCEPT_LANGUAGE. Review URL: http://codereview.chromium.org/345057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30955 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove all support for the Carbon NPAPI event model Plugins already cannot negotiate the Carbon event model; this removes all the code supporting the Carbon model now that it is no longer necessary. The interpose library is left in place because plugins that use the Cocoa event model may still make Carbon OS calls for window or cursor managament. BUG=125915 Review URL: https://chromiumcodereview.appspot.com/10928072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Notes: F4 was recently changed to toggle between Maximize/Restored unless in Fullscreen. In Fullscreen F4 toggles out of it. This fix adds Shift-F4 to toggle Fullscreen (as F4 used to do). TOGGLE_MAXIMIZED must be in kReservedActions in ash/accelerators/accelerator_table.cc. It was recently removed. BUG=151544 TEST=Press Shift F4 to toggle fullscreen; Ctrl-Alt-/ for keyboard overlay, then Shift. Review URL: https://chromiumcodereview.appspot.com/10987034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158811 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correct in-app copyright messages per new policy, matching source. Review URL: https://codereview.chromium.org/10913307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Better fix for redefined FACILITY_VISUALCPP While the previous one works, this one makes sense. BUG=127799 TEST= it builds Review URL: https://chromiumcodereview.appspot.com/10666046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144276 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. The LSMinimumSystemVersion must be of the form |n.n.n| [1] but the MACOSX_DEPLOYMENT_TARGET is only |n.n|, so add an extra |.0| to the value in the plist key. [1] https://developer.apple.com/library/mac/#documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html BUG=137676 TEST=none TBR=mac people Review URL: https://chromiumcodereview.appspot.com/10810031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147607 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add partial pre-read functionality to browser startup (Windows). PartialPreReadImage has much the smae interface as PreReadImage except the bytes to read becomes a percentage to read and it reads a certain percentage of each section in the binary. Also adds some unittest coverage. BUG=chromium:98508 TEST= Review URL: http://codereview.chromium.org/9235053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120371 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add ShellIntegration::ActivateMetroChrome, which launches Chrome in metro-mode on Windows 8. BUG=113326 TEST=none Review URL: https://chromiumcodereview.appspot.com/10470002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139975 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load the metro driver dll at startup When the metro_driver is present, we need to relinquish the browser main thread to it, execution of chrome will continue on another thread, which will be used as chrome main thread. TEST=none, other that chrome should work. BUG=118641 Review URL: https://chromiumcodereview.appspot.com/9718001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127714 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
NaCl: Support 64-bit reserved_at_zero value This change will make the x86-32 sandbox on Linux non-zero-based until the change at http://codereview.chromium.org/10832040/ is committed in Chromium. Also, on Atom, performance will be temporarily reduced but not broken. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2927 TEST=trybots Review URL: https://chromiumcodereview.appspot.com/10826039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149333 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Review URL: http://codereview.chromium.org/7390037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add experiments info to crash dumps. BUG=None TEST=Make sure that the crash dumps are correctly generated and contain experiments information when appropriate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128910 Review URL: http://codereview.chromium.org/9432033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130858 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 |