Mmattm@chromium.orgRevert 158894 - Disable TLS channel ID by default. (for merging to branch)
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Review URL: https://codereview.chromium.org/10991044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove runtime lookup of objc_setAssociatedObject Now that we've dropped 10.5 support we can link to this function directly. BUG=137676 Review URL: https://chromiumcodereview.appspot.com/10913151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155633 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NSS functions out of CertDatabase into a new NSSCertDatabase class. BUG=chromium-os:33872 Review URL: https://chromiumcodereview.appspot.com/10916094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155720 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Sync the SafeBrowsing csd.proto file with the latest server-side version. BUG=None Review URL: https://chromiumcodereview.appspot.com/10978036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158716 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Event matching by regular expression matching on URLs. Uses FilteredRE2 implementation to more efficiently match lots of regexes at once by prefiltering. BUG=135609,112155 Review URL: https://codereview.chromium.org/10910179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156693 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable uses of ProfileImportProcess on Android. This is part of the unit_tests linking effort on Android. This moves the profile import-related code excluded on Android to its own class. BUG=136787 Review URL: https://chromiumcodereview.appspot.com/10777012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147285 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The new toast experiments. I've done some generalizing of the code and added the bits to show the new UI designs. Also fixed some bugs. Gone is the idea of 'compact' toast and now we just specify the flags we want. BUG=129499 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10821007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149257 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Consolidate declarations of XDG variables. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10548019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142014 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement the webdriver window sizing commands. BUG=107630 TEST=none Review URL: http://codereview.chromium.org/9288051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119555 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[chromedriver] Determine the element location and click synchronously in the renderer. This is only the browser-side implementation. In this patch we send some scripts from the client which the renderer evaluates to determine where to move or click the mouse. I tried to keep the renderer code as small and as simple as possible. I plan on eventually removing the script-based location finding in favor of some scrollIntoView-like method in WebKit. Currently scrollIntoView does not work. See http://code.google.com/p/chromium/issues/detail?id=73953. BUG=chromedriver:22,chromedriver:36,chromedriver:44 TEST=none Review URL: https://chromiumcodereview.appspot.com/10384023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138479 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow AutomationProvider to work with other render view containers besides tabs, particularly extension bg pages, infobars, and popups. This is needed to enable WebDriver to work with these views. BUG=93571 TEST=none Review URL: http://codereview.chromium.org/8790003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113023 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added webdriver support for App v2. This change allows testing using Chrome webdriver on App v2 windows. It exposes (via window_handles) and allows switching control to App v2 windows for testing. BUG=6801177 Review URL: https://chromiumcodereview.appspot.com/10854026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151328 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Final set of conversions of automation calls to the JSON interface. Converts the old bookmark automation commands. TEST=PyAuto CONTINUOUS suite BUG=132794 Review URL: https://chromiumcodereview.appspot.com/10828245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151380 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup gfx::Canvas now that 10562027 has landed Bug=None Test=Compiles on Mac and CrOS R=oshima,sky TBR=sadrul,sail Review URL: https://chromiumcodereview.appspot.com/10701063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148123 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove SSLHostInfo. BUG=105208 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Base: More adjustments to BASE_API and project dependencies to use base.dll from chrome. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6877053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Linux: add GYP flag to build with system libbz2. This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package. http://codereview.chromium.org/165016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
[Linux] Add field trial tuples to breakpad crash reports. This is the Linux side of the following changes: Windows: http://codereview.chromium.org/9432033 Mac: https://chromiumcodereview.appspot.com/10661057 Also cleans up some surrounding code: - Change strncpy() calls to safer base::strlcpy(). - No need to NULL terminate after snprintf(), which does that already. - Use arraysize() throughout. - No need to call strlen() just to check if a string is empty. BUG=145323 TEST=Linux crash reports show experiment chunks. Review URL: https://chromiumcodereview.appspot.com/10890015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154190 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Linux] Add field trial tuples to breakpad crash reports. This is the Linux side of the following changes: Windows: http://codereview.chromium.org/9432033 Mac: https://chromiumcodereview.appspot.com/10661057 Also cleans up some surrounding code: - Change strncpy() calls to safer base::strlcpy(). - No need to NULL terminate after snprintf(), which does that already. - Use arraysize() throughout. - No need to call strlen() just to check if a string is empty. BUG=145323 TEST=Linux crash reports show experiment chunks. Review URL: https://chromiumcodereview.appspot.com/10890015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154190 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm} Breakpad support currently resides in chrome/app/breakpad_mac.* this makes it inaccessible to lower level code that would also like to set crash keys e.g. The sandboxing infrastructure. This CL refactors the crash key reporting code to reside in base/mac. Logging is also added to the Sandbox code to try to track down the cause of crbug.com/94758. BUG=95272, 94758 TEST=On official builds crash logs should contain crash keys e.g. OS version. Review URL: http://codereview.chromium.org/7849011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100626 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
[Linux] Add field trial tuples to breakpad crash reports. This is the Linux side of the following changes: Windows: http://codereview.chromium.org/9432033 Mac: https://chromiumcodereview.appspot.com/10661057 Also cleans up some surrounding code: - Change strncpy() calls to safer base::strlcpy(). - No need to NULL terminate after snprintf(), which does that already. - Use arraysize() throughout. - No need to call strlen() just to check if a string is empty. BUG=145323 TEST=Linux crash reports show experiment chunks. Review URL: https://chromiumcodereview.appspot.com/10890015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154190 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename some chrome.exe exports: SetCommandLine --> SetCommandLine2, SetExperimentList --> SetExperimentList2. This will avoid mismatched parameter expectations when there is version shear, since their implementations were recently changed. BUG=129390,128541 Review URL: https://chromiumcodereview.appspot.com/10422019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138935 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement the persistent metro mode setting (win8) We use HKCU\Software\<product>\Metro registry path and 'launch_mode' value to store the last 'forced' mode. Unless chrome is already running we use the stored mode if it is found else we use a "tabletness" heuristic to determine the launch mode. BUG=141032 TEST=none Review URL: https://chromiumcodereview.appspot.com/10928172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156708 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement the persistent metro mode setting (win8) We use HKCU\Software\<product>\Metro registry path and 'launch_mode' value to store the last 'forced' mode. Unless chrome is already running we use the stored mode if it is found else we use a "tabletness" heuristic to determine the launch mode. BUG=141032 TEST=none Review URL: https://chromiumcodereview.appspot.com/10928172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156708 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow the creation of partially spoofed user agents Refactors user agent generation so that we can create partially spoofed user agents for other platforms. BUG=128570 Review URL: https://chromiumcodereview.appspot.com/10854251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153783 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix CommandLine usage The Android version was using the CommandLine class incorrectly, leading to a unit test failure on the Android ASAN bot. BUG=145606 Review URL: https://chromiumcodereview.appspot.com/10907016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154377 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the EULA is accepted. We accomplish this by adding an OnEulaAccepted method to the WizardControllerObserver and have the VariationsService be notified on that method when the EULA is accepted. BUG=146865 TEST=Start CrOS on a new machine and ensure that, with a network connection, no requests are made to the variations server before the EULA is accepted. As soon as the EULA is accepted, ensure that a request is made. Also ensure that a request is made each time at startup after the first time the EULA is accepted. Review URL: https://chromiumcodereview.appspot.com/10917120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158648 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Do not show the EULA if it has already been accepted by the user in another user data dir. BUG=131033 TEST=install system-level chrome with require_eula in master prefs and eulaaccepted=0 in the ClientState key. nuke all user data dirs (including the metro one). now launch desktop chrome and accept the eula. make chrome the default browser and launch into metro. notice that it works. Review URL: https://chromiumcodereview.appspot.com/10539153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142576 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable EULA dialog to be shown from metro Chrome. BUG=131033 TEST=Run Chrome in Metro mode while the EULA dialog still needs to be accepted. Get kicked back to the desktop to accept the dialog. On accept, get kicked back into metro mode. Review URL: https://chromiumcodereview.appspot.com/10837222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158797 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158894 - Disable TLS channel ID by default. (for merging to branch) BUG=129174 TEST=browse to https://www.google.com, check chrome://histograms for DomainBoundCerts.Support. Then try with --enable-tls-channel-id flag. Review URL: https://codereview.chromium.org/10979040 TBR=mattm@chromium.org Review URL: https://codereview.chromium.org/10981045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158897 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158894 - Disable TLS channel ID by default. (for merging to branch) BUG=129174 TEST=browse to https://www.google.com, check chrome://histograms for DomainBoundCerts.Support. Then try with --enable-tls-channel-id flag. Review URL: https://codereview.chromium.org/10979040 TBR=mattm@chromium.org Review URL: https://codereview.chromium.org/10981045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158897 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Force avatar and wallpaper decoding to use robust JPEG. The next step in an upcoming CL will bind this separate path to a different JPEG library (at a minimum on CrOS). BUG=144296 Review URL: https://chromiumcodereview.appspot.com/10892023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154001 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Set Chrome VersionInfo for Android Review URL: https://chromiumcodereview.appspot.com/10963033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158172 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Chrome version info getter for Chrome OS. Properly handles getting channel information for Chrome OS. Unlike linux desktop version, it has to check the information stored in /etc/lsb-release (keyed as "CHROMEOS_RELEASE_TRACK"). Asking the track info from udpate_engine_client via dbus would not work here because it contains *next* channel if the user manually changed the channel (e.g. stable -> dev, update_engine_client returns "dev-channel"). This fixes chromium-os:22883, but some early GetChannel() users still misses correct channel information. BUG=chromium:107333, chromium-os:22883 TEST=chrome://sync and see if sync server points to https://clients4.google.com/chrome-sync/dev on dev channel. Review URL: http://codereview.chromium.org/8883043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114388 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Transition to base/mac/bundle_locations.h step 3 Convert some instances of [NSBundle mainBundle] to equivalent calls in base/mac/bundle_locations.h BUG=None TEST=Code should compile and all unit tests should pass. Review URL: http://codereview.chromium.org/9240004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119030 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add chrome common files to android build. Renaming two files from linux to posix to pull them into the android build, excluding them from the mac build to maintain status quo Taking over http://codereview.chromium.org/9414030/ from isaac due to presubmit issues. BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/9416106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123840 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix duplicate OFFICIAL_BUILD macros. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/9212049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119893 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* BUG=37186 TEST=No behavior change. Manually confirm that build succeeds on Linux, Mac and Windows if we comment out '#if defined(GOOGLE_CHROME_BUILD)' in chrome_version_info_*. Review URL: http://codereview.chromium.org/7249003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90394 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: -move safe browsing messages together -get rid of webkit_param_traits and common_param_trait since they're no longer needed -remove the multiple include of IPC files from places that don't need it TBR=tsepez Review URL: http://codereview.chromium.org/6713084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Delete chrome_plugin_messages.h which is no longer used Review URL: https://chromiumcodereview.appspot.com/9718019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127420 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Generate param traits even when shared by mutliple message files. Review URL: https://chromiumcodereview.appspot.com/10577040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor Pickle Read methods to use higher performance PickleIterator. There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
convert bookmark manager to loadTimeData from localStrings BUG=122753 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10244005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136222 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Coverity: Initialize member variables. CID=100356,100360,100368,100373,100374,100562,101529,101530,101536,101541, 101542,101595,101630,101685,101687,101689,101776,101812,101813,101854, 101861,101862,101871,101883,101886,101887,102034 BUG=none TEST=none R=binji Review URL: http://codereview.chromium.org/8965054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115225 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
content: Move kStandardSchemeSeparator into content namespace. BUG=98716 R=jam@chromium.org TBR=willchan@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10261003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134843 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove wstring from TableModel. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70290 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Make third-party cookie blocking take precedence over any rules that match all hosts. Previously, it would only take precedence over rules that match all origins ("*"). BUG=133768 TEST=see bug for manual test. Review URL: https://chromiumcodereview.appspot.com/10574045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143953 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
content: Move kStandardSchemeSeparator into content namespace. BUG=98716 R=jam@chromium.org TBR=willchan@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10261003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134843 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added support for file URI path wildcards in content settings patterns. I.e. "file:///*" matches all file URIs. Full/explicit/absolute paths (e.g. "file:///foo/bar.html") are still supported. contributed by Francois Kritzinger (francoisk777@gmail.com) BUG=77149 TEST=ContentSettingsPattern* Review URL: http://codereview.chromium.org/9254028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118696 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added support for file URI path wildcards in content settings patterns. I.e. "file:///*" matches all file URIs. Full/explicit/absolute paths (e.g. "file:///foo/bar.html") are still supported. contributed by Francois Kritzinger (francoisk777@gmail.com) BUG=77149 TEST=ContentSettingsPattern* Review URL: http://codereview.chromium.org/9254028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118696 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reapply 130248 - Add full support for filesystem URLs. Trying to get the build into the right state. TBR=pfeldman Review URL: https://chromiumcodereview.appspot.com/9956101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130363 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add infobar for PPAPI broker usage. BUG=142639 Review URL: https://chromiumcodereview.appspot.com/10826164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154742 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Unconditionally send Chrome and Chrome Frame events through ETW machinery. Previously, these components only registered themselves if CHROME_ETW_LOGGING was set in the environment. This is likely preventing the new log machinery in http://crrev.com/126240 from providing useful information on the main waterfall bots. Siggi: overall Brett: chrome/common BUG=none TEST=none R=siggi@chromium.org,brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/9702021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126810 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change bookmarkManager API from experimental to private. BUG=37219 Review URL: https://codereview.chromium.org/10966025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157937 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
IPC outgoing message filters interpose yourself in a message stream. Minimally invasive baseline for building IPC tests to abuse browser along the lines of a compromised renderer. Review URL: http://codereview.chromium.org/6711024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84076 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
IPC outgoing message filters interpose yourself in a message stream. Minimally invasive baseline for building IPC tests to abuse browser along the lines of a compromised renderer. Review URL: http://codereview.chromium.org/6711024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84076 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding ifdef to remove Skia dependency in IPC code for testing. Review URL: http://codereview.chromium.org/99219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14966 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Make icon_messages use the IPC macros for defining the structs and the serialization code, and move the icon messages there. Also get rid of friend class in RenderView that's not needed anymore. Review URL: http://codereview.chromium.org/6883020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81999 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use hi-resolution favicon variants if available. This changes the favicon IPC to return all favicon variants to the browser, and hands the to the new in-browser variant selection function. Note that favicons that come from the history database will still be lodpi. Reloading a site will force the favicon to be loaded from the network. (chrome:// favicons are always loaded through the favicon cache and hence are always lodpi) BUG=138550 TEST=Go to apple.com, amazon.com, github.com, notice hidpi favicon Review URL: https://chromiumcodereview.appspot.com/10828127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150184 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 135222 - it broke multiprofile tests - Use worker pool for IO in JsonPrefStore. Review URL: https://chromiumcodereview.appspot.com/10344007 TBR=sergeyu@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135723 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Flakiness cleanup: disable flaky tests under chrome/ BUG=84299,99469,90557,109292,38497,45243,84854,59785,59783,59784,100567,62777,60426 TBR=thakis Review URL: https://chromiumcodereview.appspot.com/9406017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122137 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding Javascript support for the Extended Searchbox API. This CL only adds the IPCs and renderer side hooks for the extended API, but does not make the API functional as the browser side changes are not implemented. They will be implemented in a future CL which will be flag protected. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10809063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151642 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adding Javascript support for the Extended Searchbox API. This CL only adds the IPCs and renderer side hooks for the extended API, but does not make the API functional as the browser side changes are not implemented. They will be implemented in a future CL which will be flag protected. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10809063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151642 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't mark JsonPrefStore as initialized in case of fatal failure. In code path OnPrefLoaded(success=false), JsonPrefStore is not marked as initialized, so ProfileImpl destructor doesn't try to access unregistered prefs. BUG=122426 TEST=None Review URL: https://chromiumcodereview.appspot.com/10377083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136448 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Keep emtpy List/Dictionary pref value with non-empty default. - Add a MarkNeedsEmptyValue method to JsonPrefStore; - In PrefService::RegisterPreference, mark ListValue and DictionaryValue pref with non-empty default as needing empty value in |user_pref_store_|; - Update ChromeLauncherDelegate to put back default pinned apps and add migration logic for M19 users; - Add unit tests; BUG=122679 TEST=Verify fix for issue 122679. Review URL: http://codereview.chromium.org/10055003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131919 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share JSON schema constants. BUG=None TEST=unit_tests green Review URL: https://chromiumcodereview.appspot.com/10696034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share JSON schema constants. BUG=None TEST=unit_tests green Review URL: https://chromiumcodereview.appspot.com/10696034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share JSON schema constants. BUG=None TEST=unit_tests green Review URL: https://chromiumcodereview.appspot.com/10696034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Remove unneeded forward declarations from various chrome subdirectories. BUG=none TEST=none Review URL: http://codereview.chromium.org/8491036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109951 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Implements a C++ version of JSONSchemaValidator. BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/4673001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65867 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Share JSON schema constants. BUG=None TEST=unit_tests green Review URL: https://chromiumcodereview.appspot.com/10696034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move base/values.h into the base namespace. This includes a cros DEPS roll with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Break two classes defined in json_value_serializer.cc, .h into separate files. This will allow the use of JSONStringValueSerializer in the NaCl sandbox. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9465030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123701 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Modify the base::JSONReader interface to take a set of options rather than a boolean flag. This is just prep work for a large CL that rewrites the JSON parser. Splitting out this interface change will make it easier to review the other CL. BUG=121469 TEST=No functional change. Review URL: https://chromiumcodereview.appspot.com/9960077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert "Revert 137734 - Select theme resources from ResourceBundle at requested scale factor." Relanding original CL 137734, http://codereview.chromium.org/10387010/. TBR=aa,abodenha,ben,sail,tony BUG=123611 TEST=All try bots pass and aura runs without errors. Review URL: https://chromiumcodereview.appspot.com/10412004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138769 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland of http://codereview.chromium.org/10877025/. Accidentally included other code in the CL when manually landing after the CQ got stuck, so had to revert (See http://codereview.chromium.org/10880048/) Remove no longer used NetNanny and ESET anti-virus error strings and ESET error code. TBR=agl@chromium.org, thakis@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10870103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153564 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move localized_error from chrome/renderer into chrome/common. Localized_error contains code to generate error strings, and it isn't render-thread specific. Chrome for iOS uses this class for error messages, but because we don't use the render thread at all, we've had to go into contortions of DEPS and gyp files to include it. This CL pulls localized_error out of renderer into common, which will bring great sanity to the iOS build. BUG= Review URL: https://chromiumcodereview.appspot.com/10830218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150601 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't lock the log file unless we are logging to a file. R=jschuh@chromium.org,davemoore@chromium.org,brettw@chromium.org BUG=146406 TEST=none Review URL: https://chromiumcodereview.appspot.com/10909164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156750 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
share all the needed linux code with OpenBSD in chrome and content disabled code for OpenBSD: - AdjustRendererOOMScore() - SECCOMP_SANDBOX BUG= TEST=compile Review URL: http://codereview.chromium.org/8341052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
share all the needed linux code with OpenBSD in chrome and content disabled code for OpenBSD: - AdjustRendererOOMScore() - SECCOMP_SANDBOX BUG= TEST=compile Review URL: http://codereview.chromium.org/8341052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
share all the needed linux code with OpenBSD in chrome and content disabled code for OpenBSD: - AdjustRendererOOMScore() - SECCOMP_SANDBOX BUG= TEST=compile Review URL: http://codereview.chromium.org/8341052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
share all the needed linux code with OpenBSD in chrome and content disabled code for OpenBSD: - AdjustRendererOOMScore() - SECCOMP_SANDBOX BUG= TEST=compile Review URL: http://codereview.chromium.org/8341052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Enable --enable-nacl-debug switch on Linux. Remove old code that uses command-line passed to NaCl loader to find this switch. BUG= 131381 TEST= manual Review URL: https://chromiumcodereview.appspot.com/10545085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141267 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NaCl: Update revision in DEPS, r8480 -> r8500 This pulls in the following Native Client changes: r8481: (robertm) Enable an additional shared lib for the pnacl ld experiments. r8482: (nfullagar) Build gtest with -Wno-missing-field-initializers. A recent change in r8483: (robertm) Do not ignore unresolved symbols during pnacl dynamic links. r8484: (robertm) Prevent any of "fixedfeaturecpu" tests to be run under pnacl. r8485: (robertm) Make pnacl drivers work static and PIC r8486: (dschuff) Add sandboxed translator to arm HW spec run r8487: (ncbray) Make the browser tester use the real IP of the machine it is running on. r8488: (robertm) Add a step for PIC mode testing to the pnacl toolchain testers. r8489: (robertm) Make the pnacl shared linking experiment work completely without glibc r8490: (robertm) Enable pic test for real r8491: (khim) Add few more CPU-detectable bits to nacl_cpuid.[ch] r8492: (robertm) Make the pnacl dynamic loader experiment call into the ld.so. r8493: (dschuff) Don't use slash in buildbot step name; it causes the stdio output URL to be wrong on the web interface. r8494: (kschimpf) Make default table rows explicit. r8495: (ncbray) Browser tester: dump entire net log if no URLs are loaded. r8496: (khim) Disable mach_forward_untrusted_caught_test on coverage bot r8497: (kschimpf) Remove "x not y" implicit relationships from the table and make explicit! r8498: (robertm) Roll toolchain deps to rev 8495 *r8500: (mseaborn) Exception handling: Windows: Add "const" in some places * The change r8500 above requires a small const fix. BUG=none TEST=nacl_integration Review URL: https://chromiumcodereview.appspot.com/10384006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135604 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load mac sandbox definitions from resources instead of the bundle. Also, move all mac sandbox unittests to content BUG=90443 TEST=content_unittests Review URL: http://codereview.chromium.org/8589001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111614 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: -move safe browsing messages together -get rid of webkit_param_traits and common_param_trait since they're no longer needed -remove the multiple include of IPC files from places that don't need it TBR=tsepez Review URL: http://codereview.chromium.org/6713084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
NaCl: Bind TCP socket for the GDB debug stub in the browser process This allows the debug stub to work without "--no-sandbox". This change is only for POSIX since Windows requires very different code. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3007 TEST= launch NaCl page in chrome with --enable-nacl-debug but without --no-sandbox try to connect nacl gdb. Review URL: https://chromiumcodereview.appspot.com/10928050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156784 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Coverity] Uninit ctor CID=104031 R=jhawkins@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10392153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139552 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NaCl: Bind TCP socket for the GDB debug stub in the browser process This allows the debug stub to work without "--no-sandbox". This change is only for POSIX since Windows requires very different code. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3007 TEST= launch NaCl page in chrome with --enable-nacl-debug but without --no-sandbox try to connect nacl gdb. Review URL: https://chromiumcodereview.appspot.com/10928050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156784 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First version to add some UMA stats to the chrome histograms. This change covers most part of the main flow chart along the password generation function, including: - detected account creation form - password generation icon shown - password generation bubble shown (Linux) - regeneration password button clicked (Linux) - password entry edited by users (Linux) - learn more link clicked (Linux) - generated password accepted (Linux) - generated password submitted All this are simple counters for now and Windows UI will come next as a separate CL. BUG=130330 TEST=unit tests, browser tests Review URL: https://chromiumcodereview.appspot.com/10787023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147757 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First version to add some UMA stats to the chrome histograms. This change covers most part of the main flow chart along the password generation function, including: - detected account creation form - password generation icon shown - password generation bubble shown (Linux) - regeneration password button clicked (Linux) - password entry edited by users (Linux) - learn more link clicked (Linux) - generated password accepted (Linux) - generated password submitted All this are simple counters for now and Windows UI will come next as a separate CL. BUG=130330 TEST=unit tests, browser tests Review URL: https://chromiumcodereview.appspot.com/10787023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147757 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[OSX] All Flapper, all the time. No channel restriction on OSX Flapper. Fingers crossed. BUG=115437 Review URL: https://chromiumcodereview.appspot.com/10947013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158735 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add pepper permissions to WebPluginInfo This allows us to round-trip from PepperPluginInfo to WebPluginInfo and back. This happens in the component updater when it registers Flash. BUG=138902 Review URL: https://chromiumcodereview.appspot.com/10831224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150922 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added black list of printer. Added option to enable/disable registration of new printers. BUG=137129 Review URL: https://chromiumcodereview.appspot.com/10966052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158782 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added black list of printer. Added option to enable/disable registration of new printers. BUG=137129 Review URL: https://chromiumcodereview.appspot.com/10966052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158782 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reinitialize LocalState's CommandLinePrefStore after about_flags updates the command line. Otherwise flags set in about:flags are ignored by the LocalState. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9251026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118926 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move lots of GMock stuff out of line. Nico did some treemapping of our build time on Mac, and (surprise!) gmock unittests dominated. Gmock works with several large, heavy templates, and previous patches that out of line the ctors/dtors have significantly sped up compilation (e.g.GLMock) and have reduced thrashing. Nico says I should plug this again: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts BUG=none TEST=none Review URL: http://codereview.chromium.org/6056008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70516 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
New link rel=prerender api, using WebKit::WebPrerenderingPlatform This patch implements the renderer side classes corresponding to https://bugs.webkit.org/show_bug.cgi?id=85005 , and adds messaging up to the browser process for link prerender events. A new PrerenderLinkManager is introduced to handle these events for the LinkManager. BUG=84236 Review URL: https://chromiumcodereview.appspot.com/10198040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136611 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Print preview: Use an ID instead of memory pointer string in WebUI. BUG=144051 Review URL: https://chromiumcodereview.appspot.com/10870003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153342 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Print preview: Use an ID instead of memory pointer string in WebUI. BUG=144051 Review URL: https://chromiumcodereview.appspot.com/10870003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153342 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support the Syzygy instrumenting profiler. This change depends on a new API in V8 to support return-address rewriting profilers, landed at http://code.google.com/p/v8/source/detail?r=10845. BUG=None TEST=None Review URL: http://codereview.chromium.org/9477002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124319 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor Pickle Read methods to use higher performance PickleIterator. There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Virtual Cloud Print Driver for Mac. Includes code for the driver itself. Also modifies the browser process as well as service process to register Apple Event handlers. Also changes the service process to allow registration of driver. BUG= TEST= Review URL: http://codereview.chromium.org/7485011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96825 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cloud Print Policy - service side enforcement, Mac browser tests. Enhance MockLaunchd to the point where it can easily be injected into full service process browser/multiprocess tests, letting those tests run on the Mac. This gets us to the point where we can more browser/service process interaction test coverage. BUG=98049 TEST=none Review URL: http://codereview.chromium.org/9131016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118744 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cloud Print Policy - service side enforcement, Mac browser tests. Enhance MockLaunchd to the point where it can easily be injected into full service process browser/multiprocess tests, letting those tests run on the Mac. This gets us to the point where we can more browser/service process interaction test coverage. BUG=98049 TEST=none Review URL: http://codereview.chromium.org/9131016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118744 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert use of int ms to TimeDelta in scattered chromium files. It's not clear to me who needs to review the change to third_party/leveldatabase/env_chromium.cc, or even if it's handled through the standard CL interface for the rest of Chromium. But my best guess was that you could either approve it or tell me who to contact. Let me know if I need to go about this patch submission a different way. R=brettw@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119771 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add OVERRIDE to chrome/common/ and nacl/. BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8551009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110941 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. R=ben@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10704115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145729 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Rename SpellCheckCommon namespace to chrome. BUG=133126,133088 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10573017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143200 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 142671 - Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text. Broke spellchecking on Mac (http://crbug.com/133400) If a page has a selection, RenderView::OnReplace() replaces the selection with the given text. To prevent this problem, this change uses a new WebKit API WebFrame::replaceMisspelledRange() that replaces only a misspelled word with the given text. BUG=132941 TEST=none Review URL: https://chromiumcodereview.appspot.com/10536190 TBR=hbono@chromium.org Review URL: https://chromiumcodereview.appspot.com/10572007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142857 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a histogram to measure browser window display Measure the amount of time from app startup to when the first browser window becomes visible. TEST=None BUG=None Review URL: https://chromiumcodereview.appspot.com/10662046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148917 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a histogram to measure browser window display Measure the amount of time from app startup to when the first browser window becomes visible. TEST=None BUG=None Review URL: https://chromiumcodereview.appspot.com/10662046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148917 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove --no-startup-window flag when restarting chrome. This fixes the problem where if chrome launches in background mode at login, the next time we restart chrome we relaunch it in background mode again. BUG=92391 TEST=Install background app, restart computer so chrome is launched on startup, go to about:flags and change a flag and choose 'Restart' - chrome should reopen any open windows on restart. Review URL: http://codereview.chromium.org/8413023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107763 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename CommandLine::GetCommandLineString(). Fix string hackery in net/tools/dump_cache/dump_cache.cc Fix const casts in chrome/installer/util/product.cc and base/process_util_win.cc. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7386002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93165 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update thumbnail_database to store times using ToInternalValue(). Modify ThumbnailScore::Equals() to test whether the time_at_snapshot match exactly. BUG=None Test=ThumbnailDatabaseTest.* ThumbnailScoreTest.* pass Review URL: https://chromiumcodereview.appspot.com/10915092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155037 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove a static initializer in thumbnail_score.o BUG=94925 TEST=none Review URL: http://codereview.chromium.org/7839019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99908 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Support in-browser thumbnailing on Windows XP. On Windows XP, neither the backing store nor the compositing surface is available in the browser when accelerated compositing is active. This CL makes the thumbnailer ask the renderer to send a snapshot for creating the thumbnail in such a case. BUG=130701 TEST=Manually check the new code path worked on Windows XP Review URL: https://chromiumcodereview.appspot.com/10704190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146586 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome://downloads updateDateDisplay more often. Also use an empty since string for future dates instead of 'Today'. Reviewers: estade: resources/downloads/downloads.js, webui/downloads_dom_handler.cc Done: rdsmith, asanka: * BUG=60954 Review URL: https://chromiumcodereview.appspot.com/10918274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158615 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome://downloads updateDateDisplay more often. Also use an empty since string for future dates instead of 'Today'. Reviewers: estade: resources/downloads/downloads.js, webui/downloads_dom_handler.cc Done: rdsmith, asanka: * BUG=60954 Review URL: https://chromiumcodereview.appspot.com/10918274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158615 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move in_process_browser_test and ui_test_utils to chrome/test/base BUG=90905 Review URL: http://codereview.chromium.org/7532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Wrap TimeFormat unittests into unnamed namespace. Plus some other clean ups around. R=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/8313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106085 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removing the "learn more" link for session restore. TBR=sky@chromium.org BUG=133263 Review URL: https://chromiumcodereview.appspot.com/10990052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158807 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removing the "learn more" link for session restore. TBR=sky@chromium.org BUG=133263 Review URL: https://chromiumcodereview.appspot.com/10990052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158807 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum value in the WebContents' property bag. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10409088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138434 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
MD5Update function uses StringPiece instead of raw buffer. BUG=none TEST=base_unittests --gtest_filter=MD5.ContextWithStringData* Review URL: http://codereview.chromium.org/7466003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94203 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert "Revert "Implement web app definition parsing."" This reverts commit 8d410ce0aae7acbbcd816425ba49e79d8d7b9a1d. TBR=aa@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66398 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add offline_mode support in crx-less apps Added a key in the manifest file "offline_enabled", for crx-less apps to support offline_mode. BUG=101782 TEST=unit_test Review URL: https://chromiumcodereview.appspot.com/10704092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148039 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add offline_mode support in crx-less apps Added a key in the manifest file "offline_enabled", for crx-less apps to support offline_mode. BUG=101782 TEST=unit_test Review URL: https://chromiumcodereview.appspot.com/10704092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148039 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add offline_mode support in crx-less apps Added a key in the manifest file "offline_enabled", for crx-less apps to support offline_mode. BUG=101782 TEST=unit_test Review URL: https://chromiumcodereview.appspot.com/10704092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148039 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert use of int ms to TimeDelta in files owned by brettw. BUG=108171 TEST= Review URL: http://codereview.chromium.org/9233018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert use of int ms to TimeDelta in files owned by brettw. BUG=108171 TEST= Review URL: http://codereview.chromium.org/9233018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add an API to unpack Zip files directly from and to file descriptors. BUG=None TEST=zip_reader_unittest.cc (compiles into 'unit_tests' binary) Review URL: http://codereview.chromium.org/8873039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114684 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix new -Wnull-conversion violations detected by a newer clang. No intended behavior change. BUG=none TEST=none TBR=hans Review URL: https://chromiumcodereview.appspot.com/10383207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137374 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add an API to unpack Zip files directly from and to file descriptors. BUG=None TEST=zip_reader_unittest.cc (compiles into 'unit_tests' binary) Review URL: http://codereview.chromium.org/8873039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114684 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |