Bbenjhayden@chromium.orgRemove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload()
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Add Cambridge downloads team to OWNERS files. Review URL: http://codereview.chromium.org/8038031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103000 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Use the user's preferred downloads directory for creating the initial download file. BUG=132240 Review URL: https://chromiumcodereview.appspot.com/10905284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157022 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the user's preferred downloads directory for creating the initial download file. BUG=132240 Review URL: https://chromiumcodereview.appspot.com/10905284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157022 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the user's preferred downloads directory for creating the initial download file. BUG=132240 Review URL: https://chromiumcodereview.appspot.com/10905284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157022 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Submitting ByteStream chrome class for Google C++ Readability Review. Review URL: https://chromiumcodereview.appspot.com/10535116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143448 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Submitting ByteStream chrome class for Google C++ Readability Review. Review URL: https://chromiumcodereview.appspot.com/10535116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143448 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean up unused members and constructors from DownloadCreateInfo and DownloadSaveInfo BUG=78085 TEST=unit tests Review URL: http://codereview.chromium.org/9351024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121251 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Use the user's preferred downloads directory for creating the initial download file. BUG=132240 Review URL: https://chromiumcodereview.appspot.com/10905284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157022 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. This CL is equivalent to CLs * http://codereview.chromium.org/10799005, * http://codereview.chromium.org/10836293, * https://chromiumcodereview.appspot.com/10823406, and * http://codereview.chromium.org/10867065 which were previous attempts to land the same functionality. R=benjhayden@chromium.org TBR=jam@chromium.org BUG=123998 BUG=144751 Review URL: https://chromiumcodereview.appspot.com/10900010 TBR=rdsmith@chromium.org Review URL: https://chromiumcodereview.appspot.com/10918024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154445 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move mock download test headers from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10501012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140208 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move download interrupt reasons to content\public (the enum that's used by chrome). The rest keep in content. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9639001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125527 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Kill DownloadItem::IsOtr() Consumers should just remember which DownloadManager they got the item from, or else lookup the item from both managers and rely on the id-space sharing. Also move CreateDownloadItemValue from download_util to download_dom_handler. Reviewers: asanka: * Done: jam: chrome/browser/automation/* jhawkins: downloads_dom_handler.cc rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10805020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. This CL is equivalent to CLs * http://codereview.chromium.org/10799005, * http://codereview.chromium.org/10836293, * https://chromiumcodereview.appspot.com/10823406, and * http://codereview.chromium.org/10867065 which were previous attempts to land the same functionality. R=benjhayden@chromium.org TBR=jam@chromium.org BUG=123998 BUG=144751 Review URL: https://chromiumcodereview.appspot.com/10900010 TBR=rdsmith@chromium.org Review URL: https://chromiumcodereview.appspot.com/10918024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154445 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. This CL is equivalent to CLs * http://codereview.chromium.org/10799005, * http://codereview.chromium.org/10836293, * https://chromiumcodereview.appspot.com/10823406, and * http://codereview.chromium.org/10867065 which were previous attempts to land the same functionality. R=benjhayden@chromium.org TBR=jam@chromium.org BUG=123998 BUG=144751 Review URL: https://chromiumcodereview.appspot.com/10900010 TBR=rdsmith@chromium.org Review URL: https://chromiumcodereview.appspot.com/10918024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154445 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move creation and ownership of DownloadManager from the embedder to content. This matches all the other objects that content depends on. In a followup change, I'll make content support NULL DownloadManagerDelegates to match the rest of the delegate interfaces. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10535026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140761 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. This CL is equivalent to CLs * http://codereview.chromium.org/10799005, * http://codereview.chromium.org/10836293, * https://chromiumcodereview.appspot.com/10823406, and * http://codereview.chromium.org/10867065 which were previous attempts to land the same functionality. R=benjhayden@chromium.org TBR=jam@chromium.org BUG=123998 BUG=144751 Review URL: https://chromiumcodereview.appspot.com/10900010 TBR=rdsmith@chromium.org Review URL: https://chromiumcodereview.appspot.com/10918024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154445 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Improve download performance statistics. I've removed the questionable Download.BandwidthNetwork measurement, and replaced it with measurements designed to answer the question "What is the bottleneck for a download?" Specfically, this includes two new statistics: * Download.DiskBandwidthUsedPercentage: The percentage of the available disk bandwith that was actually used. 100% implies that the disk was the performance bottleneck. * Download.ResourceHandlerBlockedPercentage: The percentage of the time it was alive that the DownloadResourceHandler was throttled for performance reasons. 0% implies that the network was the performance bottleneck. R=benjhayden@chromium.org Review URL: https://chromiumcodereview.appspot.com/10695062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145320 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland Make DownloadManager::GetAllDownloads return all downloads regardless of state, persistence, temporariness, or save page. Callers such as download_status_updater_mac now need to explicitly check whether filenames are empty. Also change some callers from SearchDownloads() over to GetAllDownloads(). This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/ I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something. Reviewers breakdown: Done: rdsmith: * jam: chrome/browser/automation michaeln: chrome/browser/browsing_data jcivelli: content/public/test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155351 BUG=147359 Review URL: https://chromiumcodereview.appspot.com/10913015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155829 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING Changes from original CL only in downloads_api.* Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086 http://crbug.com/140687 Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
RefCounted types should not have public destructors, content/browser part 1 BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10068037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134395 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Review URL: https://chromiumcodereview.appspot.com/10821069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148910 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Review URL: https://chromiumcodereview.appspot.com/10821069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148910 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Review URL: https://chromiumcodereview.appspot.com/10821069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148910 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Review URL: https://chromiumcodereview.appspot.com/10821069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148910 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving file_metadata files under content/browser/download Some cleanup of the file_metadata files (especially for Mac OS). I moved them under content/browser/download and changed the namespace to "content" to match the Linux implementation and the style guide. I also included a small change to the Linux-related unittests. Review URL: https://chromiumcodereview.appspot.com/10821069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148910 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10822030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 9. "Detab" content/browser/download. BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/10069016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132060 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 9. "Detab" content/browser/download. BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/10069016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132060 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift "commit point" for when a download will no longer accept cancels. This CL shifts the commit point for a download to just after the download file release has been dispatched. The download remains IN_PROGRESS as far as the outside world is concerned, but at this point it is committed to continue to completion. BUG=123998 R=benjhayden@chromium.org R=asanka@chromium.org Review URL: https://chromiumcodereview.appspot.com/10950015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158298 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the user's preferred downloads directory for creating the initial download file. BUG=132240 Review URL: https://chromiumcodereview.appspot.com/10905284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157022 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pass the referrer policy with the referrer for the save package code path BUG=124750 TEST=none. That code path doesn't actually use referrers, it just passes empty GURL()s around. But it might one day. And then it supports referrer policies. Hurray. Review URL: https://chromiumcodereview.appspot.com/10387090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136723 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rewrite guts of ResourceLoader and BufferedResourceHandler to suck less. The key change is to the pause/resume behavior. ResourceHandlers are now expected to consume events they receive. They can only defer subsequent processing. It used to be the case that pausing during OnReadCompleted would lead to repeating the call to OnReadCompleted when resumed. This was quite problematic for chained ResourceHandlers. BufferedResourceHandler is now the ResourceController for its downstream ResourceHandler. This enables the ResourceLoader and the BufferedResourceHandler to be more cleanly decoupled. The BufferedResourceHandler buffers network events, determines the mime type of the response, selects the appropriate downstream ResourceHandler, and then it replays the network events. It can now do this independently of the ResourceLoader state machine. OnReadCompleted no longer has an in/out bytes_read parameter. This was used before in a very complicated way by the BufferedResourceHandler to effect the bytes_read parameter of future calls to OnReadCompleted (see the now deleted ResourceLoader::paused_bytes_read_ member variable). ResourceLoader gets a lot simpler and loses a lot of state variables. It no longer needs to track things like pause_count_ or paused_read_bytes_. is_paused_, called_on_response_started_ and has_started_reading_ are all subsumed by deferred_stage_. BufferedResourceLoader is modified extensively to hopefully separate out the states more logically. It now advances through buffering (withholds events from the downstream handler), processing (detects mime type and selects downstream handler), replaying (feeding downstream handler with buffered events) and finally streaming (acts like a simple pass-through) states. R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10578055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144873 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pass the referrer policy with the referrer for the save package code path BUG=124750 TEST=none. That code path doesn't actually use referrers, it just passes empty GURL()s around. But it might one day. And then it supports referrer policies. Hurray. Review URL: https://chromiumcodereview.appspot.com/10387090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136723 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Protect against touching download item from "SavePackage" after observation has been stopped. BUG=150640 Review URL: https://chromiumcodereview.appspot.com/10947011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158314 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING Changes from original CL only in downloads_api.* Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086 http://crbug.com/140687 Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the save_package_browsertest.cc to content_browsertests. Also move mouseleave_browsertest.cc to src\chrome. This is an interactive_ui_tests, and while we can theoretically create another content_browsertest target for interactive tests, it seems pointless for just one test. So run it as part of chrome. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10821089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148970 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 4. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10024066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131770 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the save file code from chrome to content. This is just a file move so the DEPS in content\browser\download is very permissive for now. The one exception is save_package.cc, where I had to split off the usage of SelectFileDialog because the code depended on grit which can't be used in content (circular dependencies in gyp). TBR=rdsmith BUG=82782 Review URL: http://codereview.chromium.org/7373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92623 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |