Eestade@chromium.org[gtk] fix zoom bubble showing up on wrong window
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Move myself into a more specific OWNERS location in content BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10399065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137670 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow a pasted-in crash URL to work. BUG=124843 TEST=as in bug Review URL: http://codereview.chromium.org/10269003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134610 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 3. BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/9960071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131634 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Review URL: https://chromiumcodereview.appspot.com/10941050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
crbug.com/127841 - Request Tablet Site on CB with touch screen. Allow user to request tablet site via a toggle on the wrench menu. Under about-flag & cmd line switch: --enable-request-tablet-site BUG=127841 TEST=Run with flag; URLs to try: whatsmyuseragent.com, whatsmyua.com, slashdot.org, www.espn.com, www,facebook.com, www.google.com toggle "Request tablet site" under wrench menu Review URL: https://chromiumcodereview.appspot.com/10827146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155872 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix the fixme introduced in crrev.com/154287 The issue is that the an output-only parameter (details.did_replace_entry) has its value upon input used as part of the logic. Changes some functions to make this case more obvious. Review URL: https://chromiumcodereview.appspot.com/10920024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154571 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement NavigationControllerWebView.PostURL Used for android WebView.postUrl HasPostData in NavigationEntry is used to indicate to the renderer that the navigation is a http post request. The usage here is slightly overloaded. HasPostData is set when from the renderer side for a http post request. This change also uses it to indicate a browser initiated http post request from PostURL. is_post is added to ViewMsg_Navigate_Params. A BrowserInitiatedPostData field is added to NavigationEntry in order to pass the post data to the renderer. Similar field added to ViewMsg_Navigate_Params. This field is only used for temporarily storing and passing post data to the renderer. Since the post data is also saved in ContentState after loading the it is cleared when ContentState is set. BUG= TEST=New tests passed Review URL: https://chromiumcodereview.appspot.com/10829044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149232 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement NavigationControllerWebView.PostURL Used for android WebView.postUrl HasPostData in NavigationEntry is used to indicate to the renderer that the navigation is a http post request. The usage here is slightly overloaded. HasPostData is set when from the renderer side for a http post request. This change also uses it to indicate a browser initiated http post request from PostURL. is_post is added to ViewMsg_Navigate_Params. A BrowserInitiatedPostData field is added to NavigationEntry in order to pass the post data to the renderer. Similar field added to ViewMsg_Navigate_Params. This field is only used for temporarily storing and passing post data to the renderer. Since the post data is also saved in ContentState after loading the it is cleared when ContentState is set. BUG= TEST=New tests passed Review URL: https://chromiumcodereview.appspot.com/10829044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149232 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove unnecessary calls to .get() in navigation_entry_impl_unittest.cc It's more readable to rely on operator->() for smart pointers. BUG=128449 Review URL: https://codereview.chromium.org/10984017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add UMA metrics to measure potential impact of Fast Tab Close. TEST=Verified Close.Tab.UnloadTime is correct in about:histograms. BUG=142458 Review URL: https://chromiumcodereview.appspot.com/10945042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158627 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add UMA metrics to measure potential impact of Fast Tab Close. TEST=Verified Close.Tab.UnloadTime is correct in about:histograms. BUG=142458 Review URL: https://chromiumcodereview.appspot.com/10945042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158627 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
content: Forward declare SkBitmap instead of including its header file. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/10967009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
content: Forward declare SkBitmap instead of including its header file. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/10967009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] fix zoom bubble showing up on wrong window ... most of the time. Since IsActive doesn't work, it still can show the bubble on the wrong window if two windows both show the same host. BUG=152229 Review URL: https://chromiumcodereview.appspot.com/10979019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] fix zoom bubble showing up on wrong window ... most of the time. Since IsActive doesn't work, it still can show the bubble on the wrong window if two windows both show the same host. BUG=152229 Review URL: https://chromiumcodereview.appspot.com/10979019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming SelectFileDialog for Android Upstreaming the Select File Dialog and its dependencies needed for Chrome on Android BUG=116131 Review URL: https://chromiumcodereview.appspot.com/10916160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157424 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Makes wm2 reset the bounds immediately after cloning the layer for constrained windows. Doing otherwise leads to constrained windows having an empty bounds and getting into a confused state if someone asks for them. BUG=147373 TEST=see bug R=ben@chromium.org,skuhne@chromium.org Review URL: https://codereview.chromium.org/10984032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158804 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove unused field from WebContentsViewAura and add comment as to why value is ignored. BUG=none TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10945037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157669 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 4. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10024066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131770 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix a renderer crash when dragging quickly over tab contents. We were expecting to receive GTK+ events in the following order: drag-motion drag-data-received drag-leave but in some cases, we don't get the drag-data-received event (e.g., if the user is moving the mouse quickly). If that happens, don't send a DragLeave event to the renderer since it doesn't think we're in a drag. BUG=129446 TEST=Open 2 chrome windows, quickly drag a file from the desktop over both windows. This should not crash. Review URL: https://chromiumcodereview.appspot.com/10704144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146016 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement WebContentsView::GetDropData for Mac; disable on Aura I don't know what the appropriate analog is for this UI on Aura, so just disabling it now. BUG=55584 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135785 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't send a DragLeave to the renderer if we didn't send a DragEnter. BUG=136834 TEST=dragging over an interstitial doesn't crash the renderer Review URL: https://chromiumcodereview.appspot.com/10783037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147371 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow empty strings to be written to the clipboard BUG=109810 TEST=manual testing Review URL: https://chromiumcodereview.appspot.com/10532168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142554 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Plumb event flags (shift/alt/ctrl modifiers) for drag/drop events to WebKit. WebKit side changes in https://bugs.webkit.org/show_bug.cgi?id=86236 BUG=125861 TEST=none Review URL: https://chromiumcodereview.appspot.com/10377119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137771 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow empty strings to be written to the clipboard BUG=109810 TEST=manual testing Review URL: https://chromiumcodereview.appspot.com/10532168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142554 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 2. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10014024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131599 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove deprecated gfx::Image::operator NSImage*(). BUG=58030 TEST=Compiles. TBR=rohitrao@chromium.org Review URL: https://chromiumcodereview.appspot.com/10933083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156820 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the rest of the content\test headers that are used by embedders to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140287 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 16 Remove "tab contents". BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/9956154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132571 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContents -> WebContentsImpl, part 2. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10014024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131599 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from content Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |