Tthestig@chromium.orgCleanup: avoid foo ? true : false, part 2.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Improve documentation for the tools for generating size checks, based on comments on: http://codereview.chromium.org/5730003/ Also automated handling of long and unsigned long as suggested in review comments for that CL. BUG=None TEST=Reran generate_ppapi_size_checks.py; produced the same output. Review URL: http://codereview.chromium.org/6014007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69950 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Keep the module in scope when executing scripts. This prevents a crash when the script deletes the plugin object synchronously. This in turn deletes the dispatcher which will make the code returning the out param and exception to the plugin crash. To prevent the crash, this patch adds a way for the proxy to manipulate the refcount of the plugin object so that it's still alive when as long as the scripting message is being processed. A manual test is included. This is not automatically run now. I tried to fit it into the current test infrastructure and found it very challenging, We need to revisit this to allow custom tests to more easily be written. TEST=manual with included plugin and html BUG=none Review URL: http://codereview.chromium.org/6881012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81993 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move PPAPI into the Chrome repo. The old repo was http://ppapi.googlecode.com/ TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64613 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add more testing to trusted graphics_3d. - Add a test to use OpenGLES C API directly. - Add a test calling a couple extensions, if glGetString reports availability. - Add #include <GLES2/gl2.h> and <GLES2/gl2ext.h> to test. BUG=none TEST=ppapi/test_graphics_3d Review URL: https://chromiumcodereview.appspot.com/10544104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PPAPI decryptor implementation. BUG=138139 TEST=none Review URL: https://chromiumcodereview.appspot.com/10827280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152004 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PPAPI decryptor implementation. BUG=138139 TEST=none Review URL: https://chromiumcodereview.appspot.com/10827280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152004 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove VideoDecodeAccelerator::Client::NotifyEndOfStream / PPP_VideoDecoder_Dev::EndOfStream Nobody's ever called it and it doesn't make sense given the API: EOS is signalled when no more bits are available to Decode(), via Flush(). BUG=109819 TEST=trybots Review URL: http://codereview.chromium.org/9186022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117545 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove VideoDecodeAccelerator::Client::NotifyEndOfStream / PPP_VideoDecoder_Dev::EndOfStream Nobody's ever called it and it doesn't make sense given the API: EOS is signalled when no more bits are available to Decode(), via Flush(). BUG=109819 TEST=trybots Review URL: http://codereview.chromium.org/9186022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117545 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add DEPS include rules so we don't accidentally use chromium stuff. I basically turned off everything that is turned on in the root DEPS file, and then selectively turned stuff on. I had to provide some macros to replace the use of base/compilerspecific.h and build/buildconfig.h. I'm not sure if we have a coherent understanding of private vs trusted yet, but my thinking is that trusted can do anything, but private can't use trusted (it sounds like we may start selectively exposing some private interfaces to installed apps). BUG=None TEST=None Review URL: http://codereview.chromium.org/8764004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112512 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix back-to-back StartPlayback/StopPlayback issue in PPAPI IPC proxy where subsequent StartPlayback on the same audio device was not triggering audio callbacks. BUG=144037 TEST=updated test included Review URL: https://chromiumcodereview.appspot.com/10868034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153359 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix back-to-back StartPlayback/StopPlayback issue in PPAPI IPC proxy where subsequent StartPlayback on the same audio device was not triggering audio callbacks. BUG=144037 TEST=updated test included Review URL: https://chromiumcodereview.appspot.com/10868034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153359 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add RecommendSampleRate() to audio config test. BUG=none TEST=this is the test Review URL: https://chromiumcodereview.appspot.com/10534152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142867 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add RecommendSampleRate() to audio config test. BUG=none TEST=this is the test Review URL: https://chromiumcodereview.appspot.com/10534152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142867 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add infobar for PPAPI broker usage. BUG=142639 Review URL: https://chromiumcodereview.appspot.com/10826164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154742 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add infobar for PPAPI broker usage. BUG=142639 Review URL: https://chromiumcodereview.appspot.com/10826164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154742 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement right-to-left text rendering in Pepper. TEST=included BUG=http://crbug.com/134394 Review URL: https://chromiumcodereview.appspot.com/10658037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144623 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement right-to-left text rendering in Pepper. TEST=included BUG=http://crbug.com/134394 Review URL: https://chromiumcodereview.appspot.com/10658037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144623 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
In ppapi/tests: |... const*| -> |const ...*| (for consistency). Also fix a bunch of |reinterpret_cast|s (to |static_cast|). So we can stop cutting-and-pasting the same mistakes over and over. Review URL: http://codereview.chromium.org/8879009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add compile assertions to enforce the sizes of all structs and enums in the C API. Adjust some structs to make their sizes consistent across architectures. Note that some structs contain pointers, so are difficult to make consistent between 32-bit and 64-bit. Those types are in test_struct_sizes.c. Other types have a compile assertion immediately after their definition. This was broken off from a bigger CL: http://codereview.chromium.org/5340003/ BUG=61004,92983 TEST=test_struct_sizes.c, compile assertions throughout See this CL for the code that helped generate the static assertions and find affected interfaces: http://codereview.chromium.org/5730003 Review URL: http://codereview.chromium.org/5674004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69038 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
PPAPI: Make blocking completion callbacks work. This also makes scoped_refptr<TrackedCallback> the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks. When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet. BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10081020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Make blocking completion callbacks work. This also makes scoped_refptr<TrackedCallback> the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks. When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet. BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10081020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable PPAPINaCl GLIBC browser_tests. NOTE: NaCl CL to update untrusted.gypi must go in first. BUG=127699 TEST=this is a test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140786 Review URL: https://chromiumcodereview.appspot.com/10409032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140917 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Patch to fix problems with PPB_URLLoader_Impl and PPAPITests.URLLoader. The cross-origin test doesn't properly check for an error, and the custom-referrer change broke cross-origin requests as a result. Also, there was confusion with some errors being reported as PP_ERROR_FAILED and others as PP_ERROR_NOACCESS. After conversations with WebKit folks, it seems unlikely that a consistent system of error codes can be added, so instead, have PPB_URLLoader_Impl::didFail report PP_ERROR_NOACCESS for unknown error domains (WebKit) and switch on net::kErrorDomain errors from our lower level WebURLLoader. Review URL: http://codereview.chromium.org/7046091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89405 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert resources to take an instance key instead of an Instance*. Review URL: https://chromiumcodereview.appspot.com/9381010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123795 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move the charset inteface to "trusted" (we can't implement this efficiently in NaCl) and modify to no longer require the memory interface. This keeps the old interface and implements it in terms of the newer one. We can remove it when all callers have been updated. BUG= TEST= Review URL: http://codereview.chromium.org/9348069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121159 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add compile assertions to enforce the sizes of all structs and enums in the C API. Adjust some structs to make their sizes consistent across architectures. Note that some structs contain pointers, so are difficult to make consistent between 32-bit and 64-bit. Those types are in test_struct_sizes.c. Other types have a compile assertion immediately after their definition. This was broken off from a bigger CL: http://codereview.chromium.org/5340003/ BUG=61004,92983 TEST=test_struct_sizes.c, compile assertions throughout See this CL for the code that helped generate the static assertions and find affected interfaces: http://codereview.chromium.org/5730003 Review URL: http://codereview.chromium.org/5674004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69038 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
In ppapi/tests: |... const*| -> |const ...*| (for consistency). Also fix a bunch of |reinterpret_cast|s (to |static_cast|). So we can stop cutting-and-pasting the same mistakes over and over. Review URL: http://codereview.chromium.org/8879009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
In ppapi/tests: |... const*| -> |const ...*| (for consistency). Also fix a bunch of |reinterpret_cast|s (to |static_cast|). So we can stop cutting-and-pasting the same mistakes over and over. Review URL: http://codereview.chromium.org/8879009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Test for --nacl-gdb functionality. I expanded access rights for NaCl loader (launched under nacl-gdb) process handle from QueryLimitedInformation to QueryInformation because Windows XP doesn't support QueryLimitedInformation. However, this test is switched off on Windows 32-bit due to problems with allocating 1Gb of address space. Future nacl-gdb must have special launching code to solve this problem. BUG= 117010 TEST= browser_tests.exe --gtest_filter=NaClGdbTest.* (on Windows) Review URL: http://codereview.chromium.org/9662055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127453 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Test for --nacl-gdb functionality. I expanded access rights for NaCl loader (launched under nacl-gdb) process handle from QueryLimitedInformation to QueryInformation because Windows XP doesn't support QueryLimitedInformation. However, this test is switched off on Windows 32-bit due to problems with allocating 1Gb of address space. Future nacl-gdb must have special launching code to solve this problem. BUG= 117010 TEST= browser_tests.exe --gtest_filter=NaClGdbTest.* (on Windows) Review URL: http://codereview.chromium.org/9662055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127453 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix flaky PPAPITest.FileIO_NotAllowMixedReadWrite, re-enable NotAllowMixedReadWrite starts a Write, then checks that various other calls aren't allowed at the same time. But each of these uses TestCompletionCallback::WaitForResult, which runs a nested message loop. So the Write can complete any time that happens, meaning the later calls won't always fail with PP_ERROR_INPROGRESS. Also re-enable PPAPINaCl[GLibc|NewLib]Test.FileIO_NotAllowMixedReadWrite BUG=134442 TEST= Review URL: https://chromiumcodereview.appspot.com/10660010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144060 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Refactor ppapi test callbacks to ease testing blocking callbacks. There are really 3 changes to test_utils: - Change "force_async_" to "callback_type_" so that we can represent REQUIRED, OPTIONAL, _and_ BLOCKING. (I left backwards compatibility with force_async_ and will follow up to change them all after this CL). - Add a new form of WaitForResult and a new CHECK_CALLBACK_BEHAVIOR macro. This simplifies checking that the callback ran as expected (i.e., asynchronous or not). test_url_loader.cc in this CL is a good example of the new form. (My intent is to remove the existing WaitForResult in the aforementioned follow-up CL). - Add TestCompletionCallback::GetCallback. This is a minor thing, but it means we can get rid of a bunch of ugly "static_cast<pp::CompletionCallback>" in the tests (see test_websocket.cc for an example of that). BUG=92909 TEST= Review URL: http://codereview.chromium.org/9937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131215 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
This adds an interface for setting crash data from a plugin. It also provides an implementation for setting crash URLs. BUG=134176 TEST=Added test case to sanity check API call. Also hooked up to flash and produced a crash and checked that the report included the document url (http://crash/reportdetail?reportid=1719cae3a745f633) Review URL: https://chromiumcodereview.appspot.com/10681006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144516 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This adds an interface for setting crash data from a plugin. It also provides an implementation for setting crash URLs. BUG=134176 TEST=Added test case to sanity check API call. Also hooked up to flash and produced a crash and checked that the report included the document url (http://crash/reportdetail?reportid=1719cae3a745f633) Review URL: https://chromiumcodereview.appspot.com/10681006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144516 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Only paste the fragment of text which was copied to the clipboard. This also changes how clipboard data is copied on windows. Previously we would copy: "<html>\r\n<body>\r\n<!--StartFragment-->\r\n[CONTENT]\r\n<!--EndFragment-->\r\n</body>\r\n</html>" However, when pasting this content, we paste everything that's contained between <!--StartFragment--> and <!--EndFragment-->. Thus, we get additional new lines in our pasted content that did not exist in the copied content. AFAICT there is no reason to add this additional newlines when copying clipboard data. BUG=130827 TEST=Ran updated test case. Review URL: https://chromiumcodereview.appspot.com/10539028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144932 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added RTF support to pepper API. BUG=120435 TEST=out/Release/browser_tests --gtest_filter=*PPAPITest.*Clipboard* Review URL: http://codereview.chromium.org/9921018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130223 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI (Flash): Fix FileModuleLocal::GetDirContents(). Oops, we can't just keep the PP_DirEntry_Dev. Review URL: https://chromiumcodereview.appspot.com/10696206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146441 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pepper Flash: Add trivial C++ wrappers for PPB_Flash_File_{ModuleLocal,FileRef}. Review URL: https://chromiumcodereview.appspot.com/10638007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144032 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Refactor ppapi test callbacks to ease testing blocking callbacks. There are really 3 changes to test_utils: - Change "force_async_" to "callback_type_" so that we can represent REQUIRED, OPTIONAL, _and_ BLOCKING. (I left backwards compatibility with force_async_ and will follow up to change them all after this CL). - Add a new form of WaitForResult and a new CHECK_CALLBACK_BEHAVIOR macro. This simplifies checking that the callback ran as expected (i.e., asynchronous or not). test_url_loader.cc in this CL is a good example of the new form. (My intent is to remove the existing WaitForResult in the aforementioned follow-up CL). - Add TestCompletionCallback::GetCallback. This is a minor thing, but it means we can get rid of a bunch of ugly "static_cast<pp::CompletionCallback>" in the tests (see test_websocket.cc for an example of that). BUG=92909 TEST= Review URL: http://codereview.chromium.org/9937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131215 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Refactor ppapi test callbacks to ease testing blocking callbacks. There are really 3 changes to test_utils: - Change "force_async_" to "callback_type_" so that we can represent REQUIRED, OPTIONAL, _and_ BLOCKING. (I left backwards compatibility with force_async_ and will follow up to change them all after this CL). - Add a new form of WaitForResult and a new CHECK_CALLBACK_BEHAVIOR macro. This simplifies checking that the callback ran as expected (i.e., asynchronous or not). test_url_loader.cc in this CL is a good example of the new form. (My intent is to remove the existing WaitForResult in the aforementioned follow-up CL). - Add TestCompletionCallback::GetCallback. This is a minor thing, but it means we can get rid of a bunch of ugly "static_cast<pp::CompletionCallback>" in the tests (see test_websocket.cc for an example of that). BUG=92909 TEST= Review URL: http://codereview.chromium.org/9937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131215 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove NewRequiredCallback. This is the same as NewCallback, and we want people to normally use the "required" type. So just having them call NewCallback is usually the right thing. This converts the existing callers to just say NewCallback. BUG= TEST= Review URL: http://codereview.chromium.org/9615050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125965 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Introduce PPB_Flash_MessageLoop interface for Pepper Flash. Comparing with PPB_Flash.RunMessageLoop/QuitMessageLoop, this new interface avoids leaking nested message loops. If Quit() is not called to balance the call to Run(), the outermost message loop will be quitted when the resource is destroyed. BUG=109340 TEST=test_flash_message_loop.{h,cc} Review URL: http://codereview.chromium.org/9188045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119873 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Refactor ppapi test callbacks to ease testing blocking callbacks. There are really 3 changes to test_utils: - Change "force_async_" to "callback_type_" so that we can represent REQUIRED, OPTIONAL, _and_ BLOCKING. (I left backwards compatibility with force_async_ and will follow up to change them all after this CL). - Add a new form of WaitForResult and a new CHECK_CALLBACK_BEHAVIOR macro. This simplifies checking that the callback ran as expected (i.e., asynchronous or not). test_url_loader.cc in this CL is a good example of the new form. (My intent is to remove the existing WaitForResult in the aforementioned follow-up CL). - Add TestCompletionCallback::GetCallback. This is a minor thing, but it means we can get rid of a bunch of ugly "static_cast<pp::CompletionCallback>" in the tests (see test_websocket.cc for an example of that). BUG=92909 TEST= Review URL: http://codereview.chromium.org/9937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131215 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Refactor ppapi test callbacks to ease testing blocking callbacks. There are really 3 changes to test_utils: - Change "force_async_" to "callback_type_" so that we can represent REQUIRED, OPTIONAL, _and_ BLOCKING. (I left backwards compatibility with force_async_ and will follow up to change them all after this CL). - Add a new form of WaitForResult and a new CHECK_CALLBACK_BEHAVIOR macro. This simplifies checking that the callback ran as expected (i.e., asynchronous or not). test_url_loader.cc in this CL is a good example of the new form. (My intent is to remove the existing WaitForResult in the aforementioned follow-up CL). - Add TestCompletionCallback::GetCallback. This is a minor thing, but it means we can get rid of a bunch of ugly "static_cast<pp::CompletionCallback>" in the tests (see test_websocket.cc for an example of that). BUG=92909 TEST= Review URL: http://codereview.chromium.org/9937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131215 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: avoid foo ? true : false, part 2. Review URL: https://chromiumcodereview.appspot.com/10942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157509 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cache image data objects. This will re-use ImageData and mapped memory when you do ReplaceContents within a few seconds of doing a previous one. Hopefully this will speed up 2D painting. BUG=142507 Review URL: https://chromiumcodereview.appspot.com/10823378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152792 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add more testing to trusted graphics_3d. - Add a test to use OpenGLES C API directly. - Add a test calling a couple extensions, if glGetString reports availability. - Add #include <GLES2/gl2.h> and <GLES2/gl2ext.h> to test. BUG=none TEST=ppapi/test_graphics_3d Review URL: https://chromiumcodereview.appspot.com/10544104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add more testing to trusted graphics_3d. - Add a test to use OpenGLES C API directly. - Add a test calling a couple extensions, if glGetString reports availability. - Add #include <GLES2/gl2.h> and <GLES2/gl2ext.h> to test. BUG=none TEST=ppapi/test_graphics_3d Review URL: https://chromiumcodereview.appspot.com/10544104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added C++ wrappers for PPB_HostResolver_Private interface. BUG=114225 TEST=*HostResolverPrivate Review URL: http://codereview.chromium.org/9701024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127929 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added C++ wrappers for PPB_HostResolver_Private interface. BUG=114225 TEST=*HostResolverPrivate Review URL: http://codereview.chromium.org/9701024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127929 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
In ppapi/tests: |... const*| -> |const ...*| (for consistency). Also fix a bunch of |reinterpret_cast|s (to |static_cast|). So we can stop cutting-and-pasting the same mistakes over and over. Review URL: http://codereview.chromium.org/8879009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Test for Pepper IME events. This patch adds a way to simulate IME composition events inside the renderer process, and tests that IME events are properly passed between the renderer and plugins. ppapi/tests/test_ime_input_event.cc: is the actual test case ppapi/{api,c,cpp}/dev/*ime_input_event_dev*: implements an API to create IME events from plugins for testing. other files: wire necessary stuff for simulating IME events. Since Pepper IME events are not delivered through WebKit/DOM layer but rather directly sent from renderer to plugins, the simulation part also follows the similar code path. BUG=126714 TEST=browser_tests PPAPITest.ImeInputEvent Review URL: https://chromiumcodereview.appspot.com/10391101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138080 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Test for Pepper IME events. This patch adds a way to simulate IME composition events inside the renderer process, and tests that IME events are properly passed between the renderer and plugins. ppapi/tests/test_ime_input_event.cc: is the actual test case ppapi/{api,c,cpp}/dev/*ime_input_event_dev*: implements an API to create IME events from plugins for testing. other files: wire necessary stuff for simulating IME events. Since Pepper IME events are not delivered through WebKit/DOM layer but rather directly sent from renderer to plugins, the simulation part also follows the similar code path. BUG=126714 TEST=browser_tests PPAPITest.ImeInputEvent Review URL: https://chromiumcodereview.appspot.com/10391101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138080 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ppapi: Make sure the touch-event interface is detected correctly. BUG=145235 Review URL: https://chromiumcodereview.appspot.com/10873074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154085 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ppapi: Make sure the touch-event interface is detected correctly. BUG=145235 Review URL: https://chromiumcodereview.appspot.com/10873074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154085 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-land http://codereview.chromium.org/9403039/, r124106 Original description: """ PPAPI: Really force-free NPObjects on Instance destruction. (There still seems to be a memory leak with this patch; I may have to check our NPObject reference counting next.) BUG=114023 TEST= """ BUG=114023 TEST= TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/9564024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127273 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Re-land http://codereview.chromium.org/9403039/, r124106 Original description: """ PPAPI: Really force-free NPObjects on Instance destruction. (There still seems to be a memory leak with this patch; I may have to check our NPObject reference counting next.) BUG=114023 TEST= """ BUG=114023 TEST= TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/9564024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127273 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10790078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154238 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10790078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154238 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new MouseCursor interface for setting the mouse cursor. Remove most of the old cursor control interface. This keeps backwards compat for CursorControl.SetCursor (which just redirects to the new function) to kepe existing users running. None of the other functions on cursor control were implemented, so I removed all the proxying and stuff for them. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9814015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131314 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new MouseCursor interface for setting the mouse cursor. Remove most of the old cursor control interface. This keeps backwards compat for CursorControl.SetCursor (which just redirects to the new function) to kepe existing users running. None of the other functions on cursor control were implemented, so I removed all the proxying and stuff for them. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9814015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131314 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
More correct disabling of SucceedWhenAllowed due to timeouts. BUG=136548 TBR=yzshen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10695127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145930 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix PPB_MouseLock.LockMouse crash and add tests. Because mouse lock tests require focus, the new tests are put in interactive_ui_tests. In this CL, ppapi_uitest is split into three parts: 1) ppapi_test: contains PPAPITestBase and its subclasses. 2) ppapi_browsertest: used by browser_tests. 3) ppapi_interactive_browsertest: used by interactive_ui_tests. Besides, they are moved into a new folder, chrome/test/ppapi. (1) and (2) are less interesting since they are mostly copied from ppapi_uitest. BUG=135206 TEST= Review URL: https://chromiumcodereview.appspot.com/10699045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145708 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add CreateFromIPv[46]Address() in PPB_NetAddress_Private. Review URL: http://codereview.chromium.org/9722008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128322 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add CreateFromIPv[46]Address() in PPB_NetAddress_Private. Review URL: http://codereview.chromium.org/9722008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128322 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPB_NetAddress_Private: add getter methods for sockaddr. This CL is mostly contributed by Vinay(vinaya@adobe.com): http://codereview.chromium.org/9235035 Comparing with 9235035, this change: - fixes the NaCl Proxy. - adds untrusted tests. - does other small fixes. BUG=None TEST=test_net_address_private and test_net_address_private_untrusted Review URL: https://chromiumcodereview.appspot.com/9307115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121106 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPB_NetAddress_Private: add getter methods for sockaddr. This CL is mostly contributed by Vinay(vinaya@adobe.com): http://codereview.chromium.org/9235035 Comparing with 9235035, this change: - fixes the NaCl Proxy. - adds untrusted tests. - does other small fixes. BUG=None TEST=test_net_address_private and test_net_address_private_untrusted Review URL: https://chromiumcodereview.appspot.com/9307115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121106 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
NaCl proxy for PPB_NetworkMonitor_Private BUG=139965 Review URL: https://chromiumcodereview.appspot.com/10823187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150946 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add NetworkListObserver utility class. BUG=114808 Review URL: https://chromiumcodereview.appspot.com/9696051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128015 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix line endings in ppapi. No code change. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10052028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move paint aggregator and the completion callback factory. [Reland of 116281] Move paint aggregator and the completion callback factory to the ppapi/helpers directory since they're not strictly wrappers. Review URL: http://codereview.chromium.org/9030001 Review URL: http://codereview.chromium.org/9122012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116759 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Dial back the PostMessage threading test and re-enable on Win The test runs fine for me on a 32-bit Win XP machine, so I'm speculating it was just timing out on the bots. Timeout was probably especially likely when the PostMessage tests were all run together. BUG=95557 TEST= Review URL: https://chromiumcodereview.appspot.com/9358030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121255 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Implement in-process PPB_VarArrayBuffer_Dev. +tony TBR for webkit/glue/webkit_glue.gypi BUG=103435 TEST=N/A TBR=tony Review URL: http://codereview.chromium.org/8930010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114700 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Introduce PPB_ResourceArray_Dev. TEST=test_resource_array.{h,cc} BUG=None Review URL: http://codereview.chromium.org/9111008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116789 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Introduce PPB_ResourceArray_Dev. TEST=test_resource_array.{h,cc} BUG=None Review URL: http://codereview.chromium.org/9111008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116789 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert resources to take an instance key instead of an Instance*. Review URL: https://chromiumcodereview.appspot.com/9381010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123795 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add compile assertions to enforce the sizes of all structs and enums in the C API. Adjust some structs to make their sizes consistent across architectures. Note that some structs contain pointers, so are difficult to make consistent between 32-bit and 64-bit. Those types are in test_struct_sizes.c. Other types have a compile assertion immediately after their definition. This was broken off from a bigger CL: http://codereview.chromium.org/5340003/ BUG=61004,92983 TEST=test_struct_sizes.c, compile assertions throughout See this CL for the code that helped generate the static assertions and find affected interfaces: http://codereview.chromium.org/5730003 Review URL: http://codereview.chromium.org/5674004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69038 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Noop change (+bonus style fix) to trigger nacl tests to be rebuilt. This should fix test failures on windows bots caused by crrev.com/150946 TBR=dmichael@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150959 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added CPP wrapper for PPB_TCPServerSocket_Private. BUG= TEST=PPAPI(NaCl?)Test.TestTCPServerSocketPrivate Review URL: http://codereview.chromium.org/9568007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126367 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added test for disallowed tcp server socket API. BUG= TEST=PPAPINaClTestDisallowedSockets.TCPServerSocketPrivateDisallowed Review URL: http://codereview.chromium.org/9491007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126068 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added test for disallowed tcp server socket API. BUG= TEST=PPAPINaClTestDisallowedSockets.TCPServerSocketPrivateDisallowed Review URL: http://codereview.chromium.org/9491007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126068 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added a pepper test for SSLHandshake. This starts an SSL server which the test can connect to. BUG=114626 TEST=Ran pepper TCP tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128266 Review URL: http://codereview.chromium.org/9791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128374 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added a pepper test for SSLHandshake. This starts an SSL server which the test can connect to. BUG=114626 TEST=Ran pepper TCP tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128266 Review URL: http://codereview.chromium.org/9791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128374 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move socket API restriction check to browser process BUG=112961 TEST=ui_tests --gtest_filter=*TCPSocket* Review URL: http://codereview.chromium.org/9379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122326 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move socket API restriction check to browser process BUG=112961 TEST=ui_tests --gtest_filter=*TCPSocket* Review URL: http://codereview.chromium.org/9379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122326 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
This adds the following to functions to the ppapi TCPSocket interface: 1) GetServer certificate, which returns the server X509Certificate if an SSL connection has been established. 2) AddChainBuilding certificate. This is currently unimplemented in Chrome but the interface and plumbing has been added so it can easily be hooked up. This should add a trusted/untrusted chain building certificate to be used by the client for a particular connection when performing the SSL handshake. BUG=114626 TEST=out/Release/browser_tests --gtest_filter=*PPAPITest.*TCP*Trusted* Review URL: http://codereview.chromium.org/9699100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131918 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This adds the following to functions to the ppapi TCPSocket interface: 1) GetServer certificate, which returns the server X509Certificate if an SSL connection has been established. 2) AddChainBuilding certificate. This is currently unimplemented in Chrome but the interface and plumbing has been added so it can easily be hooked up. This should add a trusted/untrusted chain building certificate to be used by the client for a particular connection when performing the SSL handshake. BUG=114626 TEST=out/Release/browser_tests --gtest_filter=*PPAPITest.*TCP*Trusted* Review URL: http://codereview.chromium.org/9699100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131918 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
AllowBroadcast() is exposed to NaCl. BUG=136797 TEST=browser_tests:*.UDPSocketPrivate Review URL: https://chromiumcodereview.appspot.com/10735056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154407 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
AllowBroadcast() is exposed to NaCl. BUG=136797 TEST=browser_tests:*.UDPSocketPrivate Review URL: https://chromiumcodereview.appspot.com/10735056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154407 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move socket API restriction check to browser process BUG=112961 TEST=ui_tests --gtest_filter=*TCPSocket* Review URL: http://codereview.chromium.org/9379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122326 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move socket API restriction check to browser process BUG=112961 TEST=ui_tests --gtest_filter=*TCPSocket* Review URL: http://codereview.chromium.org/9379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122326 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
In ppapi/tests: |... const*| -> |const ...*| (for consistency). Also fix a bunch of |reinterpret_cast|s (to |static_cast|). So we can stop cutting-and-pasting the same mistakes over and over. Review URL: http://codereview.chromium.org/8879009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Make blocking completion callbacks work. This also makes scoped_refptr<TrackedCallback> the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks. When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet. BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10081020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added bounds checks to the URLLoader prefetch buffer threshhold. BUG=89842 TEST=./ui_tests --gtest_filter=PPAPITest.URLLoader*PrefetchBufferThreshold Review URL: http://codereview.chromium.org/9139076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117970 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Add an API for setting a custom user agent for URL requests. This doesn't hook it up yet. Pepper Flash needs this for RTMPT. BUG=134615 TEST=not really (except for trivial URL request test) Review URL: https://chromiumcodereview.appspot.com/10762017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145885 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI URLRequestInfo test: port NaCl version to ppapi_tests. Fix Var and Resource leaks. I had to also port a couple of constants and helpers from native_client/ppapi_test_lib. TEST=ui_tests BUG=110242 Review URL: https://chromiumcodereview.appspot.com/9174020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119522 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert resources to take an instance key instead of an Instance*. Review URL: https://chromiumcodereview.appspot.com/9381010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123795 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland http://codereview.chromium.org/8477015 Landed at r109114, Reverted at r109142 Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests. The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before. This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces. BUG=102885 TEST=N/A TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/8536031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110248 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10790078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154238 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10790078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154238 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered. BUG=108308,108314 TEST= Review URL: http://codereview.chromium.org/8982006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115503 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Update PPAPI IDL generator to define versioned structs, and unversioned typedef. For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged. (Follow-up to discussion on CL 8931019) *** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( *** We need to define a versioned-named struct for each interface's current version. We could: 1. Carry on defining the current struct unversioned and typedef a versioned name for it. The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added. 2. Define structs for all versions, and a separate unversioned struct. This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces. 3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected. *** Contents of this CL, including notes on to-dos: This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values. Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted). The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use. The VideoDecoder interface size checks are for 32-bit are updated not to expect structs. It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions. PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private. The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned. The typedef hack in PPP_Instance IDL is gone. Yay. BUG=107398,108379 TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly. Review URL: http://codereview.chromium.org/8989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix line endings in ppapi. No code change. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10052028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix line endings in ppapi. No code change. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10052028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow to release WebSocket resource in completion callbacks invoked by Close(). - Protect |this| around invoking plugin callbacks - Add unit tests to check the case BUG= TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/10661026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144872 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
WebSocket Pepper API: synchronous completion support. Allow optional remote callback, then perform synchronous completion if receiving data is enough small for SRPC buffer. Otherwise invoke another callback for asynchronous completion from main thread. BUG=87310 TEST=browser_tests --gtest_filter=PPAPINaclTest.WebSocket_StressedSendReceive Review URL: https://chromiumcodereview.appspot.com/9802027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132413 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixed some PP_X509Certificate_Private_Field enum values. -Added PP_X509CERTIFICATE_PRIVATE_SUBJECT_DISTINGUISHED_NAME/PP_X509CERTIFICATE_PRIVATE_ISSUER_DISTINGUISHED_NAME which I had missed originally. -Renamed: PP_X509CERTIFICATE_PRIVATE_ALGORITHM_OID -> PP_X509CERTIFICATE_PRIVATE_SIGNATURE_ALGORITHM_OID PP_X509CERTIFICATE_PRIVATE_ALGORITHM_PARAMATERS_RAW -> PP_X509CERTIFICATE_PRIVATE_SIGNATURE_ALGORITHM_PARAMATERS_RAW To be in-line with the flash names. This also fixes a bug in the tcp socket shared implementation which allows a resource to be released in a callback, before it is finished cleaning up. BUG=114626 TEST=out/Debug/browser_tests --gtest_filter=*PPAPITest.*X509Certificate* Review URL: http://codereview.chromium.org/10006048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132013 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the PPAPI X509 Certificate interface and implementation. Adds the interface for accessing X509 certificate fields. Note that the interface uses a GetField(field) method for accessing various fields of the certificate and all resuls are returned as pp::Var. This greatly simplifies the implementation of the interface and process of adding/changing fields so it is probably better (at least in the short term for flash). BUG=114626 TEST=out/Debug/ui_tests --gtest_filter=*PPAPITest.*X509Certificate* NOTRY=true Review URL: http://codereview.chromium.org/9693024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ppapi: Add test for touch-event support. BUG=128236 TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/10665007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144796 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add infobar for PPAPI broker usage. BUG=142639 Review URL: https://chromiumcodereview.appspot.com/10826164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154742 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |