Ssteveblock@chromium.orgMake 'License' field in third-party metadata required
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Pass tools/licenses.py for more directories. We're now down to only 4 dirs that don't pass the license checker. They will require separate changes. Modify the license checker to only print failing dirs. BUG=39240 Review URL: http://codereview.chromium.org/1530040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44656 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Make 'License' field in third-party metadata required This will simplify the addition of a tool to check licenses for the purpose of the Android WebView build. See also http://codereview.chromium.org/10827099 Also adds other missing fields to these README.chromium files as required by presubmit checks and fixes a regex used to enforce this. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10821103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add third_party to the repository. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Fourth attempt at the following. Unreviewed, this was originally reviewed in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7903016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101378 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add third_party to the repository. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Add an #if to modp_b64_data.h to avoid a typedef conflict that certain finicky compilers (in particular, nacl-g++) complain about. Contributed by mdsteele@google.com BUG=none TEST=Try to compile modp_b64 with nacl-g++ Review URL: http://codereview.chromium.org/3044045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55137 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 |