Sshess@chromium.orgFix clang warning in sqlite shell_icu_linux.c.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Upstream commit in trunk: http://www.sqlite.org/src/info/f9c4a7c8f4 Upstream commits in branch-3.7.6: http://www.sqlite.org/src/info/a61786e760 (third hunk) http://www.sqlite.org/src/info/e6a04bf9f1 (correction) I have left out the comment addition seen in the trunk commit, because the backport to the 3.7.6 branch doesn't include it. [Patch from Evangelos Foutras <evangelos@foutrelis.com> ] BUG=122525 TEST=distros using gcc4.7 shouldn't crash. see bug. R=shess@chromium.org Review URL: https://chromiumcodereview.appspot.com/10387026 Patch from Evangelos Foutras <evangelos@foutrelis.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141687 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix clang warning in sqlite shell_icu_linux.c. Add include file per bug. BUG=138571 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10825225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shift SQLite LICENSE file to root dir. SQLite no longer includes an explicit LICENSE file. This is the one it used to include, placed outside the import tree to prevent merge conflicts. This matches the notice at the top of sqlite3.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/9373050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121510 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make 'License' field in third-party metadata required This will simplify the addition of a tool to check licenses for the purpose of the Android WebView build. See also http://codereview.chromium.org/10827099 Also adds other missing fields to these README.chromium files as required by presubmit checks and fixes a regex used to enforce this. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10821103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert to SQLite amalgamation. SQLite generally distributes using a script-generated "Giant file of stuff", called the amalgamation. It's apparently faster, due to more opportunities for optimization, but for Chromium the attraction is that we don't need as many patches to SQLite. Imports of future versions of SQLite should be simpler, so long as an Ubuntu box is available. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6835006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81471 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Import SQLite 3.7.6.3. Ran through the import script in third_party/sqlite/README.Chromium, including the SQLite test suite. A few minor errors under oserror-1.1.[123], I suspect my Linux reference machine is becoming outdated. SQLite changes are going to be hard/impossible to review. It's a year and a half of changes, might as well be a new package. Removed patches which are no longer necessary: icu-regepx.patch is already present safe-tolower.patch is already present attach-integer.patch no longer relevant For attach-integer.patch, the code has been refactored. The failure in http://crbug.com/38745 no longer occurs (ATTACH 12345 as db; attaches the SQLite database "12345" rather than crashing). Tweak test.patch for modern era. Adjusted webdb.patch for new flag. Clean up fts3.patch. fts3 has been substantially refactored, so much of the patch no longer applies. Reviewed fts3_write.c and many of the patches are now handled appropriately. I found one issue in fts3.c, and I'm still reviewing it. This will be ongoing. Disabled WAL (Write Ahead Log) and fts4 support for now as unknown unknowns. BUG=71731 TEST=*EVERYTHING* continues to work. Review URL: http://codereview.chromium.org/6990047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86616 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix authorizer issue with fts3 in WebDatabase. fts3 itself was authorized, but the most recent fts3 implementation calls PRAGMA page_size, and PRAGMA was not authorized. BUG=85522 TEST=See bug. Review URL: http://codereview.chromium.org/7230021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90163 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert to SQLite amalgamation. SQLite generally distributes using a script-generated "Giant file of stuff", called the amalgamation. It's apparently faster, due to more opportunities for optimization, but for Chromium the attraction is that we don't need as many patches to SQLite. Imports of future versions of SQLite should be simpler, so long as an Ubuntu box is available. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6835006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81471 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix clang warning in sqlite shell_icu_linux.c. Add include file per bug. BUG=138571 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10825225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Only do the exclude-journal-from-Time-Machine-if-the-database-is-excluded thing for unix-flavored sqlite3 VFSes. It's wrong to try to do this for the chromium_vfs sqlite3 VFS type. The exclude code should only be used for databases that are actually on disk. Under chromium_vfs, zFilename is a name but not a filesystem pathname, and in the Chromium renderer process, direct filesystem access is forbidden. The resulting CFURLRef objects did not have valid referents, and on Mac OS X 10.7 ("Lion"), they resulted in use-after-free and double-free errors. BUG=91068 TEST=With a clean profile, visit http://www.justgiving.nl/. The page should not sad tab. Nothing should be logged to the console. Previously, messages such as the following would be logged: Google Chrome Helper(12345,0xabcdef00) malloc: *** error for object 0x4545450: incorrect checksum for freed object - object was probably modified after being freed. Google Chrome Helper(12345,0xabcdef00) malloc: *** error for object 0x4545450: double free Review URL: http://codereview.chromium.org/7511011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95435 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert to SQLite amalgamation. SQLite generally distributes using a script-generated "Giant file of stuff", called the amalgamation. It's apparently faster, due to more opportunities for optimization, but for Chromium the attraction is that we don't need as many patches to SQLite. Imports of future versions of SQLite should be simpler, so long as an Ubuntu box is available. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6835006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81471 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup SQLite 3.6.18 import. Get things spic-n-span for converting to the amalgamation, then SQLite 3.7.x. sqlite3Preload -> sqlite3_preload because in the amalgamation, sqlite3_ is the key bit to make sure things aren't marked static. AFAICT, SQLite 3.6.18 was not imported correctly last time, throwing up spurious deltas. Re-import and re-apply patches. Remove a bunch of Gears-related stuff. Quite some time ago the Chromium and Gears SQLite imports were brought into line, but they were never fully shared. Nowadays these are completely useless: - remove fts1 patches. - add a Chromium test to make sure fts1 doesn't sneak in. - drop the Symbian stuff. - drop database poisoning. Pull out the WebDatabase patch into a patch file. Move ICU shell changes into a distinct patch file. Pull out testing patches into a separate test.patch. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6823057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81296 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Upstream commit in trunk: http://www.sqlite.org/src/info/f9c4a7c8f4 Upstream commits in branch-3.7.6: http://www.sqlite.org/src/info/a61786e760 (third hunk) http://www.sqlite.org/src/info/e6a04bf9f1 (correction) I have left out the comment addition seen in the trunk commit, because the backport to the 3.7.6 branch doesn't include it. [Patch from Evangelos Foutras <evangelos@foutrelis.com> ] BUG=122525 TEST=distros using gcc4.7 shouldn't crash. see bug. R=shess@chromium.org Review URL: https://chromiumcodereview.appspot.com/10387026 Patch from Evangelos Foutras <evangelos@foutrelis.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141687 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstream sqlite gyp changes for Android. Includes a change to sql/Connection to propagate the auto_vacuum pragma across a raze operation. Also updates test expectations. BUG=137853 Review URL: https://chromiumcodereview.appspot.com/10829062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150128 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert to SQLite amalgamation. SQLite generally distributes using a script-generated "Giant file of stuff", called the amalgamation. It's apparently faster, due to more opportunities for optimization, but for Chromium the attraction is that we don't need as many patches to SQLite. Imports of future versions of SQLite should be simpler, so long as an Ubuntu box is available. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6835006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81471 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Backport more SQLite changes to enable system-sqlite experiments. BUG=22208 Review URL: http://codereview.chromium.org/7629003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98252 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Import SQLite 3.7.6.3. Ran through the import script in third_party/sqlite/README.Chromium, including the SQLite test suite. A few minor errors under oserror-1.1.[123], I suspect my Linux reference machine is becoming outdated. SQLite changes are going to be hard/impossible to review. It's a year and a half of changes, might as well be a new package. Removed patches which are no longer necessary: icu-regepx.patch is already present safe-tolower.patch is already present attach-integer.patch no longer relevant For attach-integer.patch, the code has been refactored. The failure in http://crbug.com/38745 no longer occurs (ATTACH 12345 as db; attaches the SQLite database "12345" rather than crashing). Tweak test.patch for modern era. Adjusted webdb.patch for new flag. Clean up fts3.patch. fts3 has been substantially refactored, so much of the patch no longer applies. Reviewed fts3_write.c and many of the patches are now handled appropriately. I found one issue in fts3.c, and I'm still reviewing it. This will be ongoing. Disabled WAL (Write Ahead Log) and fts4 support for now as unknown unknowns. BUG=71731 TEST=*EVERYTHING* continues to work. Review URL: http://codereview.chromium.org/6990047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86616 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Import SQLite 3.7.6.3. Ran through the import script in third_party/sqlite/README.Chromium, including the SQLite test suite. A few minor errors under oserror-1.1.[123], I suspect my Linux reference machine is becoming outdated. SQLite changes are going to be hard/impossible to review. It's a year and a half of changes, might as well be a new package. Removed patches which are no longer necessary: icu-regepx.patch is already present safe-tolower.patch is already present attach-integer.patch no longer relevant For attach-integer.patch, the code has been refactored. The failure in http://crbug.com/38745 no longer occurs (ATTACH 12345 as db; attaches the SQLite database "12345" rather than crashing). Tweak test.patch for modern era. Adjusted webdb.patch for new flag. Clean up fts3.patch. fts3 has been substantially refactored, so much of the patch no longer applies. Reviewed fts3_write.c and many of the patches are now handled appropriately. I found one issue in fts3.c, and I'm still reviewing it. This will be ongoing. Disabled WAL (Write Ahead Log) and fts4 support for now as unknown unknowns. BUG=71731 TEST=*EVERYTHING* continues to work. Review URL: http://codereview.chromium.org/6990047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86616 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 |