Xxiyuan@chromium.orgapp_list: Fix app_list_unittests crash.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
app_list: Fix app_list_unittests crash. - Fix crash when enabling layers; - Fix crash when AppsGridView is tested without host widget; BUG=none. TEST=app_list_unittests should pass without crash. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10963040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158175 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui: Keep the overrides in the same section of the superclass. When subclassing a non-pure virtual interface, prefer to keep them in the same section as in the superclass. This was discussed here: http://codereview.chromium.org/10914090/ R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10911098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155291 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland 140878 - cleanup: Remove applist v1 code. - Remove obsolete v1 code and test; - Grid rid of selected_ in AppListItemModel and solely use selected_item_index_ in AppsGridView; - Fix a bug that highlighted item might not be visible and add test to cover it; - Update DEPS; - Fix broken ExtensionInstallUIBrowserTest.AppInstallConfirmation casued by wrong destruction order introduced by r140878 moving app list container on top of launcher container. Fix is to explicitly release app list contoller before launcher container. BUG=125964 TEST=Verify app list always show up as bubble and app_list_unittests should pass. Review URL: https://chromiumcodereview.appspot.com/10533032 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140959 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |