Bbenwells@chromium.orgPosition apps list on Windows near the cursor.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Add myself to new ui/views/bubble/OWNERS. BUG=none TEST=none R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10946021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157577 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Position apps list on Windows near the cursor. This change makes the app list on Windows appear either above or below the cursor. Above the cursor is preferred but the list will be moved below the cursor if there is not enough room. BUG=138632 Review URL: https://chromiumcodereview.appspot.com/10937008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158375 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland: Fix and expand upon BubbleDelegateTests. This is a continuation of https://codereview.chromium.org/10889014 That CL was reverted due to test failures in linux_chromeos and win_aura bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/10785/steps/views_unittests/logs/stdio http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/20590/steps/views_unittests/logs/stdio This revised CL adds a workaround hack for Aura to activate an unrelated Widget before closing the anchor/owner widgets, so that aura::test::TestActivationClient::OnWindowDestroyed doesn't try to activate destroyed windows. Original CL description: =============================================== Fix and expand upon BubbleDelegateTests. BubbleDelegateTest.ResetAnchorWidget was previously failing and crashing because of it's widget ownership pattern and lack of close_on_deactivate. Add TestWidgetObserver to observe bubbles closing. Ensure the bubble widget closes as expected in each test. BUG=none TEST=unit tests pass Review URL: https://chromiumcodereview.appspot.com/10920028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154558 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate bubble border code. Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |