Ddmazzoni@chromium.orgFix toolbar keyboard accessibility on Views (alternative impl).
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate win/x dispatchers BUG=116282 TEST=no functional change. All tests should pass. Review URL: http://codereview.chromium.org/9958152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131412 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
views: Move view.h to ui/views/. BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8742030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112333 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rid the world of the last of views::Event types: TouchEvent, GestureEvent, MouseWheelEvent, ScrollEvent and DropTargetEvent, in favor of ui::Event derivatives. http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
views: Put bounds_animation_unittest.cc into views namespace. TEST=views_unittests R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10790115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148324 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
aura: Fix WidgetFocusChangeListener::OnNativeFocusChange(). In Aura, we were passing the newly-focused view through views::WidgetFocusManager::OnWidgetFocusEvent()'s "focused_before" parameter. This made us not close extension popups when they lost the focus. (Note that a popup still doesn't get closed upon clicking outside of the popup on the desktop, presumably because the popup retains the focus in Ash.) BUG=132697 TEST=added, also manual testing Review URL: https://chromiumcodereview.appspot.com/10562025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142858 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
aura: Fix WidgetFocusChangeListener::OnNativeFocusChange(). In Aura, we were passing the newly-focused view through views::WidgetFocusManager::OnWidgetFocusEvent()'s "focused_before" parameter. This made us not close extension popups when they lost the focus. (Note that a popup still doesn't get closed upon clicking outside of the popup on the desktop, presumably because the popup retains the focus in Ash.) BUG=132697 TEST=added, also manual testing Review URL: https://chromiumcodereview.appspot.com/10562025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142858 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Plumb ClearNativeFocus to DesktopRootWindowHostWin. Get rid of FocusNativeView since it's only called in unittests now. Also removed from Widget. Also, don't send non client mouse events to the RootWindowHostDelegate from DesktopRootWindowHostWin (RootWindowHostWin already does this). This fixes an assert when the message eventually gets to WebInputEventFactory, which doesn't handle non client messages. BUG=146077 Review URL: https://codereview.chromium.org/10951033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157638 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157914 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157914 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui/base/models: Make ComboboxModel::GetItemCount() a constant function. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128961 Review URL: https://chromiumcodereview.appspot.com/9838092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129071 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
ui: Forward declare DefaultSingletonTraits in header files. Prefer forward declarations in header files, and instead include the singleton.h in the source file. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10795024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147660 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui: Forward declare DefaultSingletonTraits in header files. Prefer forward declarations in header files, and instead include the singleton.h in the source file. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10795024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147660 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't close ExtensionPopups on child window focus (Win, non-Aura). Fixes crash on JS dialog popups from the extension bubbles. Check for child HWND in WidgetFocusChangeListener::OnNativeFocusChange. Code from BubbleWidget in browser_bubble_win.cc (crrev.com/112278) See Issue 106958 for Aura, the dialog&bubble close early without crashing. BUG=106723,106958 TEST=The js alert extension attached to the issue doesn't crash, popup works on non-aura. Review URL: http://codereview.chromium.org/8879045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113936 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |