CCopybara-ServiceFix 2 ClangTidyReadability findings:
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Fix 3 ClangTidyReadability findings: * return type 'const ObliviousHttpHeaderKeyConfig' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness For more info see go/clang_tidy/checks/readability-const-return-type (3 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/clang-tidy-bug for category ClangTidyReadability if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/third_party/quiche/METADATA.common which is reachable following include_presubmits from //depot/google3/third_party/quiche/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #clrobot #readability-const-return-type Tested: Local presubmit tests passed. PiperOrigin-RevId: 806553448 | 9 个月前 | |
[Chunked OHTTP] Implementing chunked OHTTP Gateway PiperOrigin-RevId: 798239391 | 10 个月前 | |
Use std::move to avoid making copies of payload. Also cleared some return std::move statements. go/totw/labs/should-i-return-std-move PiperOrigin-RevId: 484023440 | 3 年前 | |
Add debugging string to OHTTP configuration objects This CL also replaces references to draft-ietf-ohai-ohttp with RFC 9458 in comments. PiperOrigin-RevId: 734536146 | 1 年前 | |
Fix 2 ClangTidyReadability findings: * return type 'const ObliviousHttpHeaderKeyConfig' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness For more info see go/clang_tidy/checks/readability-const-return-type (2 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/clang-tidy-bug for category ClangTidyReadability if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/third_party/quiche/METADATA.common which is reachable following include_presubmits from //depot/google3/third_party/quiche/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #clrobot #readability-const-return-type Tested: Local presubmit tests passed. PiperOrigin-RevId: 810299725 | 9 个月前 | |
[Chunked OHTTP] Implementing chunked OHTTP Gateway PiperOrigin-RevId: 798239391 | 10 个月前 | |
Remove unused has_encoded_response_nonce_ member. This fixes an unused-private-field error and unblocks rolling QUICHE to Chromium. PiperOrigin-RevId: 799446461 | 10 个月前 | |
Fix 2 ClangTidyReadability findings: * return type 'const ObliviousHttpHeaderKeyConfig' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness For more info see go/clang_tidy/checks/readability-const-return-type (2 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/clang-tidy-bug for category ClangTidyReadability if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/third_party/quiche/METADATA.common which is reachable following include_presubmits from //depot/google3/third_party/quiche/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #clrobot #readability-const-return-type Tested: Local presubmit tests passed. PiperOrigin-RevId: 810299725 | 9 个月前 |