PPdfium LUCI CQFix double handling the delete key event
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Update old-style copyright headers Updates old-style copyright headers to the new style, by removing "All rights reserved." Also inserts "The" before "PDFium Authors", which is required by both styles. Mechanically generated by this command: PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.' git grep -l "$PATTERN" \ | xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i'' Fixed: pdfium:1884 Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> | 3 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
IWYU: add stdint.h for uint32_t pdfium::annotation_flags Bug: chromium:957519 Change-Id: Id10921a5fdf93a3b92c76c84266696e92d901bd5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/105890 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Fix double handling the delete key event Previously for some embedders (Chrome Linux) that send both OnChar and OnKeyDown for delete, PDFium was double handling the delete key. The OnChar handling was unexpected and was inserting 0x7F as a character in the text field, which caused weird behavior like inserting a * in password fields but not actually having any text if the user performs select all then copies it. This double handling also inserted two items in the undo queue so when the user presses delete, they would have to press undo twice. In JavaScript code the browser only sends a "keydown" event for the delete key so OnKeyDown seemed like the proper place to handle it in PDFium to match the JavaScript event model. There is a testing/resources/pixel/password.in file which I could have generated a pdf for and set up a test fixture for. However I'm not really sure how I would test the phantom * characters issue. The test making sure PDFium doesn't handle OnChar delete should be enough to cover that issue. Fixed: 454273254 Change-Id: Ibccc44b2f6792428eaf7e02439990cb5f55110c6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137190 Auto-Submit: April Kallmeyer <ask@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 个月前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Update old-style copyright headers Updates old-style copyright headers to the new style, by removing "All rights reserved." Also inserts "The" before "PDFium Authors", which is required by both styles. Mechanically generated by this command: PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.' git grep -l "$PATTERN" \ | xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i'' Fixed: pdfium:1884 Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> | 3 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 | |
Replace extern const with inline constexpr in //constants Follow modern practices and move a bunch of constants out of foo.cpp and into foo.h. Change-Id: I49fab670e64ac82ff15761cf81d7789671aeb811 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 1 年前 |