| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Reland "[rust png] Stop using+remove SkXPS...PngHelpers.h from Skia." This CL replaces usage of the helpers with a lambda provided by the callers (e.g. by dm/DMSrcSink.cpp). This CL also removes the helpers altogether, because Chromium and PDFium have already stopped using the helpers in https://crrev.com/c/7090470 and https://pdfium-review.googlesource.com/137410 (the latter rolled into Chromium in https://crrev.com/c/7097284 ). This removal seems desirable based on the following: 1. No need for separate headers. There is no need today for SVG- or XPS-specific encoding options. If such a need arises in the future, then for backcompatibility we would still need to keep the current helpers. And since current helpers are SVG- and XPS-agnostic, then it seems okay to just rely directly on the API in include/encode/...PngEncoder.h headers. 2. No need for separate build components. The separate build components (e.g. skia_xps_libpng_public in gn/xps.gni, xps_libpng_helpers in BUILD.gn, xps_libpng_hdrs in include/docs/BUILD.bazel) were tightly coupled with the PNG encoder implementations. 3. Simplification. After this CL there is less build components to manage: - In theory skia_xps_libpng_public from gn/xps.gni would have to be used in skia/BUILD.gn in Chromium and PDFium. - In theory, in the future we would also have to have even more components - e.g. skia_svg_libpng_public that would provide dependency injection for SkSVGCanvas::Make. 4. Additional concerns (e.g. reducing the risk of breaking Skia clients in the future) have been discussed in more detail during the code review - see https://skia-review.googlesource.com/c/skia/+/1082338/5#message-e592667c4a466ab0b2f52551f07760e9d2f9d960 Bug: chromium:381900683 Change-Id: Idddfeeef20699685a7fe2df6c888c6e306a885d2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1088236 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Łukasz Anforowicz <lukasza@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> | 8 个月前 | |
Remove unnecessary SK_BUILD_FOR_GOOGLE3 checks We don't build tools/tests/dm etc in G3 Change-Id: I38fba1bece2f0a2a16dfb135115c6c931400daa8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1110796 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Auto-Submit: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com> | 7 个月前 | |
Reapply "DM builds with graphite enabled and ganesh disabled" Fixes no-gpu build. Fixes chrome build. This reverts commit 479696a3c5bfeb263a18c9260cb581b20ea4b556. Cq-Include-Trybots: luci.skia.skia.primary:Canary-Chromium Change-Id: Idbbb7759b229d5c28de197151dbb260f26e7c829 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084176 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <briansalomon@gmail.com> Reviewed-by: Greg Daniel <egdaniel@google.com> | 8 个月前 | |
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 | |
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> | 7 年前 | |
Make SkSerialProcs return pointer-to-const This should let us more cleanly fold https://review.skia.org/1084056 into Chromium. The #if guard should let us roll it out incrementally as Chromium, Android and others will need to update some of their callsites. Change-Id: I8b29f5e7306cbfcc7c5be9d7bc04fe0e732a3437 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1109339 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
[graphite] Update testing framework for new Pipeline callback This CL adds a new smoke test for ContextOptions' Pipeline callbacks and a new DM Sink that demonstrates the usage of the new Pipeline callback. Bug: b/455580777 Change-Id: I8438eab8f4421cc1599844aab8ff0d930c2df291 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1080997 Reviewed-by: Thomas Smith <thomsmit@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> | 8 个月前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 8 个月前 | ||
| 7 个月前 | ||
| 8 个月前 | ||
| 1 年前 | ||
| 7 年前 | ||
| 7 个月前 | ||
| 8 个月前 |