| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Reland "[rust png] Stop using+remove SkXPS...PngHelpers.h from Skia." This CL replaces usage of the helpers with a lambda provided by the callers (e.g. by dm/DMSrcSink.cpp). This CL also removes the helpers altogether, because Chromium and PDFium have already stopped using the helpers in https://crrev.com/c/7090470 and https://pdfium-review.googlesource.com/137410 (the latter rolled into Chromium in https://crrev.com/c/7097284 ). This removal seems desirable based on the following: 1. No need for separate headers. There is no need today for SVG- or XPS-specific encoding options. If such a need arises in the future, then for backcompatibility we would still need to keep the current helpers. And since current helpers are SVG- and XPS-agnostic, then it seems okay to just rely directly on the API in include/encode/...PngEncoder.h headers. 2. No need for separate build components. The separate build components (e.g. skia_xps_libpng_public in gn/xps.gni, xps_libpng_helpers in BUILD.gn, xps_libpng_hdrs in include/docs/BUILD.bazel) were tightly coupled with the PNG encoder implementations. 3. Simplification. After this CL there is less build components to manage: - In theory skia_xps_libpng_public from gn/xps.gni would have to be used in skia/BUILD.gn in Chromium and PDFium. - In theory, in the future we would also have to have even more components - e.g. skia_svg_libpng_public that would provide dependency injection for SkSVGCanvas::Make. 4. Additional concerns (e.g. reducing the risk of breaking Skia clients in the future) have been discussed in more detail during the code review - see https://skia-review.googlesource.com/c/skia/+/1082338/5#message-e592667c4a466ab0b2f52551f07760e9d2f9d960 Bug: chromium:381900683 Change-Id: Idddfeeef20699685a7fe2df6c888c6e306a885d2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1088236 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Łukasz Anforowicz <lukasza@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> | 8 个月前 | |
Move SkMultiPictureDocument functions into namespace in include/docs This "internal" file has been used by clients [1] [2], and doesn't expose any private types, so we should properly make it available. This is a requirement due to Bazel sandboxing and layer checking. Rather than dumping functions into the global namespace, this adds a SkMultiPictureDocument namespace with the necessary functions, to align with our more modern design principles. [1] https://source.chromium.org/chromium/chromium/src/+/main:printing/metafile_skia.cc;l=211;drc=610980924c853ea99afac1bc335509814a8fd540 [2] https://android.googlesource.com/platform/frameworks/base/+/0c175e28e5ca9b8056ab94c2281fa1354843e1c3/libs/hwui/pipeline/skia/SkiaPipeline.cpp#298 Change-Id: If05ed134d7b6be4c91dcc558022072a0e72553ce Bug: b/40045064 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/764971 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> | 2 年前 | |
Make SkImage and SkImageGenerator return const SkData from refEncoded This behavior was implied (a shared pointer to SkData should always be treated as read-only) and is now made explicit. This also updates several places in our decoders where we promise not to modify the SkData that is passed in (since we will likely be caching it) and ask that the client not modify it either. This is partially guarded by SK_DISABLE_LEGACY_NONCONST_ENCODED_IMAGE_DATA so we can update Chromium and potentially other places. Change-Id: Id174dff4afa148745ad32dd7d5cd848931b77f9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084056 Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Make SkImage and SkImageGenerator return const SkData from refEncoded This behavior was implied (a shared pointer to SkData should always be treated as read-only) and is now made explicit. This also updates several places in our decoders where we promise not to modify the SkData that is passed in (since we will likely be caching it) and ask that the client not modify it either. This is partially guarded by SK_DISABLE_LEGACY_NONCONST_ENCODED_IMAGE_DATA so we can update Chromium and potentially other places. Change-Id: Id174dff4afa148745ad32dd7d5cd848931b77f9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084056 Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Remove SK_DISABLE_LEGACY_XPS_FACTORIES Change-Id: I983a7c0492a70bff387de8dac3fc68c406fb1ead Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1085556 Auto-Submit: Ben Wagner <bungeman@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> | 8 个月前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 8 个月前 | ||
| 2 年前 | ||
| 7 个月前 | ||
| 7 个月前 | ||
| 8 个月前 |