BBen WagnerRemove old SkFontMgr_New_Fuchsia
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Compile include/ headers on their own In https://review.skia.org/1024156, we removed IWYU logic, but this also removed the ability for us to test compiling headers on their own (which other build systems do). This caused a missing #include to land in Skia but break upstream things [1]. By adding in the way to generate .cpp files for headers, this will allow us to catch that type of error. Unlike before, where there was a hand-curated list of headers, I did my best to include all public headers (and then those from select/core) which would have caught the previous error. If we like this, I can add other subdirectories to src to the list. I also did my best to avoid duplication of header files, so they are listed in one place and not two (e.g. 2 different BUILD.bazel rules) so it's hopefully easier to maintain. Change-Id: Ib5589c6ac06709d5a472bc7c524cc7a3b2a506b0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1029376 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> | 10 个月前 | |
Replace SK_WARN_UNUSED_RESULT with C++17 [[nodiscard]]. We no longer need a custom macro for [[nodiscard]], since it was added as a standard attribute in C++17. The official attribute does have slightly different placement rules than the compiler-specific attribute; it is required to be leftmost. Change-Id: I6ff5eb77514b5d96f0272a2c6287f378cf8a97ad Reviewed-on: https://skia-review.googlesource.com/c/skia/+/724396 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: John Stiles <johnstiles@google.com> | 2 年前 | |
Reland "Remove SkFontMgr::RefDefault() and dependent APIs" This is a reland of commit 3f55be91033222d4b1f174c04f26afc261725b69 Original change's description: > Remove SkFontMgr::RefDefault() and dependent APIs > > To land this in G3, I had to make fontconfig always-on for linux > builds of skia_public. Since skia_public will soon be going away, > this should not be too big an issue. I could not turn it only > on for G3 because some OSes cannot build fontconfig from source. > > Will need to remove the things from bazel/common_config_settings/BUILD.bazel > after G3 is fixed (they are using it in one place) > > Bug: b/305780908 > Change-Id: I6eb5c24cc24072575da077278ce28806348f0e7c > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/787084 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> Bug: b/305780908 Change-Id: Idb3c23c589be5e2e64e36ce1210a57016b9abcc6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/801656 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> | 2 年前 | |
Remove SkFontMgr_New_* FreeType defaults And generally clean up the build around this. Change-Id: I78ee2596c494da478ee638368d6835b9347fce22 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008436 Reviewed-by: Dominik Röttsches <drott@google.com> | 1 年前 | |
[Fontations-backend] Add an empty FontMgr for Fontations Enables running gm/ tests such as colrv1.cpp and palette.cpp without specific instantiation of fonts. Preparation for running bitmap font tests through fontations. Bug: skia:318667611 Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian10-Clang-x86_64-Debug-Fontations,Build-Mac-Clang-x86_64-Debug-Fontations,Test-Debian10-Clang-GCE-CPU-AVX2-x86_64-Debug-All-Fontations,Test-Mac12-Clang-MacBookPro16.2-CPU-AppleIntel-x86_64-Debug-All-Fontations Change-Id: I3b8b97e855cd04e1e35c1a78d0204d9ba12a6158 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/820216 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> | 2 年前 | |
Remove SkFontMgr_New_* FreeType defaults And generally clean up the build around this. Change-Id: I78ee2596c494da478ee638368d6835b9347fce22 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008436 Reviewed-by: Dominik Röttsches <drott@google.com> | 1 年前 | |
Android NDK font manager variation cache Change-Id: Icda287204109148295fabda5cc63765a6edf0403 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1041996 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 10 个月前 | |
Make SkFontMgr_New_Custom_Data public Surface SkFontMgr_New_Custom_Data in include/ports/SkFontMgr_data.h, similar to SkFontMgr_directory.h etc. While at it, update the API to use SkSpan instead of rawptr + count. Change-Id: Id340762d0787d726f917b14af9bbf688de5d1486 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656217 Commit-Queue: Florin Malita <fmalita@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 3 年前 | |
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> | 7 年前 | |
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> | 7 年前 | |
Remove SkFontMgr_New_* FreeType defaults And generally clean up the build around this. Change-Id: I78ee2596c494da478ee638368d6835b9347fce22 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008436 Reviewed-by: Dominik Röttsches <drott@google.com> | 1 年前 | |
Remove old SkFontMgr_New_Fuchsia Remove the old SkFontMgr_New_Fuchsia which did not take an SkFontScanner. Change-Id: I990c3fecbfa09e0a5da7d8a18b1995196308577d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1113976 Reviewed-by: Florin Malita <fmalita@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> | 7 个月前 | |
Split out coretext fontmgr factory. There can be only one SkFontMgr::Factory, so each should go in its own translation unit. In addition, the name SkFontHost_mac is now rather out of date and should now be SkFontMgr_mac_ct. Since the additional burden of additional build changes after the first is minimal, also split out SkTypeface_mac_ct and SkScalerContext_mac_ct. The original SkFontHost_mac.cpp is kept as a shell which #includes the cpp files which are replacing it. Once references to it are removed from all builds it can be removed. This is intended to be a reorganization without much code change. Most changes are simple renaming of functions which are now shared between translation units. However, there are a few behavior changes here. * Drop SkTypefaceCache global for SkTypeface_Mac 'local' global. * SkCTFontCTWidthForCSSWidth returns CGFloat instead of 'int'. * SkFontMgr_New_CoreText takes a CTFontCollectionRef. Change-Id: Iac548f9fd920c426ea5c6dcdefe8da0a9b89ec90 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294456 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294704 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294714 Reviewed-by: Ben Wagner <bungeman@google.com> | 5 年前 | |
Reland "Reland "Reland "Adding Fontations to FontConfig manager""" This reverts commit 77779dfed91152207753aacdf951328d775be297. Reason for revert: fixing the build Original change's description: > Revert "Reland "Reland "Adding Fontations to FontConfig manager""" > > This reverts commit d022fe64116fe6e7e8cd1d104c7a57ed0a693649. > > Reason for revert: breaking Build-Debian10-EMCC-wasm-Release-WasmGMTests > > Original change's description: > > Reland "Reland "Adding Fontations to FontConfig manager"" > > > > This reverts commit 13cb7b05b0a36eda9ad30ee800f3567419095967. > > > > Reason for revert: fixing the builds > > > > Original change's description: > > > Revert "Reland "Adding Fontations to FontConfig manager"" > > > > > > This reverts commit 6e0c0a255166d1cc4f1738d54dba1cc189f904b1. > > > > > > Reason for revert: breaking external_client bazel build > > > > > > Original change's description: > > > > Reland "Adding Fontations to FontConfig manager" > > > > > > > > This reverts commit cf9a558b3abbe737c92a56d1305838b573e13183. > > > > > > > > Reason for revert: Fixing the build > > > > Original change's description: > > > > > Revert "Adding Fontations to FontConfig manager" > > > > > > > > > > This reverts commit 12bc549478f641350872b9ad974cba779e4f2b34. > > > > > > > > > > Reason for revert: breaking the build > > > > > > > > > > Original change's description: > > > > > > Adding Fontations to FontConfig manager > > > > > > > > > > > > Change-Id: I1cbbf80c4525be8b3c04283528b1b3e4d63e9b34 > > > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/902437 > > > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > > > > > Change-Id: I76d515677439bd134a96bd9ed576d2cc4b8ddfb9 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/908958 > > > > > Reviewed-by: Jim Van Verth <jvanverth@google.com> > > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > > > > > Change-Id: I62aa870abb354e81685860eef4b321f24be92132 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/909497 > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > Change-Id: I520850f10caa387f401d487c6e2cb91bf5cadb50 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914337 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Auto-Submit: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Change-Id: I0fdc0d1663476de8680ad28f64cb590002f82011 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914338 > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > Change-Id: Id43e542589ccc5c4d4820a29d01acbc6aef60790 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914636 > Commit-Queue: Julia Lavrova <jlavrova@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: James Godfrey-Kittle <jamesgk@google.com> > Reviewed-by: Michael Ludwig <michaelludwig@google.com> Change-Id: I1dd5f013cc6a0c835731457a790cb88d08b7289a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914656 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com> | 1 年前 | |
Reland "Reland "Reland "Adding Fontations to FontConfig manager""" This reverts commit 77779dfed91152207753aacdf951328d775be297. Reason for revert: fixing the build Original change's description: > Revert "Reland "Reland "Adding Fontations to FontConfig manager""" > > This reverts commit d022fe64116fe6e7e8cd1d104c7a57ed0a693649. > > Reason for revert: breaking Build-Debian10-EMCC-wasm-Release-WasmGMTests > > Original change's description: > > Reland "Reland "Adding Fontations to FontConfig manager"" > > > > This reverts commit 13cb7b05b0a36eda9ad30ee800f3567419095967. > > > > Reason for revert: fixing the builds > > > > Original change's description: > > > Revert "Reland "Adding Fontations to FontConfig manager"" > > > > > > This reverts commit 6e0c0a255166d1cc4f1738d54dba1cc189f904b1. > > > > > > Reason for revert: breaking external_client bazel build > > > > > > Original change's description: > > > > Reland "Adding Fontations to FontConfig manager" > > > > > > > > This reverts commit cf9a558b3abbe737c92a56d1305838b573e13183. > > > > > > > > Reason for revert: Fixing the build > > > > Original change's description: > > > > > Revert "Adding Fontations to FontConfig manager" > > > > > > > > > > This reverts commit 12bc549478f641350872b9ad974cba779e4f2b34. > > > > > > > > > > Reason for revert: breaking the build > > > > > > > > > > Original change's description: > > > > > > Adding Fontations to FontConfig manager > > > > > > > > > > > > Change-Id: I1cbbf80c4525be8b3c04283528b1b3e4d63e9b34 > > > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/902437 > > > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > > > > > Change-Id: I76d515677439bd134a96bd9ed576d2cc4b8ddfb9 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/908958 > > > > > Reviewed-by: Jim Van Verth <jvanverth@google.com> > > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > > > > > Change-Id: I62aa870abb354e81685860eef4b321f24be92132 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/909497 > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > Change-Id: I520850f10caa387f401d487c6e2cb91bf5cadb50 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914337 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Auto-Submit: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Change-Id: I0fdc0d1663476de8680ad28f64cb590002f82011 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914338 > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > Change-Id: Id43e542589ccc5c4d4820a29d01acbc6aef60790 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914636 > Commit-Queue: Julia Lavrova <jlavrova@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: James Godfrey-Kittle <jamesgk@google.com> > Reviewed-by: Michael Ludwig <michaelludwig@google.com> Change-Id: I1dd5f013cc6a0c835731457a790cb88d08b7289a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914656 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com> | 1 年前 | |
Make SkImage and SkImageGenerator return const SkData from refEncoded This behavior was implied (a shared pointer to SkData should always be treated as read-only) and is now made explicit. This also updates several places in our decoders where we promise not to modify the SkData that is passed in (since we will likely be caching it) and ask that the client not modify it either. This is partially guarded by SK_DISABLE_LEGACY_NONCONST_ENCODED_IMAGE_DATA so we can update Chromium and potentially other places. Change-Id: Id174dff4afa148745ad32dd7d5cd848931b77f9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084056 Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Make SkImage and SkImageGenerator return const SkData from refEncoded This behavior was implied (a shared pointer to SkData should always be treated as read-only) and is now made explicit. This also updates several places in our decoders where we promise not to modify the SkData that is passed in (since we will likely be caching it) and ask that the client not modify it either. This is partially guarded by SK_DISABLE_LEGACY_NONCONST_ENCODED_IMAGE_DATA so we can update Chromium and potentially other places. Change-Id: Id174dff4afa148745ad32dd7d5cd848931b77f9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084056 Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Make SkImage and SkImageGenerator return const SkData from refEncoded This behavior was implied (a shared pointer to SkData should always be treated as read-only) and is now made explicit. This also updates several places in our decoders where we promise not to modify the SkData that is passed in (since we will likely be caching it) and ask that the client not modify it either. This is partially guarded by SK_DISABLE_LEGACY_NONCONST_ENCODED_IMAGE_DATA so we can update Chromium and potentially other places. Change-Id: Id174dff4afa148745ad32dd7d5cd848931b77f9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084056 Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Add const to SkData in SkTypeface_fontations API We only need read-only access to it and it was odd we didn't have that in the API. Change-Id: Iab87a3f5861c78506bb64f5ab29f21dd52a5088f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084057 Reviewed-by: Dominik Röttsches <drott@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> | 8 个月前 | |
Remove CGFontRef parameter from SkMakeTypefaceFromCTFont Since the Blink side CTFontRefs are no longer created from CGFontRefs after [1], we do not need to pass CGFontRefs to Skia any longer for keeping them alive. Clean up related plumbing which previously passed through the CGFontRef to the SkTypefaceMac constructor. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1964073 Bug: chromium:1033478 Change-Id: Ic85cae6289fa9b4886201c92defb54fcc5622720 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266816 Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> | 6 年前 | |
Remove SkRemotableFontMgr This was an early attempt at properly handling fonts in a sandbox. Chromium did in fact run with this. In some ways it is still better than how Chromium currently handles fonts in the sandbox. However, this is currently unused and if written today would be done much differently. Change-Id: Ief8a72260e26341745a69406934094fc39487fac Reviewed-on: https://skia-review.googlesource.com/c/skia/+/841658 Auto-Submit: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> | 2 年前 |