HHeather MillerFilter unsupported CQ try jobs on chrome/m144
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Filter unsupported CQ try jobs on chrome/m144 Change-Id: Ia74e7ebf60a4cc274b178e3408453c1b83c56314 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1114478 Reviewed-by: Eric Boren <borenet@google.com> | 7 个月前 | |
Fix compile scripts which use ninja Follow-up to https://skia-review.googlesource.com/c/skia/+/607062 Updating the docker containers brings in a new version of Clang which has a diagnostic flag we want to ignore. https://reviews.llvm.org/D134831 Change-Id: Ibb1d95597ef9fa4e951854c8cfe5d622c6752f44 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/608018 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 3 年前 | |
Fix cmake installation in cmake-release image Apparently the cmake script defaults to installing in / which used to work ok, but now the script deletes the entire /bin folder before dumping cmake into it. This lead to problems with the image missing /bin/sh and /bin/bash and I'm glad I didn't make that mistake outside of a containerized environment 😅 This also makes the docker build step more verbose which can be handy when debugging why the built image didn't behave as expected. Change-Id: I38ae117e656d267faf4678fb486020595a84e8cc No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1047956 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 10 个月前 | |
Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8696712300584820897 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ce0a39983e8bc3e11d9f1ca7226e4d131ff56575 ce0a399 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from f1d8bd5336c2 to 808a00437f24 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ib9a5ebc8db3460d7253983b1d0ad030752d9de69 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1113337 Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> | 7 个月前 | |
Add dockerfile to cross-compile for arm64 linux Use instructions to follow. GN args might look something like: cc="clang" cxx="clang++" extra_asmflags = [ "--target=aarch64-linux-gnu", "--sysroot=/usr/aarch64-linux-gnu", "-march=armv8-a", ] extra_cflags=[ "--target=aarch64-linux-gnu", "--sysroot=/usr/aarch64-linux-gnu", "-I/GLES/include/", "-DMESA_EGL_NO_X11_HEADERS", "-g0", ] extra_cflags_cc=[ "-stdlib=libc++", ] extra_ldflags=[ "-fuse-ld=lld", "--target=aarch64-linux-gnu", "-L/GLES/lib64", "-stdlib=libc++", "-lc++abi" ] target_cpu="arm64" skia_use_fontconfig = false skia_use_system_freetype2 = false skia_use_egl = true Bug: skia: Change-Id: I20632d8dc906625d5771f755b094fd0c2ed62706 Reviewed-on: https://skia-review.googlesource.com/c/193472 Reviewed-by: Joe Gregorio <jcgregorio@google.com> | 7 年前 | |
Roll debugger-app-base from 4fab2c75015c to 9c01087f9cc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/debugger-app-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I7c201851d5ccce081521cca1232888c87fd68966 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1108796 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> | 7 个月前 | |
Fix cmake installation in cmake-release image Apparently the cmake script defaults to installing in / which used to work ok, but now the script deletes the entire /bin folder before dumping cmake into it. This lead to problems with the image missing /bin/sh and /bin/bash and I'm glad I didn't make that mistake outside of a containerized environment 😅 This also makes the docker build step more verbose which can be handy when debugging why the built image didn't behave as expected. Change-Id: I38ae117e656d267faf4678fb486020595a84e8cc No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1047956 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 10 个月前 | |
Update fiddler-base for 020ae52af0e7 https://skia.googlesource.com/buildbot.git/+/020ae52af0e7988115fdb95de2522c51a244a2c0 Update fiddler-build-skia for 1bf9d5c51ec8 Change-Id: Ic05ed03db2e980dc1e60d510d72c98a30335708a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1065599 Auto-Submit: Louhi for Skia Infra <louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> | 9 个月前 | |
[infra] Remove remaining Debian10 tasks - Run builds for Ubuntu18 in Docker on Ubuntu24.04. - Move RecreateSKPs to Ubuntu24.04. Bug: b/380037738 Change-Id: I510ab1c367f7b991193432010b27c37d7652d11e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/971042 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Eric Boren <borenet@google.com> | 1 年前 | |
Roll jsfiddle-base from e739450ff483 to ef6c6a80c82e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jsfiddle-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I8896ef37ba4a96cc593afb793d49e37ae2c5e1f7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1108799 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> | 7 个月前 | |
Delete PathKit PathKit has been stale for a long while now. All functionality can be done with CanvasKit, if necessary. We won't be removing the pinned version on npm https://www.npmjs.com/package/pathkit-wasm but it's not going to receive any more updates. Change-Id: I74d7111f705ff6213df808f22bd84a6c7dcab83e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1079896 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 8 个月前 | |
Delete swarm_trigger recipe Delete no-longer-used parts of swarming module and add "pragma: no cover" where applicable. BUG=skia: Change-Id: I0f516d7be520a4d4b4efbfa97bd383a5f124e713 Reviewed-on: https://skia-review.googlesource.com/5790 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com> | 9 年前 | |
Roll shaders-base from a05e895e8ba2 to 77cefc24c76a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaders-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I81f2fcda94afa3d96a895139cf287e3dc42658de Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1108801 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> | 7 个月前 | |
Roll skottie-base from 0b6ddddfa5b5 to b106ae90b3af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skottie-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I6288afe402e1c11fc174f00c18c74d0e77854148 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1108818 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> | 7 个月前 | |
Delete PathKit PathKit has been stale for a long while now. All functionality can be done with CanvasKit, if necessary. We won't be removing the pinned version on npm https://www.npmjs.com/package/pathkit-wasm but it's not going to receive any more updates. Change-Id: I74d7111f705ff6213df808f22bd84a6c7dcab83e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1079896 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 8 个月前 | |
Update Bazel to 8.2.1 and use bzlmod The update to bzlmod [1] changes how we handle third_party deps (dramatically) and how our toolchains work (minorly). To review and understand the changes, I suggest going language by language through the changes: C++ === We have Bazel check out git repositories listed in deps.bzl (like before), but this has been converted to a module_extension [2] which behaves basically the same. In MODULE.bazel, we load the extension and then specify all the dependencies that Skia directly depends on from there. If we can depend on versions from the Bazel registry [3], for example bazel_dep(name = "libpng", version = "1.6.47.bcr.1") we could remove the git repository versions and this might make things easier for external clients if there are version mismatches. A big change was required with how we customize our compilation of expat, FreeType, Harfbuzz, and ICU. Previously, we'd copied in (or cleverly referenced) files from the Skia repo in the third party copy of the code and this sort of worked. External clients had to use some helpers to load these configs and it was Fine (tm). This does not work with bzlmod's dependency graph. I tried several things to make this work cleanly and ran into road blocks with either RBE or external client usage (or both). See earlier patchsets for that, if interested. What *did* work (at least ok) was making a patch file per third party dep that needed it using tools/generate_patches.py to combine all those files and specify an output location. This has the downside of not being in sync, but I made the existing roll scripts for expat, FreeType, Harfbuzz shell out to the script to minimize that. Toolchains needed to be slightly updated to have a different path in the external/ output directory, which now includes some prefixing. To make this as robust as possible, I made the trampoline scripts use paths relative to where the script lives and use a glob to find the path no matter what the prefix is. Clang remains at 15.0.1 for Bazel builds. Rust ==== The rust toolchain has been updated to 1.86.0 (this was the primary impetus for this change). External crate dependences use crate_universe [4] and specify the versions we need directly in MODULE.bazel instead of using a toml file. I chose that approach because it seemed more direct when one wants to figure out what version our Bazel build uses. All crates except cxx worked "out of the box", meaning the rules_rust generated BUILD.bazel files for them in a way that just worked. I had to use crate.annotation to customize cxx to use bazel/external/cxx/BUILD.bazel.skia in addition to the generated rule so we can overwrite the include path. This was a bit fiddly and required me to spend a while looking through the bazel cache to experiment with what the output was. The only other major change is how we reference rust dependencies now. For example in src/ports/fontations/BUILD.bazel see that all rust dependencies are based out of @crates instead of all being top level dependencies. Again, poking into the bazel cache is helpful for figuring out what the generated target names are. Another upside of this update is the big long "splicing workspaces" seems to have gone away. Golang ====== The golang version is now 1.24.2. These were the most fiddly changes - particularly with some changes in the ecosystem related to protos. In MODULE.bazel, the go.mod file is read in to get both the go version and the direct golang dependencies. go_rules uses gazelle [5] to generate BUILD.bazel files for any deps if they don't have them. This includes generating BUILD.bazel files for proto files, which are a bit messy due to there being some conflicting ways to include these and thus resolve the deps. This [6] is why I ended up mothballing the upgrade of the Skia Infra repo in favor of a minimal [7] change. In this case, we only had to tell the go.chromium.org/luci repo not to autogenerate .go files for .proto files because there are pre-existing ones. While building task drivers, there was a problem where some go deps were not being brought in and thus our transitive dependencies were failing to build. This is why tools.go was added (inspired by [8] to force those to be included. Python3 ======= This was a straightforward upgrade to Python 3.13. MODULE.bazel still reads requirements.txt to figure out what to download. The BUILD.bazel file we build for Dawn uses these requirements, but we didn't have to change how that worked at all. Other Notes =========== Renames ------- There are many mechanical changes (e.g. io_bazel_rules_go->rules_go) throughout as a result of bzlmod having different (non prefixed) package names in some cases. bazel/buildrc ------------- Sandboxing seems much faster in this new Bazel version on Mac. Thus I deleted the no_sandbox config. This change also updates the version of emsdk we use to compile CanvasKit. I had to squelch some warnings that they have via our config because I didn't see another way to override their toolchain settings. buildifier ---------- Updated the version used by Bazel to 8.0.3 I suggest folks also update their local version too, so presubmits work [9] Not working (yet) / disabled ============================ - karma_tests (JS tests for CanvasKit). This was based on long-deprecated rules and I didn't have the time to fix this. We still have GN based tests for CanvasKit, so this was low enough priority to skip for now - codesize_test. git_common.WithGitFinder was not working. As this is a test for our task_driver and has been stable for a while, it seemed like a low priority to fix. - bazel run //:gofmt. This moved with new go_rules and I couldn't find an easy replacement. - bazel run //:errcheck. This needs to shell out to golang and doesn't work on systems that don't have go installed because of the hermeticity. Not sure what to do about that. - clang_ios and clang_windows_amd64 toolchains. We don't have any CI jobs that use these atm, and they are lower priority for now. I made some changes based on other toolchains, but didn't test these. [1] https://bazel.build/external/migration [2] https://bazel.build/external/extension [3] https://registry.bazel.build/modules/libpng [4] https://bazelbuild.github.io/rules_rust/crate_universe_bzlmod.html [5] https://github.com/bazel-contrib/bazel-gazelle/blob/master/extensions.md#go_deps [6] https://skia-review.googlesource.com/c/buildbot/+/988440/11/MODULE.bazel [7] http://review.skia.org/990801 [8] https://github.com/google/skia-buildbot/blob/b4a7f41e01ea288eadd197f9eee0b1a8a12c5aa4/tools.go [9] https://github.com/bazelbuild/buildtools/releases/tag/v8.0.3 Change-Id: I68be15c5c4a5d2b14359fa460075591dafab336a Bug: b/413044303 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/984976 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Dominik Röttsches <drott@google.com> Reviewed-by: Eric Boren <borenet@google.com> | 1 年前 | |
Update references to master branch Change-Id: I1bfd1b655af6cdfbd64452b1e594a276425095fe Bug: skia:11987 Docs-Preview: https://skia.org/?cl=410790 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/410790 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> | 5 年前 | |
Use AUTHORS verification from SkCQ Bug: skia:12487 Change-Id: I5c906315ae3f9435bbb2eabf1c9c1bc3285a8038 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/454220 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> | 4 年前 |
This directory contains infra-specific files. The branch-config/ directory contains configs that are specific to the main branch (e.g. config for the CQ committing to the main branch), while project-config/ directory contains project-wide configuration (e.g. list of buckets for cr-buildbucket service and list of refs known to the infra services).