KKaylee LubickReapply "Move SkJSON.h to //modules/jsonreader"
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 | |
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 | |
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 | |
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 | |
Reapply "Move SkJSON.h to //modules/jsonreader" This reverts commit b5d22cf4f59a02cc806e96e1c811ccff508b36ec. http://review.skia.org/927040 http://review.skia.org/927697 was landed first in Skia, then https://crrev.com/c/6081356 landed in Chromium Original commit message: JSON parsing doesn't need to be part of Skia's core functionality, so we can move it to either //modules or //tools. Since it *is* part of Skottie's functionality, //modules seemed like the best home for it. SkJSONReader has lots of little-endian specific code that has not been ported to big-endian code. While core Skia doesn't have great support for big-endian systems, moving this out should allow core Skia to compile on big-endian systems without hitting the static_assert(false) statements Change-Id: Ie8d4e0a41ad2a638250c297dd2b9cf47e2effe24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928137 Reviewed-by: Florin Malita <fmalita@google.com> | 1 年前 |