| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Mark more single argument constructors explicit I had a more expansive search pattern and found a few more candidates this time around. Gemini CLI did most of the work here and it does not appear we were implicitly using the conversion. Change-Id: Ia51d127a099dca4f76f7e13012d9f19dd1038e50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1076816 Auto-Submit: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com> | 8 个月前 | |
SG slides to fScene->revalidate when needed Change-Id: Ifb46447f614d1469e92c02771cbca9f54aa0ea0d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1077216 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com> | 8 个月前 | |
Remove (editing) path::shrinkToFit() Change-Id: I2e3c0ded28e8138efd27fba490c40548083239c6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1072216 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 8 个月前 | |
Add tests for SkSGMerge These would have caught the issues with convexity that were in [1] and fixed in [2] Also, SkSGPath can be final, so I made it such. [1] https://skia-review.googlesource.com/c/skia/+/1063416 [2] https://skia-review.googlesource.com/c/skia/+/1065916 Change-Id: I1d2c20b65426072b3441dc87fed29b4c01f8a826 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1065398 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 9 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Reapply "DM builds with graphite enabled and ganesh disabled" Fixes no-gpu build. Fixes chrome build. This reverts commit 479696a3c5bfeb263a18c9260cb581b20ea4b556. Cq-Include-Trybots: luci.skia.skia.primary:Canary-Chromium Change-Id: Idbbb7759b229d5c28de197151dbb260f26e7c829 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1084176 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <briansalomon@gmail.com> Reviewed-by: Greg Daniel <egdaniel@google.com> | 8 个月前 | |
Fix skottie rules for G3 Need to change some internal rules Change-Id: I07624d5f0d31557dd33b52a79fb4c89b4bb00310 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/809696 Reviewed-by: Ben Wagner <bungeman@google.com> | 2 年前 |