Oopenharmony_ciCVE-2026-9983[513001309]
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Change PathRaw to store convexity enum, not just bool Motivation: computing convexity is not cheap - Whenever we "snap" off a Raw, we force the container to 'resolve' its convexity state, if currently Unknown - Some clients of raws really_don't_care about convexity ... they just want the spans (points, verbs, etc.) to inspect something. Changes: - store the full Convexity enum, including kUnknown, in Raw - ask clients that 'snap' off one, if we should force-resolve it Now clients, like stroking, never pay for computing convexity, and the ones that do also get the direction "for free", since computing convexity is the same labor as computing direction. Change-Id: I7548d3fdee0faafaf62abd25e7a7b4b40b95ad81 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1075856 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> | 8 个月前 | |
CVE-2026-9983[513001309] Signed-off-by: hwt00888022 <huwentao21@huawei.com> | 26 天前 | |
CVE-2026-9983[513001309] Signed-off-by: hwt00888022 <huwentao21@huawei.com> | 26 天前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Start to migrate pathops to builder Change-Id: Ie95aeaa9154ba924db0fa400d50c9b80f5ac30c2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1056517 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Florin Malita <fmalita@google.com> | 9 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Update (some) callers to follow more strict span rules - allows us to migrate to std::span, keeping SkSpan (for now) as an alias. - idea is to land call-site-cleanups separately, so that when we do try to actually throw the switch, that CL only contains the switch (build-flag) itself. Change-Id: I5f9aaafeb297b7adc1d953019fdac6ffda95fe03 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1097896 Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@google.com> | 7 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
More return resulting path by optional-value for internal pathops Change-Id: I752806c3eb98a91a7fac2cd1a1764a5777920a94 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1059499 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> | 9 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
pathops Simplify() to return its result Change-Id: Ic73b31cca5df78d2dad3b7f10dc0f25196a36049 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1059763 Owners-Override: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Florin Malita <fmalita@google.com> | 9 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
pathops Simplify() to return its result Change-Id: Ic73b31cca5df78d2dad3b7f10dc0f25196a36049 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1059763 Owners-Override: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Florin Malita <fmalita@google.com> | 9 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
CVE-2026-10009[513973560] Signed-off-by: hwt00888022 <huwentao21@huawei.com> | 26 天前 | |
Remove some SkPath friends to find editors Change-Id: I531bda41ccc1c157099f6649061d2f98f3af7a1a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1071738 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Florin Malita <fmalita@google.com> | 8 个月前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 | |
Revert "Reland "move pathops into a module"" This reverts commit 0132370defcf0351a20c79892710fc55dc52a11d. Reason for revert: breaking Shared builders Original change's description: > Reland "move pathops into a module" > > This reverts commit b51aff0df410f04b6a349da7cf8d296875355abf. > > Reason for revert: relanding with fixes > > Original change's description: > > Revert "move pathops into a module" > > > > This reverts commit 5c514284c390b5d3c653b39c9a66a6ea7765fd60. > > > > Reason for revert: breaks some chromium builds > > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer > > > > [296/91641] SOLINK ./libcomponents_optimization_guide_internal_standalone_skia.so > > python3 ../../build/toolchain/gcc_solink_wrapper.py --readelf=../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf --nm=../../third_p...(too long) > > ld.lld: error: obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o: DWARF unit at offset 0x00000000 has unsupported version 0, supported are 2-5 > > ld.lld: error: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*) > > >>> referenced by SkClipStackUtils.cpp > > >>> obj/components/optimization_guide/internal/standalone_skia/skia/SkClipStackUtils.o:(SkClipStack_AsPath(SkClipStack const&, SkPath*)) > > clang++: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Original change's description: > > > move pathops into a module > > > > > > Goal is to make it clear what parts of the source base are > > > fundamental to core, and which are optional. Modules captures that > > > notion pretty well. > > > > > > Note: The printing backends (PDF, XPS) are possibly candidates to move > > > into modules as well -- they are clearly optional (to the core) just > > > like SVG or Shaper. > > > > > > Change-Id: I9d5d51b380a290c419295da8277590607d007192 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/999760 > > > Reviewed-by: Kaylee Lubick <kjlubick@google.com> > > > Reviewed-by: Florin Malita <fmalita@google.com> > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Florin Malita <fmalita@google.com> > > > > Change-Id: I618732ff4d13d7c588b26f294de7a9afc8ba2fc6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008156 > > Reviewed-by: Florin Malita <fmalita@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Florin Malita <fmalita@google.com> > > Change-Id: I2d009cf3f477645eecf130e7b08231f53db6b4c9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1008277 > Reviewed-by: Daniel Dilan <danieldilan@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic1f76a5e7332f923101a6d1b6faea5fbb9ecc2a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011857 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Florin Malita <fmalita@google.com> | 1 年前 |