#include "src/flags/flags.h"
#include <algorithm>
#include <array>
#include <cctype>
#include <cerrno>
#include <cinttypes>
#include <cstdlib>
#include <cstring>
#include <iomanip>
#include <optional>
#include <set>
#include <sstream>
#include "src/base/fpu.h"
#include "src/base/hashing.h"
#include "src/base/lazy-instance.h"
#include "src/base/platform/platform.h"
#include "src/codegen/cpu-features.h"
#include "src/flags/flags-impl.h"
#include "src/logging/tracing-flags.h"
#include "src/tracing/tracing-category-observer.h"
#include "src/utils/allocation.h"
#include "src/utils/memcopy.h"
#include "src/utils/ostreams.h"
#include "src/utils/utils.h"
#if V8_ENABLE_WEBASSEMBLY
#include "src/wasm/wasm-limits.h"
#endif
namespace v8::internal {
FlagValues v8_flags PERMISSION_MUTABLE_SECTION;
static_assert(alignof(FlagValues) == kMinimumOSPageSize);
static_assert(sizeof(FlagValues) % kMinimumOSPageSize == 0);
#define FLAG_MODE_DEFINE_DEFAULTS
#include "src/flags/flag-definitions.h"
#undef FLAG_MODE_DEFINE_DEFAULTS
char FlagHelpers::NormalizeChar(char ch) { return ch == '_' ? '-' : ch; }
int FlagHelpers::FlagNamesCmp(const char* a, const char* b) {
int i = 0;
char ac, bc;
do {
ac = NormalizeChar(a[i]);
bc = NormalizeChar(b[i]);
if (ac < bc) return -1;
if (ac > bc) return 1;
i++;
} while (ac != '\0');
DCHECK_EQ(bc, '\0');
return 0;
}
bool FlagHelpers::EqualNames(const char* a, const char* b) {
return FlagNamesCmp(a, b) == 0;
}
bool FlagHelpers::EqualNameWithSuffix(const char* a, const char* b) {
char ac, bc;
for (int i = 0; true; ++i) {
ac = NormalizeChar(a[i]);
bc = NormalizeChar(b[i]);
if (ac == '\0') break;
if (ac != bc) return false;
}
return bc == '\0' || std::isspace(bc);
}
std::ostream& operator<<(std::ostream& os, FlagName flag_name) {
os << (flag_name.negated ? "--no-" : "--");
for (const char* p = flag_name.name; *p; ++p) {
os << FlagHelpers::NormalizeChar(*p);
}
return os;
}
void Flag::set_string_value(const char* new_value, bool owns_new_value,
SetBy set_by) {
DCHECK_EQ(TYPE_STRING, type_);
DCHECK_IMPLIES(owns_new_value, new_value != nullptr);
const char* old_value = string_value();
DCHECK_IMPLIES(owns_ptr_, old_value != nullptr);
bool change_flag = old_value
? !new_value || std::strcmp(old_value, new_value) != 0
: !!new_value;
change_flag = CheckFlagChange(set_by, change_flag);
if (change_flag) {
DCHECK(!IsReadOnly());
if (owns_ptr_) DeleteArray(old_value);
*reinterpret_cast<FlagValue<const char*>*>(valptr_) = new_value;
owns_ptr_ = owns_new_value;
} else {
if (owns_new_value) DeleteArray(new_value);
}
}
bool Flag::ShouldCheckFlagContradictions() {
if (v8_flags.allow_overwriting_for_next_flag) {
v8_flags.allow_overwriting_for_next_flag = false;
FindFlagByPointer(&v8_flags.allow_overwriting_for_next_flag)->Reset();
return false;
}
return v8_flags.abort_on_contradictory_flags && !v8_flags.fuzzing;
}
namespace {
struct FlagError : public std::ostringstream {
static constexpr const char kHint[] =
"If a test variant caused this, it might be necessary to specify "
"additional contradictory flags in "
"tools/testrunner/local/variants.py.";
MSVC_SUPPRESS_WARNING(4722)
~FlagError() {
base::OS::PrintError("Flag processing error: %s.\n", str().c_str());
base::OS::PrintError("%s\n", kHint);
if (v8_flags.exit_on_contradictory_flags) {
base::OS::ExitProcess(-1);
} else {
DCHECK(v8_flags.abort_on_contradictory_flags);
base::OS::Abort();
}
}
};
bool ShouldCheckDisallowUnsafeFlagContradictions(const char* implied_by) {
static constexpr char kDisallowUnsafeFlagsStr[] = "disallow_unsafe_flags";
return implied_by && v8_flags.disallow_unsafe_flags &&
!std::strcmp(implied_by, kDisallowUnsafeFlagsStr);
}
}
bool Flag::CheckFlagChange(SetBy new_set_by, bool change_flag,
const char* implied_by) {
if (new_set_by == SetBy::kWeakImplication &&
(set_by_ == SetBy::kImplication || set_by_ == SetBy::kCommandLine)) {
return false;
}
if (ShouldCheckFlagContradictions() ||
ShouldCheckDisallowUnsafeFlagContradictions(implied_by)) {
if (change_flag && IsReadOnly()) {
if (implied_by == nullptr) {
FlagError{} << "Contradictory value for readonly flag "
<< FlagName{name()};
} else {
DCHECK(IsAnyImplication(new_set_by));
FlagError{} << "Contradictory value for readonly flag "
<< FlagName{name()} << " implied by " << implied_by;
}
}
bool is_bool_flag = type_ == TYPE_MAYBE_BOOL || type_ == TYPE_BOOL;
bool check_implications = change_flag;
switch (set_by_) {
case SetBy::kDefault:
break;
case SetBy::kWeakImplication:
if (new_set_by == SetBy::kWeakImplication && check_implications) {
FlagError{} << "Contradictory weak flag implications from "
<< FlagName{implied_by_} << " and "
<< FlagName{implied_by} << " for flag "
<< FlagName{name()};
}
break;
case SetBy::kImplication:
if (new_set_by == SetBy::kImplication && check_implications) {
FlagError{} << "Contradictory flag implications from "
<< FlagName{implied_by_} << " and "
<< FlagName{implied_by} << " for flag "
<< FlagName{name()};
}
break;
case SetBy::kCommandLine:
if (new_set_by == SetBy::kImplication && check_implications) {
if (is_bool_flag) {
FlagError{} << "Flag " << FlagName{name()} << ": value implied by "
<< FlagName{implied_by}
<< " conflicts with explicit specification";
} else {
FlagError{} << "Flag " << FlagName{name()} << " is implied by "
<< FlagName{implied_by}
<< " but also specified explicitly";
}
} else if (new_set_by == SetBy::kCommandLine && check_implications) {
if (is_bool_flag) {
FlagError{} << "Command-line provided flag " << FlagName{name()}
<< " specified as both true and false";
} else {
FlagError{} << "Command-line provided flag " << FlagName{name()}
<< " specified multiple times";
}
}
break;
}
}
if (change_flag && IsReadOnly()) {
return false;
}
set_by_ = new_set_by;
if (IsAnyImplication(new_set_by)) {
DCHECK_NOT_NULL(implied_by);
implied_by_ = implied_by;
#ifdef DEBUG
if (strchr(implied_by, '<') != nullptr) {
implied_by_ptr_ = nullptr;
} else {
implied_by_ptr_ = static_cast<Flag*>(FindImplicationFlagByName(
implied_by[0] == '!' ? implied_by + 1 : implied_by));
}
DCHECK_NE(implied_by_ptr_, this);
#endif
}
return change_flag;
}
bool Flag::IsDefault() const {
switch (type_) {
case TYPE_BOOL:
return bool_variable() == bool_default();
case TYPE_MAYBE_BOOL:
return maybe_bool_variable().has_value() == false;
case TYPE_INT:
return int_variable() == int_default();
case TYPE_UINT:
return uint_variable() == uint_default();
case TYPE_UINT64:
return uint64_variable() == uint64_default();
case TYPE_FLOAT:
return float_variable() == float_default();
case TYPE_SIZE_T:
return size_t_variable() == size_t_default();
case TYPE_STRING: {
const char* str1 = string_value();
const char* str2 = string_default();
if (str2 == nullptr) return str1 == nullptr;
if (str1 == nullptr) return str2 == nullptr;
return strcmp(str1, str2) == 0;
}
}
UNREACHABLE();
}
void Flag::ReleaseDynamicAllocations() {
if (type_ != TYPE_STRING) return;
if (owns_ptr_) DeleteArray(string_value());
}
void Flag::Reset() {
switch (type_) {
case TYPE_BOOL:
set_bool_variable(bool_default(), SetBy::kDefault);
break;
case TYPE_MAYBE_BOOL:
set_maybe_bool_variable(std::nullopt, SetBy::kDefault);
break;
case TYPE_INT:
set_int_variable(int_default(), SetBy::kDefault);
break;
case TYPE_UINT:
set_uint_variable(uint_default(), SetBy::kDefault);
break;
case TYPE_UINT64:
set_uint64_variable(uint64_default(), SetBy::kDefault);
break;
case TYPE_FLOAT:
set_float_variable(float_default(), SetBy::kDefault);
break;
case TYPE_SIZE_T:
set_size_t_variable(size_t_default(), SetBy::kDefault);
break;
case TYPE_STRING:
set_string_value(string_default(), false, SetBy::kDefault);
break;
}
}
Flag flags[] = {
#define FLAG_MODE_META
#include "src/flags/flag-definitions.h"
#undef FLAG_MODE_META
};
constexpr size_t kNumFlags = arraysize(flags);
base::Vector<Flag> Flags() { return base::ArrayVector(flags); }
struct FlagLess {
bool operator()(const Flag* a, const Flag* b) const {
return FlagHelpers::FlagNamesCmp(a->name(), b->name()) < 0;
}
};
struct FlagNameGreater {
bool operator()(const Flag* a, const char* b) const {
return FlagHelpers::FlagNamesCmp(a->name(), b) > 0;
}
};
class FlagMapByName {
public:
FlagMapByName() {
for (size_t i = 0; i < kNumFlags; ++i) {
flags_[i] = &flags[i];
}
std::sort(flags_.begin(), flags_.end(), FlagLess());
}
Flag* GetFlag(const char* name) {
auto it = std::lower_bound(flags_.rbegin(), flags_.rend(), name,
FlagNameGreater());
if (it == flags_.rend()) return nullptr;
return *it;
}
private:
std::array<Flag*, kNumFlags> flags_;
};
DEFINE_LAZY_LEAKY_OBJECT_GETTER(FlagMapByName, GetFlagMap)
Flag* FindImplicationFlagByName(const char* name) {
Flag* flag = GetFlagMap()->GetFlag(name);
CHECK(flag != nullptr);
DCHECK(FlagHelpers::EqualNameWithSuffix(flag->name(), name));
return flag;
}
Flag* FindFlagByName(const char* name) {
Flag* flag = GetFlagMap()->GetFlag(name);
if (flag != nullptr && FlagHelpers::EqualNames(flag->name(), name)) {
return flag;
}
#ifdef DEBUG
for (size_t i = 0; i < kNumFlags; ++i) {
DCHECK(!FlagHelpers::EqualNames(name, flags[i].name()));
}
#endif
return nullptr;
}
Flag* FindFlagByPointer(const void* ptr) {
for (size_t i = 0; i < kNumFlags; ++i) {
if (flags[i].PointsTo(ptr)) return &flags[i];
}
return nullptr;
}
static const char* Type2String(Flag::FlagType type) {
switch (type) {
case Flag::TYPE_BOOL:
return "bool";
case Flag::TYPE_MAYBE_BOOL:
return "maybe_bool";
case Flag::TYPE_INT:
return "int";
case Flag::TYPE_UINT:
return "uint";
case Flag::TYPE_UINT64:
return "uint64";
case Flag::TYPE_FLOAT:
return "float";
case Flag::TYPE_SIZE_T:
return "size_t";
case Flag::TYPE_STRING:
return "string";
}
}
struct PrintFlagValue {
const Flag& flag;
};
std::ostream& operator<<(std::ostream& os, PrintFlagValue flag_value) {
const Flag& flag = flag_value.flag;
switch (flag.type()) {
case Flag::TYPE_BOOL:
os << (flag.bool_variable() ? "true" : "false");
break;
case Flag::TYPE_MAYBE_BOOL:
os << (flag.maybe_bool_variable().has_value()
? (flag.maybe_bool_variable().value() ? "true" : "false")
: "unset");
break;
case Flag::TYPE_INT:
os << flag.int_variable();
break;
case Flag::TYPE_UINT:
os << flag.uint_variable();
break;
case Flag::TYPE_UINT64:
os << flag.uint64_variable();
break;
case Flag::TYPE_FLOAT:
os << flag.float_variable();
break;
case Flag::TYPE_SIZE_T:
os << flag.size_t_variable();
break;
case Flag::TYPE_STRING: {
const char* str = flag.string_value();
os << std::quoted(str ? str : "");
break;
}
}
return os;
}
std::ostream& operator<<(std::ostream& os, const Flag& flag) {
if (flag.type() == Flag::TYPE_BOOL) {
os << FlagName{flag.name(), !flag.bool_variable()};
} else {
os << FlagName{flag.name()} << "=" << PrintFlagValue{flag};
}
return os;
}
static std::atomic<uint32_t> flag_hash{0};
static std::atomic<bool> flags_frozen{false};
uint32_t ComputeFlagListHash() {
std::ostringstream modified_args_as_string;
if (COMPRESS_POINTERS_BOOL) modified_args_as_string << "ptr-compr";
if (DEBUG_BOOL) modified_args_as_string << "debug";
if (base::FPU::GetFlushDenormals()) {
modified_args_as_string << "flush-denormals";
}
#ifdef DEBUG
std::set<const char*> flags_implied_by_predictable;
std::set<const char*> flags_ignored_because_of_predictable;
#endif
for (const Flag& flag : flags) {
if (flag.IsDefault()) continue;
#ifdef DEBUG
if (flag.ImpliedBy(&v8_flags.predictable) &&
!flag.PointsTo(&v8_flags.random_seed)) {
flags_implied_by_predictable.insert(flag.name());
}
#endif
if (flag.PointsTo(&v8_flags.profile_deserialization)) continue;
if (flag.PointsTo(&v8_flags.random_seed)) continue;
if (flag.PointsTo(&v8_flags.predictable)) continue;
if (flag.PointsTo(&v8_flags.max_old_space_size) ||
flag.PointsTo(&v8_flags.min_semi_space_size) ||
flag.PointsTo(&v8_flags.max_semi_space_size) ||
flag.PointsTo(&v8_flags.max_heap_size)) {
continue;
}
if (flag.PointsTo(&v8_flags.concurrent_sparkplug) ||
flag.PointsTo(&v8_flags.concurrent_recompilation) ||
flag.PointsTo(&v8_flags.lazy_feedback_allocation) ||
#ifdef V8_ENABLE_MAGLEV
flag.PointsTo(&v8_flags.maglev_deopt_data_on_background) ||
flag.PointsTo(&v8_flags.maglev_build_code_on_background) ||
#endif
flag.PointsTo(&v8_flags.parallel_scavenge) ||
flag.PointsTo(&v8_flags.concurrent_marking) ||
flag.PointsTo(&v8_flags.concurrent_minor_ms_marking) ||
flag.PointsTo(&v8_flags.concurrent_array_buffer_sweeping) ||
flag.PointsTo(&v8_flags.parallel_marking) ||
flag.PointsTo(&v8_flags.concurrent_sweeping) ||
flag.PointsTo(&v8_flags.parallel_compaction) ||
flag.PointsTo(&v8_flags.parallel_pointer_update) ||
flag.PointsTo(&v8_flags.parallel_weak_ref_clearing) ||
flag.PointsTo(&v8_flags.memory_reducer) ||
flag.PointsTo(&v8_flags.cppheap_concurrent_marking) ||
flag.PointsTo(&v8_flags.cppheap_incremental_marking) ||
flag.PointsTo(&v8_flags.single_threaded_gc) ||
flag.PointsTo(&v8_flags.fuzzing_and_concurrent_recompilation)) {
#ifdef DEBUG
if (flag.ImpliedBy(&v8_flags.predictable)) {
flags_ignored_because_of_predictable.insert(flag.name());
}
#endif
continue;
}
modified_args_as_string << flag;
}
#ifdef DEBUG
if (!v8_flags.fuzzing) {
for (const char* name : flags_implied_by_predictable) {
if (flags_ignored_because_of_predictable.find(name) ==
flags_ignored_because_of_predictable.end()) {
PrintF(
"%s should be added to the list of "
"flags_ignored_because_of_predictable\n",
name);
UNREACHABLE();
}
}
}
#endif
std::string args(modified_args_as_string.str());
uint32_t hash = static_cast<uint32_t>(base::hash_range(
args.c_str(), args.c_str() + args.length())) |
1;
DCHECK_NE(hash, 0);
return hash;
}
static void SplitArgument(const char* arg, char* buffer, int buffer_size,
const char** name, const char** value,
bool* negated) {
*name = nullptr;
*value = nullptr;
*negated = false;
if (arg[0] != '-') return;
arg++;
if (*arg == '-') {
arg++;
DCHECK_NE('\0', arg[0]);
}
if (arg[0] == 'n' && arg[1] == 'o') {
arg += 2;
if (FlagHelpers::NormalizeChar(arg[0]) == '-') {
arg++;
}
*negated = true;
}
*name = arg;
while (*arg != '\0' && *arg != '=') arg++;
if (*arg == '=') {
size_t n = arg - *name;
if (n >= static_cast<size_t>(buffer_size)) {
FlagError{} << "Flag name is too long: " << FlagName(*name);
}
MemCopy(buffer, *name, n);
buffer[n] = '\0';
*name = buffer;
*value = arg + 1;
}
}
template <typename T>
bool TryParseUnsigned(Flag* flag, const char* arg, const char* value,
char** endp, T* out_val) {
uint64_t max = static_cast<uint64_t>(std::numeric_limits<T>::max());
errno = 0;
int64_t val = static_cast<int64_t>(strtoll(value, endp, 10));
if (val < 0 || static_cast<uint64_t>(val) > max || errno != 0) {
PrintF(stderr,
"Error: Value for flag %s of type %s is out of bounds "
"[0-%" PRIu64 "]\n",
arg, Type2String(flag->type()), max);
return false;
}
*out_val = static_cast<T>(val);
return true;
}
int FlagList::SetFlagsFromCommandLine(int* argc, char** argv, bool remove_flags,
HelpOptions help_options) {
int return_code = 0;
for (int i = 1; i < *argc;) {
int j = i;
const char* arg = argv[i++];
if (arg == nullptr) continue;
if (arg[0] == '-' && arg[1] == '-' && arg[2] == '\0') break;
char buffer[1 * KB];
const char* name;
const char* value;
bool negated;
SplitArgument(arg, buffer, sizeof buffer, &name, &value, &negated);
if (name == nullptr) continue;
Flag* flag = FindFlagByName(name);
if (flag == nullptr) {
if (remove_flags) {
continue;
} else {
PrintF(stderr, "Error: unrecognized flag %s\n", arg);
return_code = j;
break;
}
}
if (flag->type() != Flag::TYPE_BOOL &&
flag->type() != Flag::TYPE_MAYBE_BOOL && value == nullptr) {
if (i < *argc) {
value = argv[i++];
}
if (!value) {
PrintF(stderr, "Error: missing value for flag %s of type %s\n", arg,
Type2String(flag->type()));
return_code = j;
break;
}
}
char* endp = const_cast<char*>("");
switch (flag->type()) {
case Flag::TYPE_BOOL:
flag->set_bool_variable(!negated, Flag::SetBy::kCommandLine);
break;
case Flag::TYPE_MAYBE_BOOL:
flag->set_maybe_bool_variable(!negated, Flag::SetBy::kCommandLine);
break;
case Flag::TYPE_INT:
flag->set_int_variable(static_cast<int>(strtol(value, &endp, 10)),
Flag::SetBy::kCommandLine);
break;
case Flag::TYPE_UINT: {
unsigned int parsed_value;
if (TryParseUnsigned(flag, arg, value, &endp, &parsed_value)) {
flag->set_uint_variable(parsed_value, Flag::SetBy::kCommandLine);
} else {
return_code = j;
}
break;
}
case Flag::TYPE_UINT64: {
uint64_t parsed_value;
if (TryParseUnsigned(flag, arg, value, &endp, &parsed_value)) {
flag->set_uint64_variable(parsed_value, Flag::SetBy::kCommandLine);
} else {
return_code = j;
}
break;
}
case Flag::TYPE_FLOAT:
flag->set_float_variable(strtod(value, &endp),
Flag::SetBy::kCommandLine);
break;
case Flag::TYPE_SIZE_T: {
size_t parsed_value;
if (TryParseUnsigned(flag, arg, value, &endp, &parsed_value)) {
flag->set_size_t_variable(parsed_value, Flag::SetBy::kCommandLine);
} else {
return_code = j;
}
break;
}
case Flag::TYPE_STRING:
flag->set_string_value(value ? StrDup(value) : nullptr, true,
Flag::SetBy::kCommandLine);
break;
}
bool is_bool_type = flag->type() == Flag::TYPE_BOOL ||
flag->type() == Flag::TYPE_MAYBE_BOOL;
if ((is_bool_type && value != nullptr) || (!is_bool_type && negated) ||
*endp != '\0') {
PrintF(stderr, "Error: illegal value for flag %s of type %s\n", arg,
Type2String(flag->type()));
if (is_bool_type) {
PrintF(stderr,
"To set or unset a boolean flag, use --flag or --no-flag.\n");
}
return_code = j;
break;
}
if (remove_flags) {
while (j < i) {
argv[j++] = nullptr;
}
}
}
if (v8_flags.help) {
if (help_options.HasUsage()) {
PrintF(stdout, "%s", help_options.usage());
}
PrintHelp();
if (help_options.ShouldExit()) {
exit(0);
}
}
if (v8_flags.print_feature_flags_json) {
PrintFeatureFlagsJSON();
if (help_options.ShouldExit()) {
exit(0);
}
}
if (remove_flags) {
int j = 1;
for (int i = 1; i < *argc; i++) {
if (argv[i] != nullptr) argv[j++] = argv[i];
}
*argc = j;
} else if (return_code != 0) {
if (return_code + 1 < *argc) {
PrintF(stderr, "The remaining arguments were ignored:");
for (int i = return_code + 1; i < *argc; ++i) {
PrintF(stderr, " %s", argv[i]);
}
PrintF(stderr, "\n");
}
}
if (return_code != 0) PrintF(stderr, "Try --help for options\n");
return return_code;
}
static char* SkipWhiteSpace(char* p) {
while (*p != '\0' && isspace(*p) != 0) p++;
return p;
}
static char* SkipBlackSpace(char* p) {
while (*p != '\0' && isspace(*p) == 0) p++;
return p;
}
int FlagList::SetFlagsFromString(const char* str, size_t len) {
std::unique_ptr<char[]> copy0{NewArray<char>(len + 1)};
MemCopy(copy0.get(), str, len);
copy0[len] = '\0';
char* copy = SkipWhiteSpace(copy0.get());
int argc = 1;
for (char* p = copy; *p != '\0'; argc++) {
p = SkipBlackSpace(p);
p = SkipWhiteSpace(p);
}
base::ScopedVector<char*> argv(argc);
argc = 1;
for (char* p = copy; *p != '\0'; argc++) {
argv[argc] = p;
p = SkipBlackSpace(p);
if (*p != '\0') *p++ = '\0';
p = SkipWhiteSpace(p);
}
return SetFlagsFromCommandLine(&argc, argv.begin(), false);
}
void FlagList::FreezeFlags() {
flags_frozen.store(true, std::memory_order_relaxed);
base::OS::SetDataReadOnly(&v8_flags, sizeof(v8_flags));
}
bool FlagList::IsFrozen() {
return flags_frozen.load(std::memory_order_relaxed);
}
void FlagList::ReleaseDynamicAllocations() {
flag_hash = 0;
for (size_t i = 0; i < kNumFlags; ++i) {
flags[i].ReleaseDynamicAllocations();
}
}
void FlagList::PrintHelp() {
CpuFeatures::Probe(false);
CpuFeatures::PrintTarget();
CpuFeatures::PrintFeatures();
StdoutStream os;
os << "The following syntax for options is accepted (both '-' and '--' are "
"ok):\n"
" --flag (bool flags only)\n"
" --no-flag (bool flags only)\n"
" --flag=value (non-bool flags only, no spaces around '=')\n"
" --flag value (non-bool flags only)\n"
" -- (captures all remaining args in JavaScript)\n\n";
os << "Options:\n";
for (const Flag& f : flags) {
os << " " << FlagName{f.name()} << " (" << f.comment() << ")\n"
<< " type: " << Type2String(f.type()) << " default: " << f
<< "\n";
}
}
void FlagList::PrintValues() {
StdoutStream os;
for (const Flag& f : flags) {
os << f << "\n";
}
}
namespace {
void PrintFlagsJSONArray(std::ostream& os,
const std::vector<const char*>& flags) {
if (flags.empty()) {
os << "[]";
} else {
os << "[\n";
bool first = true;
for (const auto& flag : flags) {
if (!first) os << ",\n";
os << " \"" << flag << "\"";
first = false;
}
os << "\n" << " ]";
}
}
void PrintFeatureFlagsJSONObject(
std::ostream& os, const std::vector<const char*>& inprogress_flags,
const std::vector<const char*>& staged_flags,
const std::vector<const char*>& shipping_flags) {
os << "{\n";
os << " \"in-progress\": ";
PrintFlagsJSONArray(os, inprogress_flags);
os << ",\n";
os << " \"staged\": ";
PrintFlagsJSONArray(os, staged_flags);
os << ",\n";
os << " \"shipping\": ";
PrintFlagsJSONArray(os, shipping_flags);
os << "\n";
os << " }";
}
}
void FlagList::PrintFeatureFlagsJSON() {
StdoutStream os;
os << "{\n";
{
std::vector<const char*> inprogress_flags;
std::vector<const char*> staged_flags;
std::vector<const char*> shipping_flags;
#define ADD_JS_INPROGRESS_FLAG(name, desc) inprogress_flags.push_back(#name);
#define ADD_JS_STAGED_FLAG(name, desc) staged_flags.push_back(#name);
#define ADD_JS_SHIPPING_FLAG(name, desc) shipping_flags.push_back(#name);
JAVASCRIPT_INPROGRESS_FEATURES(ADD_JS_INPROGRESS_FLAG)
JAVASCRIPT_STAGED_FEATURES(ADD_JS_STAGED_FLAG)
JAVASCRIPT_SHIPPING_FEATURES(ADD_JS_SHIPPING_FLAG)
os << " \"js\": ";
PrintFeatureFlagsJSONObject(os, inprogress_flags, staged_flags,
shipping_flags);
os << ",\n";
}
{
std::vector<const char*> inprogress_flags;
std::vector<const char*> staged_flags;
std::vector<const char*> shipping_flags;
HARMONY_INPROGRESS(ADD_JS_INPROGRESS_FLAG)
HARMONY_STAGED(ADD_JS_STAGED_FLAG)
HARMONY_SHIPPING(ADD_JS_SHIPPING_FLAG)
os << " \"harmony\": ";
PrintFeatureFlagsJSONObject(os, inprogress_flags, staged_flags,
shipping_flags);
os << ",\n";
}
#if V8_ENABLE_WEBASSEMBLY
{
std::vector<const char*> inprogress_flags;
std::vector<const char*> staged_flags;
std::vector<const char*> shipping_flags;
#define ADD_WASM_INPROGRESS_FLAG(name, desc, val) \
inprogress_flags.push_back("experimental_wasm_" #name);
#define ADD_WASM_STAGED_FLAG(name, desc, val) \
staged_flags.push_back("experimental_wasm_" #name);
#define ADD_WASM_SHIPPED_FLAG(name, desc, val) \
shipping_flags.push_back("experimental_wasm_" #name);
FOREACH_WASM_EXPERIMENTAL_FEATURE_FLAG(ADD_WASM_INPROGRESS_FLAG)
FOREACH_WASM_STAGING_FEATURE_FLAG(ADD_WASM_STAGED_FLAG)
FOREACH_WASM_SHIPPED_FEATURE_FLAG(ADD_WASM_SHIPPED_FLAG)
os << " \"wasm\": ";
PrintFeatureFlagsJSONObject(os, inprogress_flags, staged_flags,
shipping_flags);
os << "\n";
}
#endif
os << "}\n";
#undef ADD_JS_INPROGRESS_FLAG
#undef ADD_JS_STAGED_FLAG
#undef ADD_JS_SHIPPING_FLAG
#undef ADD_WASM_INPROGRESS_FLAG
#undef ADD_WASM_STAGED_FLAG
#undef ADD_WASM_SHIPPED_FLAG
}
namespace {
class ImplicationProcessor {
public:
bool EnforceImplications() {
bool changed = false;
#define FLAG_MODE_APPLY_NAME(name) \
auto& name = v8_flags.name; \
USE(name);
#include "src/flags/flag-definitions.h"
#undef FLAG_MODE_APPLY_NAME
#define FLAG_MODE_DEFINE_IMPLICATIONS
#include "src/flags/flag-definitions.h"
#undef FLAG_MODE_DEFINE_IMPLICATIONS
CheckForCycle();
return changed;
}
private:
template <class T>
bool TriggerImplication(bool premise, const char* premise_name,
FlagValue<T>* conclusion_value,
const char* conclusion_name, T value,
bool weak_implication) {
if (!premise) return false;
Flag* conclusion_flag = FindImplicationFlagByName(conclusion_name);
if (!conclusion_flag->CheckFlagChange(
weak_implication ? Flag::SetBy::kWeakImplication
: Flag::SetBy::kImplication,
conclusion_value->value() != value, premise_name)) {
return false;
}
if (V8_UNLIKELY(num_iterations_ >= kMaxNumIterations)) {
cycle_ << "\n" << FlagName{premise_name} << " -> ";
if constexpr (std::is_same_v<T, bool>) {
cycle_ << FlagName{conclusion_flag->name(), !value};
} else {
cycle_ << FlagName{conclusion_flag->name()} << " = " << value;
}
}
*conclusion_value = value;
return true;
}
template <class T>
bool TriggerImplication(bool premise, const char* premise_name,
const FlagValue<T>* conclusion_value,
const char* conclusion_name, T value,
bool weak_implication) {
if (!premise) return false;
Flag* conclusion_flag = FindImplicationFlagByName(conclusion_name);
DCHECK(conclusion_flag->IsReadOnly());
if (!conclusion_flag->CheckFlagChange(
weak_implication ? Flag::SetBy::kWeakImplication
: Flag::SetBy::kImplication,
conclusion_value->value() != value, premise_name)) {
return false;
}
DCHECK_EQ(value, conclusion_flag->GetDefaultValue<T>());
return true;
}
void TriggerNotExplicitlySetImplication(bool premise,
const char* premise_name,
const char* conclusion_name) {
if (!premise) {
return;
}
Flag* conclusion_flag = FindImplicationFlagByName(conclusion_name);
if (conclusion_flag->set_by_ != Flag::SetBy::kCommandLine) {
return;
}
FlagError{} << "Command-line provided flag " << FlagName{conclusion_name}
<< " is prohibited by " << FlagName{premise_name};
}
void CheckForCycle() {
if (++num_iterations_ < kMaxNumIterations) return;
if (num_iterations_ == kMaxNumIterations) {
DCHECK(cycle_.str().empty());
cycle_start_hash_ = ComputeFlagListHash();
return;
}
DCHECK_NE(0, cycle_start_hash_);
if (ComputeFlagListHash() == cycle_start_hash_) {
DCHECK(!cycle_.str().empty());
FATAL("Cycle in flag implications:%s", cycle_.str().c_str());
}
DCHECK_GE(2 * kMaxNumIterations, num_iterations_);
}
static constexpr size_t kMaxNumIterations = kNumFlags;
size_t num_iterations_ = 0;
uint32_t cycle_start_hash_;
std::ostringstream cycle_;
};
}
#define CONTRADICTION(flag1, flag2) \
(v8_flags.flag1 || v8_flags.flag2) \
? std::make_tuple(FindFlagByPointer(&v8_flags.flag1), \
FindFlagByPointer(&v8_flags.flag2)) \
: std::make_tuple(nullptr, nullptr)
#define RESET_WHEN_FUZZING(flag) CONTRADICTION(flag, fuzzing)
#define RESET_WHEN_CORRECTNESS_FUZZING(flag) \
CONTRADICTION(flag, correctness_fuzzer_suppressions)
void FlagList::ResolveContradictionsWhenFuzzing() {
if (!i::v8_flags.fuzzing) return;
std::tuple<Flag*, Flag*> contradictions[] = {
CONTRADICTION(always_osr_from_maglev, disable_optimizing_compilers),
CONTRADICTION(always_osr_from_maglev, jitless),
CONTRADICTION(always_osr_from_maglev, lite_mode),
CONTRADICTION(always_osr_from_maglev, turbofan),
CONTRADICTION(always_osr_from_maglev, turboshaft),
CONTRADICTION(assert_types, stress_concurrent_inlining),
CONTRADICTION(assert_types, stress_concurrent_inlining_attach_code),
CONTRADICTION(disable_optimizing_compilers, maglev_future),
CONTRADICTION(disable_optimizing_compilers, stress_concurrent_inlining),
CONTRADICTION(disable_optimizing_compilers,
stress_concurrent_inlining_attach_code),
CONTRADICTION(disable_optimizing_compilers, stress_maglev),
CONTRADICTION(disable_optimizing_compilers,
turboshaft_wasm_in_js_inlining),
CONTRADICTION(jit_fuzzing, max_lazy),
CONTRADICTION(jitless, maglev_as_top_tier),
CONTRADICTION(jitless, maglev_future),
CONTRADICTION(jitless, turbolev_future),
CONTRADICTION(jitless, stress_concurrent_inlining),
CONTRADICTION(jitless, stress_concurrent_inlining_attach_code),
CONTRADICTION(jitless, stress_maglev),
CONTRADICTION(lite_mode, maglev_future),
CONTRADICTION(lite_mode, predictable_gc_schedule),
CONTRADICTION(lite_mode, stress_concurrent_inlining),
CONTRADICTION(lite_mode, stress_concurrent_inlining_attach_code),
CONTRADICTION(lite_mode, stress_maglev),
CONTRADICTION(maglev_as_top_tier, stress_concurrent_inlining),
CONTRADICTION(maglev_as_top_tier, stress_concurrent_inlining_attach_code),
CONTRADICTION(maglev_as_top_tier, turbolev_future),
CONTRADICTION(optimize_for_size, predictable_gc_schedule),
CONTRADICTION(predictable, stress_concurrent_inlining_attach_code),
CONTRADICTION(predictable_gc_schedule, stress_compaction),
CONTRADICTION(single_threaded, stress_concurrent_inlining_attach_code),
CONTRADICTION(stress_concurrent_inlining, turboshaft_assert_types),
CONTRADICTION(stress_concurrent_inlining_attach_code,
turboshaft_assert_types),
CONTRADICTION(turboshaft, stress_concurrent_inlining),
CONTRADICTION(turboshaft, stress_concurrent_inlining_attach_code),
CONTRADICTION(minor_ms, handle_weak_ref_weakly_in_minor_gc),
RESET_WHEN_CORRECTNESS_FUZZING(default_to_experimental_regexp_engine),
RESET_WHEN_CORRECTNESS_FUZZING(enable_experimental_regexp_engine),
RESET_WHEN_CORRECTNESS_FUZZING(
experimental_regexp_engine_capture_group_opt),
RESET_WHEN_CORRECTNESS_FUZZING(stress_lazy_compilation),
RESET_WHEN_CORRECTNESS_FUZZING(turbo_stats),
RESET_WHEN_CORRECTNESS_FUZZING(turbo_stats_nvp),
RESET_WHEN_CORRECTNESS_FUZZING(turbo_stats_wasm),
RESET_WHEN_FUZZING(expose_async_hooks),
RESET_WHEN_FUZZING(parallel_compile_tasks_for_lazy),
RESET_WHEN_FUZZING(stress_snapshot),
RESET_WHEN_FUZZING(turboshaft),
RESET_WHEN_FUZZING(mock_arraybuffer_allocator),
#if V8_ENABLE_WEBASSEMBLY
RESET_WHEN_CORRECTNESS_FUZZING(wasm_lazy_validation),
#endif
};
for (auto [flag1, flag2] : contradictions) {
if (!flag1 || !flag2) continue;
if (flag1->IsDefault() || flag2->IsDefault()) continue;
CHECK(!flag1->PointsTo(&v8_flags.fuzzing));
CHECK(!flag1->PointsTo(&v8_flags.correctness_fuzzer_suppressions));
std::cerr << "Warning: resetting flag --" << flag1->name()
<< " due to conflicting flags" << std::endl;
flag1->Reset();
}
if ((v8_flags.trace_turbo || v8_flags.trace_turbo_graph) &&
v8_flags.fuzzing_and_concurrent_recompilation) {
std::cerr
<< "Use --nofuzzing-and-concurrent-recompilation to force "
"enable --trace-turbo, and friends. This is not thread-safe.\n";
}
}
#undef CONTRADICTION
void FlagList::EnforceFlagImplications() {
for (ImplicationProcessor proc; proc.EnforceImplications();) {
}
}
uint32_t FlagList::Hash() {
if (uint32_t hash = flag_hash.load(std::memory_order_relaxed)) return hash;
uint32_t hash = ComputeFlagListHash();
flag_hash.store(hash, std::memory_order_relaxed);
return hash;
}
void FlagList::ResetFlagHash() {
CHECK(!IsFrozen());
flag_hash = 0;
}
}