| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[Intl] Clean up by removing the following flags harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736} | 6 年前 | |
[Intl] Remove --harmony-intl-list-format flag from test This is part 1 of 2 of clean up. C++ change in Part 2 next. Bug: v8:8705 Change-Id: Ibf4425c141391581b963f4775286b65b652452e2 Reviewed-on: https://chromium-review.googlesource.com/c/1461172 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59581} | 7 年前 | |
Add "collation" option to Intl.Collator Per change in https://github.com/tc39/ecma402/pull/459/ Bug: v8:10732 Change-Id: I2ef21e8b450cbf9c61f987c61f3ba7d6959db81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309149 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68976} | 5 年前 | |
[icu] Fix LookupAndValidateUnicodeExtensions() for ICU 77 ICU 77 getKeywordValue() changed to return U_STRING_NOT_TERMINATED_WARNING when the value is exactly the same size as the given buffer size. In this case, the buffer is not null-terminated[1]. This patch fixes LookupAndValidateUnicodeExtensions() for this change. [1] https://unicode-org.github.io/icu/userguide/strings/#using-c-strings-nul-terminated-vs-length-parameters Bug: 458186954 Change-Id: Iaff890f93cc392d4deb71ab881ab4bcce97f5b34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7137918 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#103662} | 8 个月前 | |
[intl] Clean up Remove two flags for feature shipped in m95 --harmony_intl_displaynames_v2 --harmony_intl_more_timezone Bug: v8:11637, v8:11661 Change-Id: I9432865722664f64c64b5bf7fde5e05e6b324b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292518 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78005} | 4 年前 | |
[intl] Implement change of Intl.DuratonFormat PR198 https://github.com/tc39/proposal-intl-duration-format/pull/198 Bug: 42201655 Change-Id: I12ddd696406efaf9f1b8e849a3ab16251cf741ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5807717 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#96640} | 1 年前 | |
[intl] Removed shipped flag Clean up two flags which control features shipped in m99 harmony_intl_locale_info harmony_intl_enumeration Bug: v8:10743, v8:11638 Change-Id: I856afaceb0972052d1bcc70b162e8f9ee9071dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3508169 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79397} | 4 年前 | |
Fix spelling errors and other pedantry. Change-Id: I1ed7003c7e6f905101c8ab0e7f9a3167d2db3bf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797602 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Erik Corry <erikcorry@chromium.org> Cr-Commit-Position: refs/heads/main@{#95727} | 1 年前 | |
Implement GetOptionsObject/CoerceOptionsToObject Add GetOptionsObject/CoerceOptionsToObject for ECMA402 2021 Change Intl.ListFormat / Intl.DisplayNames and Intl.Segmenter to use GetOptionsObject and keep old API under CoerceOptionsToObject based on https://github.com/tc39/ecma402/pull/538/files Test262 tests need to be changed per https://github.com/tc39/test262/issues/2950 Bug: v8:11466 Change-Id: I5cb9b7aba0556effc76b4005e95c90db1e59d41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2705696 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73082} | 5 年前 | |
[intl] Implement IntoLocaleInfo PR99 Bug: 401039069 Change-Id: I7cddeb39ec22920089160a518dc3b58e99dae729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6329853 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#99131} | 1 年前 | |
Reland "[intl] Improve test coverage of "best fit" localeMatcher" This is a reland of dd8845cd74dc5b322753781f3be94859050a8583 Original change's description: > [intl] Improve test coverage of "best fit" localeMatcher > > https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd > Bug: v8:7051 > Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75228} Bug: v8:7051 Change-Id: I9af13b8fdf7ec3de2ac24050074d13fcdef981c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973648 Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75280} | 4 年前 | |
[temporal] Remove --harmony-temporal from non-Temporal tests In https://chromium-review.googlesource.com/c/v8/v8/+/7111926 I added --harmony-temporal to some tests to ensure they still pass with Temporal enabled. However, they are not Temporal tests; they should not be enabling this flag long term. Now that Temporal is unflagged (https://chromium-review.googlesource.com/c/v8/v8/+/7123876), this can be removed. Bug: 401065166 Change-Id: I00a7f7d585670bd0ddc10501931add682e803cfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124594 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#103562} | 8 个月前 | |
Revert "Make intl/overrides/caching.js more 'robust'" This reverts commit 4091f2b3a87f14476b16f1448ee83d4db511e752. Reason for revert: Flaky on the bots: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/21321 https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/20879 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/101 Original change's description: > Make intl/overrides/caching.js more 'robust' > > Bug: None > Test: intl/overrides/caching > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng > Change-Id: Iffd0f58f76d6514924badca18a2112df572e53d2 > Reviewed-on: https://chromium-review.googlesource.com/757945 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49334} TBR=adamk@chromium.org,jshin@chromium.org Change-Id: Id2fe00089c2bcbc8ecc7958fe13c8a80da733e60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/766288 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49336} | 8 年前 | |
[intl] Implement ECMA402 PR918 Explicitly designate sort order for plural categories returned by Intl.PluralRules.prototype.resolvedOptions Spec https://github.com/tc39/ecma402/pull/918 Bug: 372722562 Change-Id: I3aea0395446cfc0d4950d7591fd4b1b2bd725e5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5923607 Reviewed-by: Ilya Rezvov <irezvov@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#96991} | 1 年前 | |
[intl] Migrate to ICU 72 DEPS change in chromium is in https://chromium-review.googlesource.com/c/chromium/src/+/3995549 and should be landed first. This CL fix all the broken test in v8. ICU72 release note https://icu.unicode.org/download/72 CLDR42 release note https://cldr.unicode.org/index/downloads/cldr-42 Key changes 1. Fix the test expectation for the formatted date string a. use U+202f (narrow nbsp) before "PM" and "AM". b. use U+200A (thin space) around U+2013 in date duration format. 2. Mark the test262 breakage. Bug: chromium:1371208 Change-Id: I4e2ecc6330845a2bf86711bc4ee6fe6407f140c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4004606 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#84374} | 3 年前 | |
Implement GetOptionsObject/CoerceOptionsToObject Add GetOptionsObject/CoerceOptionsToObject for ECMA402 2021 Change Intl.ListFormat / Intl.DisplayNames and Intl.Segmenter to use GetOptionsObject and keep old API under CoerceOptionsToObject based on https://github.com/tc39/ecma402/pull/538/files Test262 tests need to be changed per https://github.com/tc39/test262/issues/2950 Bug: v8:11466 Change-Id: I5cb9b7aba0556effc76b4005e95c90db1e59d41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2705696 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73082} | 5 年前 | |
Ensure String.prototype.normalize.length is 0 TEST=test/intl/string/normalization BUG=v8:4303 LOG=N Review URL: https://codereview.chromium.org/1274653002 Cr-Commit-Position: refs/heads/master@{#30030} | 10 年前 | |
[build] Add data deps for d8 test suites Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifb8719a989a4fda48241967271ebe39037643e39 Reviewed-on: https://chromium-review.googlesource.com/980032 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52223} | 8 年前 | |
buganizer: fix component IDs in DIR_METADATA This only matches the old monorail components. Bug: 341800538 Change-Id: Id74fbdb3b9be0c858b77af84966c6c37adf78c5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6025833 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Paul Semel <paulsemel@chromium.org> Commit-Queue: Paul Semel <paulsemel@chromium.org> Cr-Commit-Position: refs/heads/main@{#97252} | 1 年前 | |
Add DIR_METADATA files to v8. Generate DIR_METADATA files and remove metadata from OWNERS files for v8. R=jkummerow@chromium.org, ochang@chromium.org, yangguo@chromium.org Bug: chromium:1113033 Change-Id: I82cbb62e438d82dbbc408e87120af39fa9da0afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476680 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#70669} | 5 年前 | |
[Intl] Impl LocaleInfo PR 63 https://github.com/tc39/proposal-intl-locale-info/pull/63 Sort collation code alphabetically before return. Bug: v8:13542 Change-Id: I1c7df69af483a96a1fc7625b11c2b850edc59283 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4094503 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#84857} | 3 年前 | |
[intl] Remove redundant type checking system Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. This reland includes a fixed type check for Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl method which is not bound. All future methods will follow this pattern. The second reland ensures that a newly inserted test is only run if Intl is present. BUG=v8:5751,chromium:677055, v8:4962 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2623683002 Cr-Commit-Position: refs/heads/master@{#42152} | 9 年前 | |
Add a flag to control the ICU datetime format workaround The purpose of this flag is to support 3 behaviors: - Unconditionally replacing ASCII space with NNBSP (current behavior) - Only doing it for English locales (likely web compatible) - Never doing the replacement (likely to break some web sites) An experiment will be run in Chrome to limit the workaround to English only. If that is successful we may also consider the final step and removing the workaround, again in a controlled experiment. Bug: 432742367 Change-Id: I349cced7de1fe5d6ff16841d719325c76c374e19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6771125 Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#101548} | 11 个月前 | |
Add a flag to control the ICU datetime format workaround The purpose of this flag is to support 3 behaviors: - Unconditionally replacing ASCII space with NNBSP (current behavior) - Only doing it for English locales (likely web compatible) - Never doing the replacement (likely to break some web sites) An experiment will be run in Chrome to limit the workaround to English only. If that is successful we may also consider the final step and removing the workaround, again in a controlled experiment. Bug: 432742367 Change-Id: I349cced7de1fe5d6ff16841d719325c76c374e19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6771125 Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#101548} | 11 个月前 | |
Add a flag to control the ICU datetime format workaround The purpose of this flag is to support 3 behaviors: - Unconditionally replacing ASCII space with NNBSP (current behavior) - Only doing it for English locales (likely web compatible) - Never doing the replacement (likely to break some web sites) An experiment will be run in Chrome to limit the workaround to English only. If that is successful we may also consider the final step and removing the workaround, again in a controlled experiment. Bug: 432742367 Change-Id: I349cced7de1fe5d6ff16841d719325c76c374e19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6771125 Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#101548} | 11 个月前 | |
[Intl] Remove GetDefaultLocale Simplified test for default locale under test/intl Remove GetDefaultLocale from runtime Move Intl::DefaultLocale from intl-object.h to internal function inside intl-object.cc Bug: v8:5751 Change-Id: I885abf30ff33d5213ee99c07ac1e92d3c5065d8b Reviewed-on: https://chromium-review.googlesource.com/c/1358022 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58081} | 7 年前 | |
[temporal] Remove outdated Temporal tests These were written back when Temporal had a Calendar and TimeZone type. Most are no longer valid. We run test262 for Temporal, it should be sufficient. Bug: 42201538 Change-Id: I8a665dade6368159a861b82df16dc6516a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7100673 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#103506} | 8 个月前 | |
[intl] Remove new.target check in Intl functions and method The Intl implementation included manual checks to see if they were being called as a constructor. However, these checks are redundant, as %FunctionRemovePrototype has already marked the functions as un-constructable. This path removes the unnecessary checks. R=yangguo Review-Url: https://codereview.chromium.org/2587713002 Cr-Commit-Position: refs/heads/master@{#41867} | 9 年前 | |
[Intl] Fix m(ax|in)imumFractionDigits for currency Fix m(ax|in)imumFractionDigits of Intl.NumberFormat resolvedOptions are set to 0. For example, currency instance for CPY or KRW. Bug: chromium:1003748 Change-Id: Ia1963d8d070b066bd5afa61f8c4716a21450af05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807742 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63850} | 6 年前 | |
[Intl] Fix ASAN crash listformat w/ > 9 items Fix the ASAN crahs when there are 9 or more items to be formatted by ListFormat. chromium DEPS rolled in https://chromium-review.googlesource.com/c/chromium/src/+/2536432 This CL is mainly to add unit test to ensure it fix. Cq-Include-Trybots: luci.v8.try:v8_linux64_asan_rel_ng,v8_mac64_asan_rel_ng,v8_win64_asan_rel_ng;luci.chromium.try:android-asan,win-asan,win-libfuzzer-asan-relBug: chromium:1146068 Change-Id: I4dfbd6ea0efe5b398196f95abc520bb93e16a7cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528476 Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71192} | 5 年前 | |
[regexp] Fix and unify non-unicode case-folding algorithms Non-unicode, case-insensitive regexps (e.g. /foo/i, not foo/iu) use a case-folding algorithm that doesn't quite match the Unicode definition. There are two places in irregexp that need to do case-folding. Prior to this patch, neither of them quite matched the spec (https://tc39.es/ecma262/#sec-runtime-semantics-canonicalize-ch). This patch implements the "Canonicalize" algorithm in src/regexp/special-case.h, and uses it in the relevant places. It replaces special-case logic around upper-casing / ASCII characters with the following approach: 1. For most characters, calling UnicodeSet::closeOver on a set containing that character will produce the correct set of case-insensitive matches. 2. For a small handful of characters (like the sharp S that prompted this change), UnicodeSet::closeOver will include some characters that should be omitted. For example, although closeOver('ß') = "ßẞ", uppercase('ß') is "SS", so step 3.e means that 'ß' canonicalizes to itself, and should not match 'ẞ'. In these cases, we can skip the closeOver entirely, because it will never add an equivalent character. These characters are in the IgnoreSet. 3. For an even smaller handful of characters, UnicodeSet::closeOver will produce some characters that should be omitted, but also some characters that should be included. For example, closeOver('k') = "kKK" (lowercase k, uppercase K, U+212A KELVIN SIGN), but KELVIN SIGN should not match either of the other two (step 3.g). To handle this, we put such characters in the SpecialAddSet. In these cases, we closeOver the original character, but filter out the results that do not have the same canonical value. The computation of IgnoreSet and SpecialAddSet happens at build time, using the pre-existing gen-regexp-special-case.cc step. R=jgruber@chromium.org Bug: v8:10248 Change-Id: I00d48b180c83bb8e645cc59eda57b01eab134f0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072858 Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66641} | 6 年前 | |
Fix format of -NAN in toLocaleString() Bug: chromium:1030160 Change-Id: I4e1b762b10c77ec671712355c61cdbb0b5f033da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068725 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66411} | 6 年前 | |
Reland "[Intl] Fix RelativeTimeFormat fatal" Fix the gc_stress problem in Original by moving the NewStringFromAsciiChecked before the cast. This is a reland of a872c393c6ceed5ba3991dec570eab6c30c18d5e Original change's description: > [Intl] Fix RelativeTimeFormat fatal > > Intl.RelativeTimeFormat constructor crash while the locale or > numberingSystem contains an "algorithmic" numberingSystem. > Fix by fallback to the locale without the nu > > Bug: chromium:1041319 > Change-Id: Ica520e8dec6ace21264504274b92cb2c3d16286f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055970 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66276} Bug: chromium:1041319 Change-Id: I97563c5dbac1842a4e740e2450070471ea2681a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057761 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66315} | 6 年前 | |
[intl] Add failing test for v8:10437 Pick handful of failure cases from https://bugs.chromium.org/p/v8/issues/detail?id=10437 Mark the test fail The bug should be fixed by ICU67.1 and will be landed soon. Bug: v8:10437 Change-Id: Iac309dd48b2220da777c006c7a35fac24e454430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161510 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67345} | 6 年前 | |
[intl] Sync to ECMA402 PR709 to not read option twice https://github.com/tc39/ecma402/pull/709 Change DateTimeFormat logic to read option only once. Track which fields is not undefined from the GetOptions. Change test/intl to reflect the change and remove dup test. PR709 reached TC39 consensus in July 2023 meeting. Bug: v8:13908 Change-Id: I5a5429f6375a01b04e77093d32acb76ae1e40d11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4706795 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#89241} | 2 年前 | |
Reland "Add regression tests for 4 calendar bugs" This is a reland of 915f729afb9f5b812e2343498fe2215f64fd5061 Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71244} | 5 年前 | |
Reland "Add regression tests for 4 calendar bugs" This is a reland of 915f729afb9f5b812e2343498fe2215f64fd5061 Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71244} | 5 年前 | |
Reland "Add regression tests for 4 calendar bugs" This is a reland of 915f729afb9f5b812e2343498fe2215f64fd5061 Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71244} | 5 年前 | |
[Intl] Update ICU to 70-1 on v8 Diary https://docs.google.com/document/d/1NqMw7DAVFCZRx67auC7sgOvrikHvCYuaB87JUf21yG8/edit# https://chromium.googlesource.com/chromium/deps/icu.git/+log/eedbaf76..3e05d9da chromium roll in https://chromium-review.googlesource.com/c/chromium/src/+/3224333 Bug: chromium:1260116 Change-Id: Ie1922a129310106985f3bf1bffd9101fce6bb73a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237532 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77868} | 4 年前 | |
[regexp] Document incorrect assertion in intl/regress-10573.js There are at least three equivalence classes where this assertion should not actually hold: '\u0390\u1fd3', // ΐΐ '\u03b0\u1fe3', // ΰΰ '\ufb05\ufb06', // ſtst Bug: v8:10591 Change-Id: I26cb43d2e67c54e689f1831ea13be46c73d5e92d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231595 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68246} | 5 年前 | |
Roll icu to fix sr-ME timeZoneName in Latin bug Bug: v8:10599 Change-Id: I1248d365576c0bc8c01d8ce07f0c49654fabfc52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2251173 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68422} | 5 年前 | |
[intl] Sync to ECMA402 PR709 to not read option twice https://github.com/tc39/ecma402/pull/709 Change DateTimeFormat logic to read option only once. Track which fields is not undefined from the GetOptions. Change test/intl to reflect the change and remove dup test. PR709 reached TC39 consensus in July 2023 meeting. Bug: v8:13908 Change-Id: I5a5429f6375a01b04e77093d32acb76ae1e40d11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4706795 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#89241} | 2 年前 | |
[intl] Revert date formatting behavior change from ICU 72 Replace U+202F with U+0020 after formatting date. This lets websites continue to work without any changes. This matches Firefox behavior, according to https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17. Bug: chromium:1414292, chromium:1401829, chromium:1392814 Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#85757} | 3 年前 | |
[intl] Sync to ECMA402 PR709 to not read option twice https://github.com/tc39/ecma402/pull/709 Change DateTimeFormat logic to read option only once. Track which fields is not undefined from the GetOptions. Change test/intl to reflect the change and remove dup test. PR709 reached TC39 consensus in July 2023 meeting. Bug: v8:13908 Change-Id: I5a5429f6375a01b04e77093d32acb76ae1e40d11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4706795 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#89241} | 2 年前 | |
[intl] Fix timezone bug in test If we're testing printing in UTC timezone, then we have to be careful to also input the date in UTC, else local timezone will affect the test. Fixed: chromium:1135116 Change-Id: I49981c263e7b1fa1492b4644c5d4846fd94e5613 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2448793 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70312} | 5 年前 | |
Fix "japanese" and "chinese" calendar Roll the icu to include the fix. The roll include previously mistakenly filter out required resources. Fix "japanese" under "ja" and calendar: "chinese" under "zh" Depends on https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2433166 This CL prepare for such landing: 1. Add test to show the correct result. 2. Wrap the number format static cast to DecimalFormat only if the concrete class is DecimalFormat. This is needed after the landing because the new resource enable other subclass of NumberFormat. 3. Change test to allow the additional numberingSystems. Roll the the DEPS of chromium in https://chromium-review.googlesource.com/c/chromium/src/+/2437820 Bug: v8:10960 Change-Id: Ib10b11862a093d1d487070f79556505bfc10bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432801 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#70253} | 5 年前 | |
Fix minimumIntegerDigits in NumberFormat The resolvedOptions of Intl.NumberFormat depends on the ICU's skeleton. sffc change the output of the wildcard from + to * in ICU67 (https://github.com/unicode-org/icu/commit/ac4540f8a45775ba1aafdb352e2561c0d1527329) Change the v8 code to use * instead. Bug: chromium:1108810 Change-Id: I8b0249a5bc4cc199f454c5070635100f68d1f48d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2318272 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69152} | 5 年前 | |
Reland "[intl] Clean up intl_segmenter flag" This is a reland of c9c3ec4c14868e7cd1554b1a273f5aebb6bc4052 Original change's description: > [intl] Clean up intl_segmenter flag > > Intl.Segmenter shipped in m87 and launched. > > Bug: v8:11225 > Change-Id: I4213e261e1aea717c1281f19785a8c29ff1bbd8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570461 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71653} Bug: v8:11225, v8:11240 Change-Id: Ibded9038671862d90206d328f8a12db51c40e63c Cq-Include-Trybots: luci.v8.try:v8_linux64_gc_stress_custom_snapshot_dbg_ng,v8_linux_arm64_gc_stress_dbg_ng,v8_linux_gc_stress_dbg_ng,v8_mac64_gc_stress_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2579043 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71691} | 5 年前 | |
Fix resolvedOption calendar for "iso8601" Use a bit to work around the issue of ICU getType() bug. Bug: v8:11295 Change-Id: I15d65bd44c489031d789e7638ea8abab90128124 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614216 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72028} | 5 年前 | |
Fix fuzzer problem due to allocation of string Bug: chromium:1130489 Change-Id: I506f2ea418bf3bde9468126534df9d78337e5f82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422086 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#70073} | 5 年前 | |
[date] Fix crash by invalid TimeZone "US/x0" names. Bug: chromium:1132641 Change-Id: Ifa005f9c901ccc865159b618e5145b6d83293b2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436078 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70182} | 5 年前 | |
Fix m(in|ax)imize() with long locale Bug: v8:11350 Change-Id: Ic34b40c4d88d6c2a0ac62bbebee4e2a95ebba826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648973 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72417} | 5 年前 | |
roll icu to Fix debug assertion in ICU Locale::setKeywordValue chromium DEPS rolled in https://chromium-review.googlesource.com/c/chromium/src/+/2536432 This CL is mainly to add unit test to ensure it fix. Bug: chromium:1146468 Change-Id: I30505d9133136122023d80ff85edbf0abe49c07e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2535790 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#71190} | 5 年前 | |
Fix BestFitMatcher due to invalid locale id in ICU Somehow we have no-NO-NY locale data in ICU and cause problem. Bug: v8:11595 Change-Id: I68ba4c4c219bb3fbc88976f901a86219c44ea265 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782602 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#73818} | 5 年前 | |
[intl] Fix space between day and hour in Chinese locale Make sure there are space between day and hour in the pattern when we alternate date pattern for the change of hour cycle. Bug: chromium:1170305 Change-Id: I2714111dcdedeefafdb854d1684f301786273303 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654002 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72418} | 5 年前 | |
Fix Use-of-uninitialized-value v8::internal::JSDateTimeFormat::New Bug: chromium:1177812, chromium:1177623 Change-Id: I91e6babd796c6735e96e3cd1541d8aba51aaefee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2706353 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72878} | 5 年前 | |
Fix Use-of-uninitialized-value v8::internal::JSDateTimeFormat::New Bug: chromium:1177812, chromium:1177623 Change-Id: I91e6babd796c6735e96e3cd1541d8aba51aaefee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2706353 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72878} | 5 年前 | |
[Intl] throw instead of DCHECK while long locale This is a temp fix to throw instead of DCHECK in debug build. The correct fix depends on the landing of https://github.com/unicode-org/icu/pull/1762 Once that land I will cherrypick into chrome to fix the function correctly. But the current (before this CL) behavior is not harmful in release build. It basically does not do the max nor min just return itself. Bug: chromium:1224869 Change-Id: Iebce2ab0a5ce047e83e8fce05db8290212e64509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3017300 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76047} | 4 年前 | |
[Intl] Clean up intl_number_format_v3 flag Intl NumberFormat v3 was shipped in m106. This cl clean up and remove the flag. Bug: v8:14087 Change-Id: I462cadf67ab590fe33635b650cedfb7865eb43cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4628807 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#88520} | 3 年前 | |
[intl] Fix ignorePunctuation: false for "th" locale The default value of ignorePunctuation in ICU collator for "th" locale is true. We should set the value if user specify the option. Remaining issue in https://github.com/tc39/ecma402/issues/832 is not changed yet. Bug: v:14307 Change-Id: I86ba6565c7840bd872be61eb3c4afb1e3f54e064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851726 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#89912} | 2 年前 | |
[intl] Enhance Date parser to take Unicode SPACE This is needed to prepare for the landing of ICU72. Allow U+202F in the Date String, which the toLocaleString("en-US") will generate w/ ICU72. Bug: v8:13494 Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#84308} | 3 年前 | |
[intl] Fix misplaced DCHECK Fixed: chromium:1427932 Change-Id: I4a9530200049765a96957fa8c200350ebaa2432e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417683 Reviewed-by: Shu-yu Guo <syg@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#87077} | 3 年前 | |
[intl] Fix ignorePunctuation: false for "th" locale The default value of ignorePunctuation in ICU collator for "th" locale is true. We should set the value if user specify the option. Remaining issue in https://github.com/tc39/ecma402/issues/832 is not changed yet. Bug: v:14307 Change-Id: I86ba6565c7840bd872be61eb3c4afb1e3f54e064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851726 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#89912} | 2 年前 | |
Upgrade to ICU 77.1 Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/zzN7erylAc4/m/WDdY1EykAAAJ Update diary and test failure analysis: https://docs.google.com/document/d/1AW8sZ-qKgrAhAUKyp56P4L6c6Sk-8pw_W53bGPbYbhQ/edit?usp=sharing https://docs.google.com/document/d/1lrfJJmWvLXYPYSYlxE3mXTgDZI9U1bw2FrJYrDorgqE/edit?usp=sharing Bug: 368208157, 421834885 Change-Id: I981aaaf3a05f2538fb7edd8e4105254632f605c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6586986 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#102922} | 9 个月前 | |
Fix special case timezone RangeError Bug: chromium:364374 Change-Id: I361403b26529860c4240d06766a82937ee8ca115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150070 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67158} | 6 年前 | |
Fix out of bound string access Bug: 386857213 Change-Id: Iebaca1e9c7b0f0329b46b9ab57a69f5a44e99016 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6231554 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#98524} | 1 年前 | |
[intl] Fix get Intl.Locale.prototype.language Return "und" instead of *undefined* for language. Bug: 407793302 Change-Id: I117e4bed7b141861cad124fbaff39dc756ec1fec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6421525 Feels: Nikolaos Papaspyrou <nikolaos@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#99643} | 1 年前 | |
[intl] Change fatal to exception due to lack of resources Other Intl object address the same issue in https://issues.chromium.org/issues/42200234 Fixed: 412149700 Change-Id: Ieca48451cd81efc7f9cb52d8cc806bc4c6f01323 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6599691 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#100658} | 1 年前 | |
[intl] Fix best fit locale matcher Address the issue while the locale is not a valid one. Move the check out of the iterator loop so we can ignore it. Bug: 450077863 Change-Id: I8dd4f702cab16464b2f823775ffb27f93bf5da4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7088956 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#103378} | 8 个月前 | |
Use stricter type checks in Intl's bound methods This patch ensures that Intl bound method getters can't be retargeted to other Intl types. If that were to happen, then a RUNTIME_ASSERT would trigger later. This patch throws a TypeError instead, as the specification requires. BUG=v8:4870 Review-Url: https://codereview.chromium.org/1986763003 Cr-Commit-Position: refs/heads/master@{#36330} | 9 年前 | |
Avoid calling the builtin String.prototype.split in Intl The Intl code previously called the initial value of String.prototype.split for some internal operations. However, this did not have the intended effect as Intl only needs to split strings by strings, but String.prototype.split has integration with Symbol.split for RegExps. This patch replaces the calls of StringSplit in the Intl implementation with direct calls to the %StringSplit runtime function to avoid the issue. R=yangguo@chromium.org BUG=v8:5179 Review-Url: https://codereview.chromium.org/2126073002 Cr-Commit-Position: refs/heads/master@{#37615} | 9 年前 | |
[intl] Revert date formatting behavior change from ICU 72 Replace U+202F with U+0020 after formatting date. This lets websites continue to work without any changes. This matches Firefox behavior, according to https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17. Bug: chromium:1414292, chromium:1401829, chromium:1392814 Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#85757} | 3 年前 | |
[Intl] Reland tests of "Validate u extension type" This is a PARTIAL reland of 8d0942499cf4bca74b58c675d7270c8b7ce95abb Only land the newly added tests files Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} Bug: v8:7481 Change-Id: I0a1c5701ade330026e2cf7eb554c6390b048a68d Reviewed-on: https://chromium-review.googlesource.com/c/1396737 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58604} | 7 年前 | |
[mjsunit] Fix intl test when LC_MESSAGES is set This test regularly fails due to my local language setting. Change-Id: Ic4719ffbe49a8fc9d38d75b05b52ac550315a405 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114138 Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#76448} | 4 年前 | |
Fix maximize/minimize of Intl.Locale Roll ICU to 46f53dfc chromium/src/DEPS already roll in https://chromium-review.googlesource.com/c/chromium/src/+/2235734 Bug: v8:10448 Change-Id: I147189527e57282c6cc7a1e92f832275d5ef55c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237353 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68275} | 5 年前 | |
Reland test part of "[Intl] Cleans up intl-relative-time-format flag" This is a partial reland of 048a3a3ecb43973b0491d464091268216ba94504 Original change's description: > [Intl] Cleans up intl-relative-time-format flag > > Cleans up always=true intl-relative-time-format flag > It shipped in m71 in Dec 2018. > > Bug: v8:8704 > Change-Id: I52d86aea9aedf201a216a1df0773a486fbee37b9 > Reviewed-on: https://chromium-review.googlesource.com/c/1417299 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58904} Bug: v8:8704 Change-Id: Iac62a347eea7f85dd3fa4a3bbfb18091b80f9a5e Reviewed-on: https://chromium-review.googlesource.com/c/1429224 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59081} | 7 年前 | |
[Intl] Remove --harmony-intl-list-format flag from test This is part 1 of 2 of clean up. C++ change in Part 2 next. Bug: v8:8705 Change-Id: Ibf4425c141391581b963f4775286b65b652452e2 Reviewed-on: https://chromium-review.googlesource.com/c/1461172 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59581} | 7 年前 | |
[Intl] Cutting 43K by removing Unibrow when ICU available Making 43K of room for landing ICU64. Size Change (on x64.release) D8 before 23,683,192 D8 after 23,639,296 Reduce 43,896 bytes Bugs: v8:8348 Change-Id: I057f7d59e955a2e5e017873e5b3b5daf5b142ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1478710 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60616} | 7 年前 | |
Drop regress-{8432,8413} from intl.status. Both regress-8432 and regress-8413 pass with the latest ICU roll to 407b393. TBR=ftang@chromium.org,gsathya@chromium.org,machenbach@chromium.org Bug: v8:8432,v8:8414 Change-Id: I56f3d88c1f90021ad51062bc5f26a9e88877f954 Reviewed-on: https://chromium-review.googlesource.com/c/1341455 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57590} | 7 年前 | |
[Intl] Add regression test for -u-tz- of Intl.DateTimeFormat The fix need to be cherrypick from ICU. Fix in https://github.com/unicode-org/icu/pull/286 Adds regression test for 8469. Bug: v8:8469 Change-Id: If173058dd1113782fcf2ff5a55f962721f46aba5 Reviewed-on: https://chromium-review.googlesource.com/c/1340733 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58032} | 7 年前 | |
[Intl] Fix numberingSystem for NumberFormat Bug: v8:8525 Change-Id: I42764afbb419825fe6af504a641a78dbb127f30c Reviewed-on: https://chromium-review.googlesource.com/c/1355629 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58067} | 7 年前 | |
Add regression test for v8:8604 Bug: v8:8604 Change-Id: Ieab15e55ed392019cc94de80d8e9c1a33f4d599a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573038 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60928} | 7 年前 | |
[Intl] Remove harmony-locale flag harmony-locale is shipped in m74 and m74 is already out. Remove harmony-locale flag from the code. Bug: v8:8910 Change-Id: If9634b6767cfe449cfa03980bbad26ceb7408c79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592465 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61429} | 7 年前 | |
[Intl] Throws exception on grandfather and private locale Bug: v8:9613 Change-Id: Ie91a5bd39c82b6baf33fd84dee8420d2c4a5f504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803783 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63815} | 6 年前 | |
[Intl] Convert options arg to Object before processing it This makes us spec compliant. Bug: chromium:875643 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I489870495fe1d326991c99f0551fe3329268c984 Reviewed-on: https://chromium-review.googlesource.com/1199910 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55567} | 7 年前 | |
Add regression test for v8:8866 Bug: v8:8866 Change-Id: I3a25c68fe4d8536596118352804daa3c6025da37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643466 Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62042} | 6 年前 | |
[Intl] Remove incorrect CHECK The CHECK was introduced in d7ae63e6f2b5f39b905ce35aee68129af75b5e10. The first time the property got read by ToDateTimeOptions and the test will cause the needsDefault in ToDateTimeOptions be false. Then in step 22 of InitializeDateTimeFormat, it will get all undefined and cause the skeleton to be empty string. If we only pass in empty options, the defaults will be filled by ToDateTimeOptions and won't cause any CHECK failure. Bug: chromium:888299 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3ee14434f0708eaaea78cc8857591152d1bdef8a Reviewed-on: https://chromium-review.googlesource.com/1241316 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56226} | 7 年前 | |
[Intl] Validate extension keys - Fix ParseBCP47 to return just the extension. The second argument to substr function is actually the length, not the end position of the substring :') - Remove extension keys that aren't part of the relevant extension keys - Use 'ca' as an relevant extension key for DateTimeFormat - Use the canonicalized locale tag after create the ICU locale is created, rather than the input locale tag. Bug: chromium:895942, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I189709714d847e684b04409b734a60ff04ed7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1291076 Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57274} | 7 年前 | |
Reland "[intl] Clean up intl_segmenter flag" This is a reland of c9c3ec4c14868e7cd1554b1a273f5aebb6bc4052 Original change's description: > [intl] Clean up intl_segmenter flag > > Intl.Segmenter shipped in m87 and launched. > > Bug: v8:11225 > Change-Id: I4213e261e1aea717c1281f19785a8c29ff1bbd8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570461 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71653} Bug: v8:11225, v8:11240 Change-Id: Ibded9038671862d90206d328f8a12db51c40e63c Cq-Include-Trybots: luci.v8.try:v8_linux64_gc_stress_custom_snapshot_dbg_ng,v8_linux_arm64_gc_stress_dbg_ng,v8_linux_gc_stress_dbg_ng,v8_mac64_gc_stress_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2579043 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71691} | 5 年前 | |
[Intl] Only use DecimalFormat Force to use locale with extension if the created NumberFormat is not a DecimalFormat. Check the dynamic class id. Guard DecimalFormat casting code Bug: v8:9035 Change-Id: Id32a3f652b93ddfca82f95f30ad2107b364ee7fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536571 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60452} | 7 年前 | |
[test][cleanup] Revive --time, speed up some tests This reimplements the "--time" option of run-tests.py to print the 20 slowest tests, on top of json_test_results infrastructure just like the bots do it. Additionally this CL speeds up a bunch of slow tests. Bug: v8:9396 Change-Id: I40797d2c8c3bfdd310b72f15cd1a035844b7c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803635 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63786} | 6 年前 | |
Fix locale of Intl.Collator..resolvedOptions Bug: v8:7481, v8:9084, v8:8664 Change-Id: Iccbf78bf11a4e8ca5d105772fa5f654fbe6542cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410791 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69951} | 5 年前 | |
[Intl] Fix CHECK fail in Intl::ToLanguageTag() Make the function return Maybe<std::string> to propagate error. Bug: chromium:917151 Change-Id: I4330b0c54c122b1eddd3b37e21e0f387cb5d803a Reviewed-on: https://chromium-review.googlesource.com/c/1392205 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58535} | 7 年前 | |
[Intl] Fix DefaultHourCycle to skip hHkK in literal Bug: chromium:925216 Change-Id: I29d71df0c4c7850a80a86cd0719dea04fcc61816 Reviewed-on: https://chromium-review.googlesource.com/c/1436597 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59146} | 7 年前 | |
[Intl] Fix special case timezone Antarctica/DumontDUrville has special casing. Bug: chromium:928068 Change-Id: I8aea2fafc2c14d6fbfee8a95910df7e8d7d1ff37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507329 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60108} | 7 年前 | |
[Intl] Fix Null-dereference in CreateICUDateFormatFromCache Bug: chromium:930304 Change-Id: I7793f83b3f3e9aeaa3ecf114c6064773257e90e8 Reviewed-on: https://chromium-review.googlesource.com/c/1461167 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59587} | 7 年前 | |
[Intl] Add test cases for %%ALIAS locales Bug: v8:9312, chromium:968269 Change-Id: I0e3d134cd4341c30277df62fead6386e344be0bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1636179 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#61952} | 7 年前 | |
[Intl] Fix /ſ/i.test('ſ'.toUpperCase()) be false. Address special case condiction for U+017F. Bug: v8:9356 Change-Id: Id24e5e2c999b198bf0f696aea8c98f223508c051 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827683 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64028} | 6 年前 | |
[Intl] Clean up by removing the following flags harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736} | 6 年前 | |
Correct the name of the regression test Bug: v8:9464 Change-Id: Ibdc6f9797661e357e01c2f02565eeca12abbf8ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801251 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63764} | 6 年前 | |
[Intl] Clean up by removing the following flags harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736} | 6 年前 | |
[Intl] Clean up by removing the following flags harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736} | 6 年前 | |
Fix crash under lb_LU locale Bug: v8:9642 Change-Id: I2dcd1c0e3c208b15b5c0ec0f08880744134f7474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1769479 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63404} | 6 年前 | |
[intl] Remove two flags ship in m80 Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377} | 6 年前 | |
[Intl] Fix RegExp [\W] with i flag Add special condiction in ecma262 #sec-runtime-semantics-canonicalize-ch Step 3.g-h. Bug: chromium:971636 Change-Id: Id533beb66749af6e38ee114cf79f995a1156df20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1652795 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62105} | 6 年前 | |
[Intl] Fix /k/i.test('\u212A') Add logic stated in Bug: v8:9731 Change-Id: I0b3468bbad11a178f36d682febd0e44214646de8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828279 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64027} | 6 年前 | |
[Intl] Sync ListFormat to latest spec. 1. Add StringListFromIterable based on https://tc39.es/proposal-intl-list-format/#sec-createstringlistfromiterable 2. Adjust other parts to sync with the new version. Bug: v8:9747 Change-Id: I14202f2963463e6a3e9816209f087bfe8e73cb91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1809902 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63899} | 6 年前 | |
[intl] Remove two flags ship in m80 Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377} | 6 年前 | |
[intl] Remove two flags ship in m80 Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377} | 6 年前 | |
[intl] Remove two flags ship in m80 Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377} | 6 年前 | |
[Intl] Add test for calendar of formatRange Bug: v8:9812 Change-Id: I222b9c3c8c87e83b61009c84e2ab0499187308e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1842623 Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64147} | 6 年前 | |
Fix crash bug with some numberingSystem and dateStyle/timeStyle Bug: v8:9849 Change-Id: Ib7812e27dcacb30fd2610badbf79dee190fdec15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869078 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64436} | 6 年前 | |
[intl] Remove two flags ship in m80 Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377} | 6 年前 | |
[intl] Migrate to ICU 72 DEPS change in chromium is in https://chromium-review.googlesource.com/c/chromium/src/+/3995549 and should be landed first. This CL fix all the broken test in v8. ICU72 release note https://icu.unicode.org/download/72 CLDR42 release note https://cldr.unicode.org/index/downloads/cldr-42 Key changes 1. Fix the test expectation for the formatted date string a. use U+202f (narrow nbsp) before "PM" and "AM". b. use U+200A (thin space) around U+2013 in date duration format. 2. Mark the test262 breakage. Bug: chromium:1371208 Change-Id: I4e2ecc6330845a2bf86711bc4ee6fe6407f140c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4004606 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#84374} | 3 年前 | |
[Intl] Fix Hungarian number format grouping By rolling icu to faee8bc which contains the upstream CLDR fix. Bug: v8:992694 Change-Id: I073d15396fa0e7c5054aa4e0806e5842228955f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799424 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63768} | 6 年前 | |
Remove CHECK which fail while the locale is long. Bug: chromium:997401 Change-Id: I7a78f4ad1fd05ab2bb2dbcd343060b2647aef4e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771954 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63660} | 6 年前 | |
[flag] Remove --always-turbofan Bug: 431974094 Change-Id: Ia86d64cf626db0977299f8ec105f86ee4f385e7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6781181 Reviewed-by: Marja Hölttä <marja@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#101612} | 11 个月前 | |
[test] Use pathlib in test framework This turns all paths in the test frameworks and all its suite implementations from strings into pathlib paths. This makes the framework more future-proof, simplifies a lot of code and enhances readability. It comes with the risk of introducing new bugs. This is lowered using an experimental test comparison script: https://crrev.com/c/4648372. Some detailed changes: - The "path" of a test case is now a pathlib path (also in cases where the path doesn't correspond to a location on the file system). This path is always relative to the test root. - The "name" of a test case is the posix string of that path used in status files and at the command line. - All other paths are absolute. - We use some more wrapping with Path() than absolutely necessary. Reducing such a wrapping where it's not needed is a micro-optimization and the potential by introducing a bug by forgetting one is worse. - Some modules are not happy with pathlib objects, hence a few explicit str() conversions are added. Thoughts on risk: - The highest risk is that due to the newly introduced logic, some test cases are silently filtered and not run now. We'll manually compare runs before and after this change. - Each test attempted to run will either pass or fail, failures won't be silent. E.g. a wrong path passed to the cctest executable is flagged as a failure. - Wrongly constructed paths to JS test cases lead to failures (tested several manually). Other failure types: - Some string path not turned into pathlib: Will typically fail when calling any pathlib function. - Some pathlib object treated as a string: Will typically raise an exception, e.g. using in-operator. - Logic bugs in pathlib functions behaving differently than anticipated, e.g. with_suffix(): Will typically result in wrong paths, resulting in errors reading a test case. Though worst case could be silent ignoring. Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg Cq-Include-Trybots: luci.v8.try:v8_numfuzz_rel Cq-Include-Trybots: luci.v8.try:v8_numfuzz_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_msan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel Bug: chromium:1132088 Change-Id: Ifc94feb292174935db969dcf5d174d2eedcf3dfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4538761 Reviewed-by: Liviu Rau <liviurau@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#88502} | 3 年前 | |
[Intl] Define @@toStringTag for Intl namespace Implement https://github.com/tc39/ecma402/pull/487 Also improve test/intl/toStringTag.js see also: https://github.com/tc39/test262/pull/2712 Bug: v8:10744 Change-Id: I678876aa21f169a8dfcec8e3ce974978a8847fe0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315455 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69185} | 5 年前 | |
Import intl test suite from v8-i18n project BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18687003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 | 12 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 6 年前 | ||
| 7 年前 | ||
| 5 年前 | ||
| 8 个月前 | ||
| 4 年前 | ||
| 1 年前 | ||
| 4 年前 | ||
| 1 年前 | ||
| 5 年前 | ||
| 1 年前 | ||
| 4 年前 | ||
| 8 个月前 | ||
| 8 年前 | ||
| 1 年前 | ||
| 3 年前 | ||
| 5 年前 | ||
| 10 年前 | ||
| 8 年前 | ||
| 1 年前 | ||
| 5 年前 | ||
| 3 年前 | ||
| 9 年前 | ||
| 11 个月前 | ||
| 11 个月前 | ||
| 11 个月前 | ||
| 7 年前 | ||
| 8 个月前 | ||
| 9 年前 | ||
| 6 年前 | ||
| 5 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 2 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 4 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 2 年前 | ||
| 3 年前 | ||
| 2 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 5 年前 | ||
| 4 年前 | ||
| 3 年前 | ||
| 2 年前 | ||
| 3 年前 | ||
| 3 年前 | ||
| 2 年前 | ||
| 9 个月前 | ||
| 6 年前 | ||
| 1 年前 | ||
| 1 年前 | ||
| 1 年前 | ||
| 8 个月前 | ||
| 9 年前 | ||
| 9 年前 | ||
| 3 年前 | ||
| 7 年前 | ||
| 4 年前 | ||
| 5 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 6 年前 | ||
| 7 年前 | ||
| 6 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 5 年前 | ||
| 7 年前 | ||
| 6 年前 | ||
| 5 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 3 年前 | ||
| 6 年前 | ||
| 6 年前 | ||
| 11 个月前 | ||
| 3 年前 | ||
| 5 年前 | ||
| 12 年前 |