| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Allow name collision when materializing scope object When materializing a scope object, we previously assumed that we will not have any name collisions. This is not correct e.g. when eval introduces an aliased local variable. This CL resolves this wrong assumption. The test case should not crash. It however fails as there is a bug in how debug-evaluate should resolve variables defined in eval. R=verwaest@chromium.org Fixed: chromium:1240962 Bug: chromium:1264852 Change-Id: I0e41e7905589735e25eff221376d09997ea99117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3250911 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77649} | 4 年前 | |
[temporal] Remove --harmony-temporal from non-Temporal tests In https://chromium-review.googlesource.com/c/v8/v8/+/7111926 I added --harmony-temporal to some tests to ensure they still pass with Temporal enabled. However, they are not Temporal tests; they should not be enabling this flag long term. Now that Temporal is unflagged (https://chromium-review.googlesource.com/c/v8/v8/+/7123876), this can be removed. Bug: 401065166 Change-Id: I00a7f7d585670bd0ddc10501931add682e803cfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124594 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#103562} | 7 个月前 | |
[debugger] basic test infrastructure for new debugger test api. This introduces: - a way in d8 to send messages to the inspector and receive responses. - a new test suite where existing debugger tests should migrate to. R=jgruber@chromium.org, kozyatinskiy@chromium.org, machenbach@chromium.org BUG=v8:5530 Review-Url: https://chromiumcodereview.appspot.com/2425973002 Cr-Commit-Position: refs/heads/master@{#40487} | 9 年前 | |
[osr] Ensure trying to osr does not skip loop interrupts Fixed: 374013413 Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#96708} | 1 年前 | |
[debugger] Various break-related functionality in test wrapper This CL adds simple implementation of break and stepping-related functionality as required by the debug-step.js test. This includes * stepOver, stepInto, stepOut * setBreakPoint * clearBreakPoint * evaluate Some of these, e.g. setBreakPoint are not fully implemented for all cases but only for the ones we need right now. One interesting result of this is that using the inspector protocol is roughly 14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to be iteration over all object properties in toProtocolValue, which is used to serialize JS objects before being sent over the wire (e.g. FrameMirrors). This is something that should be fixed at some point. In the meantime, the test now runs 100 instead of 1000 iterations. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2447073007 Cr-Commit-Position: refs/heads/master@{#40636} | 9 年前 | |
[build] Add data deps for d8 test suites Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifb8719a989a4fda48241967271ebe39037643e39 Reviewed-on: https://chromium-review.googlesource.com/980032 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52223} | 8 年前 | |
Use relative paths to OWNERS files R=machenbach@chromium.org Bug: chromium:992584 Change-Id: I301013731a502689f2edd5c90e5e7bf2136198c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745337 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63159} | 6 年前 | |
[test] Rerun tests more often in verify-predictable mode This will more reliably show tests that are not predictable. Which then can get skipped or otherwise resolved. Bug: 42203172, 374722652 Change-Id: I1c159ab54d2d3a7effd461a625e4f3a8ec6d9211 Cq-Include-Trybots: luci.v8.try:v8_linux64_predictable_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5940380 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#96716} | 1 年前 | |
Reduce boilerplate needed for heap object type defs New types have to be added in a bunch of spots that are scattered all over the codebase. Worse, these spots are only exposed by repeated compile-error-edit loops and finding/fixing them all is painful. This CL fixes this painpoint by adding ONE spot in which 'simple' types have to be added, namely in object-list-macros.h Macro-list magic then automatically appends to all relevant places in the codebase: - large-spaces.cc for the list of types that may be in LO spaces - objects-visiting.h for visitor function defs - map.h to define VisitorId entries - map.cc to associate types with visitor ids - objects-body-descriptors-inl.h to associate instance types with body descriptors Drive-by: replace the IsFunction predicate with the clearer IsJSFunctionOrBoundFunctionOrWrappedFunction and remove the artificial Function type definition. Drive-by: remove the manual forward-declarations in object-list-macros.h. For heap object types, we auto-generate forward-declarations. Other types should be forward-declared manually as needed. Bug: v8:14345 Change-Id: Id52be94ee7f53414576dc8c84b82865569a2933a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4932245 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#90453} | 2 年前 | |
[test] Use pathlib in test framework This turns all paths in the test frameworks and all its suite implementations from strings into pathlib paths. This makes the framework more future-proof, simplifies a lot of code and enhances readability. It comes with the risk of introducing new bugs. This is lowered using an experimental test comparison script: https://crrev.com/c/4648372. Some detailed changes: - The "path" of a test case is now a pathlib path (also in cases where the path doesn't correspond to a location on the file system). This path is always relative to the test root. - The "name" of a test case is the posix string of that path used in status files and at the command line. - All other paths are absolute. - We use some more wrapping with Path() than absolutely necessary. Reducing such a wrapping where it's not needed is a micro-optimization and the potential by introducing a bug by forgetting one is worse. - Some modules are not happy with pathlib objects, hence a few explicit str() conversions are added. Thoughts on risk: - The highest risk is that due to the newly introduced logic, some test cases are silently filtered and not run now. We'll manually compare runs before and after this change. - Each test attempted to run will either pass or fail, failures won't be silent. E.g. a wrong path passed to the cctest executable is flagged as a failure. - Wrongly constructed paths to JS test cases lead to failures (tested several manually). Other failure types: - Some string path not turned into pathlib: Will typically fail when calling any pathlib function. - Some pathlib object treated as a string: Will typically raise an exception, e.g. using in-operator. - Logic bugs in pathlib functions behaving differently than anticipated, e.g. with_suffix(): Will typically result in wrong paths, resulting in errors reading a test case. Though worst case could be silent ignoring. Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg Cq-Include-Trybots: luci.v8.try:v8_numfuzz_rel Cq-Include-Trybots: luci.v8.try:v8_numfuzz_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_msan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel Bug: chromium:1132088 Change-Id: Ifc94feb292174935db969dcf5d174d2eedcf3dfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4538761 Reviewed-by: Liviu Rau <liviurau@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#88502} | 2 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 4 年前 | ||
| 7 个月前 | ||
| 9 年前 | ||
| 1 年前 | ||
| 9 年前 | ||
| 8 年前 | ||
| 6 年前 | ||
| 1 年前 | ||
| 2 年前 | ||
| 2 年前 |