| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[inspector] Provide more details about destroyed context Runtime.executionContextCreated provides many details in ExecutionContextDescription structure while Runtime.executionContextDestroyed provides only executionContextId. This information is insufficient for the clients that use uniqueContextId. Bug: v8:12896 Change-Id: I31df0ed618dc1c8b55c7eba8f96eeaef2d4de6c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657439 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Vladimir Nechaev <nechaev@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#85110} | 3 年前 | |
[inspector] Support multiple sessions per context group This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667} | 8 年前 | |
Report an explicit pause reason when stopping after taking a step. This way, DevTools can distinguish pausing after a step from other reasons, which is a necessary stop condition for autostepping. As this is only breaking out a special case out of a catch-all enum we're not considering it a breaking protocol change. Bug: chromium:1418938 Change-Id: Idd0af9446519fa08c7244f8270d8190e5c5df889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4290476 Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#86656} | 3 年前 | |
[inspector] Correct location for inline scripts with sourceURL. Previously the Debugger.CallFrames in Debugger.paused events would report locations relative to the surrounding document in case of inline scripts with //@ sourceURL annotations (while Runtime.CallFrame was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in Debugger.CallFrame are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450} | 4 年前 | |
[inspector] forEachSession iterates in predictable order protocol::HashMap(std::unordered_map)::iterator doesn't provide any guarantees about iteration order. At least Visual C++ from vS 2015 and clang compile for loop inside forEachSession differently. For tests we need stable order of iteration, so let's use std::map instead. R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I329cb24cd182baa86c0ea4a526257856718f32b1 Reviewed-on: https://chromium-review.googlesource.com/609489 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47281} | 8 年前 | |
[inspector] Make pausing on console.assert work with multiple sessions Instead of going through debugger agent, this patch implements console.assert pause similar to debugger statement and OOM break. New test uncovered a bug, where pause on exceptions state mix up between different context groups. Added a TODO to fix it. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916363002 Cr-Commit-Position: refs/heads/master@{#45711} | 8 年前 | |
[inspector] Add executionContextId to Runtime.inspectRequested. This properly threads through the executionContextId to the request reported to the DevTools front-end, similarly to how we already report the executionContextId as part of Runtime.bindingCalled. Bug: chromium:1231521 Change-Id: I0a003041aedd8ec661d1b07cdddbcd1f2866a99f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3046187 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75875} | 4 年前 | |
[inspector] Create InjectedScript per session in each context This gives sessions separate remote objects space and also makes command line api respect the session it was called from. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916803005 Cr-Commit-Position: refs/heads/master@{#45708} | 8 年前 | |
Revert "Add executionContextUniqueId to various methods" This reverts commit 9e0a846cd46426467a1bb880740883be414dc20a. Reason for revert: causes crashes https://crbug.com/341228752 Original change's description: > Add executionContextUniqueId to various methods > > Currently, the unique context ID is exposed in some methods while > other methods only expose not-unique ID. This CL adds the unique ID to addBinding, bindingCalled and consoleAPICalled so that clients can more > reliably identify an execution context. > > Bug: chromium:340592165 > Change-Id: I43475786df57191c8e1c6fcc92adc88de751edb1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5518197 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#93904} Bug: chromium:340592165 Change-Id: Ibe7b9410c455d672d4d9826da753ef3324d60bda Fixed: chromium:341228752 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5547738 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#93962} | 2 年前 | |
[inspector] Support multiple sessions per context group This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667} | 8 年前 | |
[inspector] Don't create remote objects for non-shared 'Error' objects Since the page can install accessors on various 'Error' prototypes, its possible to leak information from cross-origin scripts (via the inspector remote object). This CL fixes this particular instance by not creating remote objects for Errors where the 'SharedCrossOrigin' bit is not set in the originating script. Note that to do this, we have to find the right script and get it's origin info. We can't go via the debugger agent as it has not necessarily been enabled and so the script map in the debugger agent could be empty. Drive-by: There is one more oddity we don't fully understand. The scriptId passed via V8Inspector is set to 0 if it matches the top-most frame. This CL reverts this logic in the inspector, but this might break some expectation in DevTools. R=bmeurer@chromium.org Fixed: 420885124 Change-Id: I3c1a7524349cdbadd6768f8c6bf5119d4b59369a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6606957 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#100606} | 1 年前 | |
Use Isolate::GetEnteredOrMicrotaskContext instead of GetEnteredContext This CL replaces most of Isolate::GetEnteredContext with GetEnteredOrMicrotaskContext, as it should be more relevant. Here is a brief overview of the series of changes. https://docs.google.com/document/d/1MY_xlsYS7E6_qbwwY66-FH3JkAYeTHBlF5qVBrBpWyY/edit#heading=h.fx2rezbyzz5c Bug: v8:8124 Change-Id: I27355e325a92094240c25b672d1219f3214a9da0 Reviewed-on: https://chromium-review.googlesource.com/c/1297654 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#57470} | 7 年前 | |
Revert "[inspector] RemoteObject.description should be empty for primitive type" This reverts commit 003159e777ea2af3a8a9653955897a44d8e34e72. Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140 Original change's description: > [inspector] RemoteObject.description should be empty for primitive type > > We currently report description field for numbers. On client side user > can calculate description as remoteObject.unserializableValue || > (remoteObject.value + ''). Let's report description only for objects to > simplify value -> remoteObject logic a bit. > > R=dgozman@chromium.org > TBR=jgruber@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc > Reviewed-on: https://chromium-review.googlesource.com/737485 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53453} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1081207 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53461} | 7 年前 | |
[inspector] Support multiple sessions per context group This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667} | 8 年前 | |
Reland "[inspector] Report [[Prototype]] as internal property." This is a reland of 2b94e5677f6c75667b10a44bf648e8367110b627 Original change's description: > [inspector] Report [[Prototype]] as internal property. > > Previously the inspector was trying to add a special __proto__ > property to every JSObject, which looked and behaved like a real > data property on the object. But this is confusing to developers > since __proto__ is not a real data property, but usually an > accessor property on the Object.prototype. > > Additionally all other internal properties are reported using the > [[Name]] notation, with the [[Prototype]] having been the strange > outlier. > > Drive-by-cleanup: Use an ArrayList to collect the name/value pairs > inside Runtime::GetInternalProperties(), which makes this function > more readable and easier to add things. > > Bug: chromuium:1162229 > Fixed: chromium:1197019 > Screenshot: https://imgur.com/a/b7TZ32s.png > Change-Id: Ic4c1e35e2e65f90619fcc12bf3a72806cadb0794 > Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814565 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73881} Bug: chromuium:1162229, chromium:1197019 Screenshot: https://imgur.com/a/b7TZ32s.png Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM Change-Id: Ie1e2276b385b18a5f865fdae583d1ce0101157c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2820970 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#73899} | 5 年前 | |
[inspector] Create InjectedScript per session in each context This gives sessions separate remote objects space and also makes command line api respect the session it was called from. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916803005 Cr-Commit-Position: refs/heads/master@{#45708} | 8 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 3 年前 | ||
| 8 年前 | ||
| 3 年前 | ||
| 4 年前 | ||
| 8 年前 | ||
| 8 年前 | ||
| 4 年前 | ||
| 8 年前 | ||
| 2 年前 | ||
| 8 年前 | ||
| 1 年前 | ||
| 7 年前 | ||
| 7 年前 | ||
| 8 年前 | ||
| 5 年前 | ||
| 8 年前 |