Star4
54
代码
代码
Issues31
Pull Requests19
流水线
讨论
Wiki
分析
Star4
54
wan-xiaoqing321wan-xiaoqing321kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures
183718ce创建于 2024年3月7日历史提交
文件最后提交记录最后更新时间
Makefile
kcsan: avoid passing -g for test stable inclusion from stable-5.10.177 commit f7385e0886cda36050e84b15cae2cdbf61415f3d category: bugfix issue: #I8IT18 CVE: NA Signed-off-by: wanxiaoqing <wanxiaoqing@huawei.com> --------------------------------------- [ Upstream commit 5eb39cde1e2487ba5ec1802dc5e58a77e700d99e ] Nathan reported that when building with GNU as and a version of clang that defaults to DWARF5, the assembler will complain with: Error: non-constant .uleb128 is not supported This is because -g defaults to the compiler debug info default. If the assembler does not support some of the directives used, the above errors occur. To fix, remove the explicit passing of -g. All the test wants is that stack traces print valid function names, and debug info is not required for that. (I currently cannot recall why I added the explicit -g.) Link: https://lkml.kernel.org/r/20230316224705.709984-2-elver@google.com Fixes: 1fe84fd4a402 ("kcsan: Add test suite") Signed-off-by: Marco Elver <elver@google.com> Reported-by: Nathan Chancellor <nathan@kernel.org> Cc: Alexander Potapenko <glider@google.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: wanxiaoqing <wanxiaoqing@huawei.com>2 年前
atomic.h
kcsan: Remove existing special atomic rules Remove existing special atomic rules from kcsan_is_atomic_special() because they are no longer needed. Since we rely on the compiler emitting instrumentation distinguishing volatile accesses, the rules have become redundant. Let's keep kcsan_is_atomic_special() around, so that we have an obvious place to add special rules should the need arise in future. Signed-off-by: Marco Elver <elver@google.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>5 年前
core.c
kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures stable inclusion from stable-5.10.188 commit 958acb479ef21599a85f87f70eb07f38a8363568 category: bugfix issue: #I96OB2 CVE: NA Signed-off-by: wanxiaoqing <wanxiaoqing@huawei.com> --------------------------------------- [ Upstream commit 353e7300a1db928e427462f2745f9a2cd1625b3d ] Activating KCSAN on a 32 bits architecture leads to the following link-time failure: LD .tmp_vmlinux.kallsyms1 powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_load': kernel/kcsan/core.c:1273: undefined reference to __atomic_load_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_store': kernel/kcsan/core.c:1273: undefined reference to __atomic_store_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_exchange': kernel/kcsan/core.c:1273: undefined reference to __atomic_exchange_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_add': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_add_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_sub': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_sub_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_and': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_and_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_or': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_or_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_xor': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_xor_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_fetch_nand': kernel/kcsan/core.c:1273: undefined reference to __atomic_fetch_nand_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_compare_exchange_strong': kernel/kcsan/core.c:1273: undefined reference to __atomic_compare_exchange_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_compare_exchange_weak': kernel/kcsan/core.c:1273: undefined reference to __atomic_compare_exchange_8' powerpc64-linux-ld: kernel/kcsan/core.o: in function __tsan_atomic64_compare_exchange_val': kernel/kcsan/core.c:1273: undefined reference to __atomic_compare_exchange_8' 32 bits architectures don't have 64 bits atomic builtins. Only include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures. Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins") Suggested-by: Marco Elver <elver@google.com> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> Reviewed-by: Marco Elver <elver@google.com> Acked-by: Marco Elver <elver@google.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/d9c6afc28d0855240171a4e0ad9ffcdb9d07fceb.1683892665.git.christophe.leroy@csgroup.eu Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: wanxiaoqing <wanxiaoqing@huawei.com>2 年前
debugfs.c
kcsan: Fix debugfs initcall return type commit 976aac5f882989e4f6c1b3a7224819bf0e801c6a upstream. clang with CONFIG_LTO_CLANG points out that an initcall function should return an 'int' due to the changes made to the initcall macros in commit 3578ad11f3fb ("init: lto: fix PREL32 relocations"): kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int' late_initcall(kcsan_debugfs_init); ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ include/linux/init.h:292:46: note: expanded from macro 'late_initcall' #define late_initcall(fn) __define_initcall(fn, 7) Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init") Cc: stable <stable@vger.kernel.org> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Marco Elver <elver@google.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>4 年前
encoding.h
kcsan: Never set up watchpoints on NULL pointers mainline inclusion from mainline-v5.11-rc1 commit 55a2346c7ac4 category: bugfix issue: #I3ZXZF CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=55a2346c7ac4 ------------------------------------------------- Avoid setting up watchpoints on NULL pointers, as otherwise we would crash inside the KCSAN runtime (when checking for value changes) instead of the instrumented code. Because that may be confusing, skip any address less than PAGE_SIZE. Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Signed-off-by: Marco Elver <elver@google.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Wei Li <liwei391@huawei.com> Reviewed-by: Jian Cheng <cj.chengjian@huawei.com> Signed-off-by: Chen Jun <chenjun102@huawei.com> Signed-off-by: Yu Changchun <yuchangchun1@huawei.com>4 年前
kcsan-test.c
kcsan: test: don't put the expect array on the stack stable inclusion from stable-5.10.166 commit 3b154d5204ff8aa82a2bd4d5ed29a7cf80723706 category: bugfix issue: #I7T0NW CVE: NA Signed-off-by: huzhaodong <huzhaodong@huawei.com> --------------------------------------- [ Upstream commit 5b24ac2dfd3eb3e36f794af3aa7f2828b19035bd ] Size of the 'expect' array in the __report_matches is 1536 bytes, which is exactly the default frame size warning limit of the xtensa architecture. As a result allmodconfig xtensa kernel builds with the gcc that does not support the compiler plugins (which otherwise would push the said warning limit to 2K) fail with the following message: kernel/kcsan/kcsan_test.c:257:1: error: the frame size of 1680 bytes is larger than 1536 bytes Fix it by dynamically allocating the 'expect' array. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> Reviewed-by: Marco Elver <elver@google.com> Tested-by: Marco Elver <elver@google.com> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: huzhaodong <huzhaodong@huawei.com>2 年前
kcsan.h
kcsan, debugfs: Move debugfs file creation out of early init commit e36299efe7d749976fbdaaf756dee6ef32543c2c upstream. Commit 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized") forbids creating new debugfs files until debugfs is fully initialized. This means that KCSAN's debugfs file creation, which happened at the end of __init(), no longer works. And was apparently never supposed to work! However, there is no reason to create KCSAN's debugfs file so early. This commit therefore moves its creation to a late_initcall() callback. Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: stable <stable@vger.kernel.org> Fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized") Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Marco Elver <elver@google.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>5 年前
report.c
panic: Consolidate open-coded panic_on_warn checks stable inclusion from stable-5.10.166 commit 55eba18262cbc289ded9e7a8fe1b61a92140b59a category: bugfix issue: #I7T0NW CVE: NA Signed-off-by: huzhaodong <huzhaodong@huawei.com> --------------------------------------- commit 79cc1ba7badf9e7a12af99695a557e9ce27ee967 upstream. Several run-time checkers (KASAN, UBSAN, KFENCE, KCSAN, sched) roll their own warnings, and each check "panic_on_warn". Consolidate this into a single function so that future instrumentation can be added in a single location. Cc: Marco Elver <elver@google.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Juri Lelli <juri.lelli@redhat.com> Cc: Vincent Guittot <vincent.guittot@linaro.org> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ben Segall <bsegall@google.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Daniel Bristot de Oliveira <bristot@redhat.com> Cc: Valentin Schneider <vschneid@redhat.com> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> Cc: Alexander Potapenko <glider@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Gow <davidgow@google.com> Cc: tangmeng <tangmeng@uniontech.com> Cc: Jann Horn <jannh@google.com> Cc: Shuah Khan <skhan@linuxfoundation.org> Cc: Petr Mladek <pmladek@suse.com> Cc: "Paul E. McKenney" <paulmck@kernel.org> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com> Cc: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: kasan-dev@googlegroups.com Cc: linux-mm@kvack.org Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Marco Elver <elver@google.com> Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com> Link: https://lore.kernel.org/r/20221117234328.594699-4-keescook@chromium.org Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: huzhaodong <huzhaodong@huawei.com>2 年前
selftest.c
kcsan: Use pr_fmt for consistency Use the same pr_fmt throughout for consistency. [ The only exception is report.c, where the format must be kept precisely as-is. ] Signed-off-by: Marco Elver <elver@google.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>5 年前