已合并
[新需求]: 自研MP4性能优化-插件-优化cachequeue,取消map和多余mutex,fix fastinit meta解析问题,264 nalSize解析边界问题 #9356
[新需求]: 自研MP4性能优化-插件-优化cachequeue,取消map和多余mutex,fix fastinit meta解析问题,264 nalSize解析边界问题 #9356
已合并
杨俊晖创建于 6 天前
Pull Request已成功合入, 合并人@openharmony_ci
(感谢 杨俊晖 的贡献)
杨俊晖杨俊晖
6 天前 关联了issue:[新需求]: 自研MP4性能优化-插件-优化cachequeue,取消map和多余mutex,fix fastinit meta解析问题,264 nalSize解析边界问题
openharmony_ciopenharmony_ci成员
6 天前 添加了label:waiting_on_author
openharmony_ci
openharmony_ci成员
6 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
openharmony_ciopenharmony_ci成员
6 天前 添加了label:dco检查成功
杨俊晖
杨俊晖
6 天前 评论:

start build

likedislike
openharmony_ci
openharmony_ci成员
6 天前 评论:

首次触发
门禁构建开始,包含静态检查、代码编译和测试【ohos-host_mini_tdd编译, x86_64_virt编译, dayu200编译, dayu200_tdd编译, dayu600_7885测试, part_compile编译, master_inner_build编译, dayu200测试, dayu600_7885编译】,预计在60分钟内完成,门禁结果会同步发送到注册邮箱。您可以通过如下链接跟踪门禁进展:http://dcp.openharmony.cn/workbench/cicd/detail/6a7e7a6364650f998b642c8e/runlist

likedislike
openharmony_ciopenharmony_ci成员
6 天前 添加了label:编译成功
openharmony_ciopenharmony_ci成员
6 天前 添加了label:静态检查成功
openharmony_ciopenharmony_ci成员
6 天前 添加了label:冒烟测试成功
openharmony_ciopenharmony_ci成员
6 天前 通过测试
openharmony_ci
openharmony_ci成员
6 天前 评论:

代码门禁通过
您可以通过如下链接查看门禁报告:http://dcp.openharmony.cn/workbench/cicd/detail/6a7e7a6364650f998b642c8e/runlist

静态检查:

# check type result report
1 codeCheck pass >>>

编译测试:
# Device build result test result package
1 dayu200 success success >>>
2 dayu200_tdd success NA >>>
3 part_compile success(IGNORE) NA >>>
4 master_inner_build success(IGNORE) NA >>>
5 ohos-host_mini_tdd success NA >>>
6 dayu600_7885 success success >>>
7 x86_64_virt success NA >>>

likedislike
openharmony_ciopenharmony_ci成员
6 天前 删除了label:waiting_on_author
openharmony_ciopenharmony_ci成员
6 天前 添加了label:waiting_for_review
openharmony_ci
openharmony_ci成员
6 天前 评论:

您好,Committer @suruoyan @liuyuehua1 @rchdlee @peng5233 @zhanghongran @acefighteryuan @wmz-hisilicon @dongyu_dy @naplescncn @taihang_208 ,请分配检视人员检视该PR,可以通过命令"assign [@someone_id]"分配检视人员,也可以直接评论"assign"分配给自己进行检视。


Hello, Committer @suruoyan @liuyuehua1 @rchdlee @peng5233 @zhanghongran @acefighteryuan @wmz-hisilicon @dongyu_dy @naplescncn @taihang_208 . Please assign someone to review the PR. You can assign a reviewer by using the command "assign [@someone_id]", or you can comment "assign" to review the PR by yourself.

likedislike
杨俊晖杨俊晖
6 天前 测试状态已重置,测试人: openharmony_ci
杨俊晖杨俊晖
6 天前 推送  2 个提交:2f6afdc6-fix tdd,4bd01fc7-fix webvtt
openharmony_ciopenharmony_ci成员
6 天前 删除了label:编译成功
openharmony_ciopenharmony_ci成员
6 天前 删除了label:静态检查成功
openharmony_ciopenharmony_ci成员
6 天前 删除了label:冒烟测试成功
openharmony_ci
openharmony_ci成员
6 天前 评论:

代码有更新,重置PR验证状态

likedislike
openharmony_ciopenharmony_ci成员
6 天前 删除了label:waiting_for_review
openharmony_ciopenharmony_ci成员
6 天前 添加了label:waiting_on_author
杨俊晖
杨俊晖
6 天前 评论:

start build

likedislike
openharmony_ci
openharmony_ci成员
6 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
openharmony_ci
openharmony_ci成员
6 天前 评论:

本地或库上代码有更新,全量重新构建,重置所有关联PR的验证状态
门禁构建开始,包含静态检查、代码编译和测试【dayu200测试, master_inner_build编译, dayu600_7885测试, part_compile编译, dayu200编译, dayu200_tdd编译, x86_64_virt编译, dayu600_7885编译, ohos-host_mini_tdd编译】,预计在60分钟内完成,门禁结果会同步发送到注册邮箱。您可以通过如下链接跟踪门禁进展:http://dcp.openharmony.cn/workbench/cicd/detail/6a7ed02364650f998b86f184/runlist

likedislike
openharmony_ciopenharmony_ci成员
5 天前 添加了label:编译成功
openharmony_ciopenharmony_ci成员
5 天前 添加了label:静态检查成功
openharmony_ciopenharmony_ci成员
5 天前 添加了label:冒烟测试成功
openharmony_ciopenharmony_ci成员
5 天前 通过测试
openharmony_ci
openharmony_ci成员
5 天前 评论:

代码门禁通过
您可以通过如下链接查看门禁报告:http://dcp.openharmony.cn/workbench/cicd/detail/6a7ed02364650f998b86f184/runlist

静态检查:

# check type result report
1 codeCheck pass >>>

编译测试:
# Device build result test result package
1 dayu200 success success >>>
2 dayu200_tdd success NA >>>
3 part_compile success(IGNORE) NA >>>
4 master_inner_build success(IGNORE) NA >>>
5 ohos-host_mini_tdd success NA >>>
6 dayu600_7885 success success >>>
7 x86_64_virt success NA >>>

likedislike
openharmony_ciopenharmony_ci成员
5 天前 删除了label:waiting_on_author
openharmony_ciopenharmony_ci成员
5 天前 添加了label:waiting_for_review
openharmony_ci
openharmony_ci成员
5 天前 评论:

您好,Committer @suruoyan @liuyuehua1 @rchdlee @peng5233 @zhanghongran @acefighteryuan @wmz-hisilicon @dongyu_dy @naplescncn @taihang_208 ,请分配检视人员检视该PR,可以通过命令"assign [@someone_id]"分配检视人员,也可以直接评论"assign"分配给自己进行检视。


Hello, Committer @suruoyan @liuyuehua1 @rchdlee @peng5233 @zhanghongran @acefighteryuan @wmz-hisilicon @dongyu_dy @naplescncn @taihang_208 . Please assign someone to review the PR. You can assign a reviewer by using the command "assign [@someone_id]", or you can comment "assign" to review the PR by yourself.

likedislike
rchdlee
rchdlee成员5 天前进行代码检视1
services/media_engine/plugins/demuxer/mpeg4_demuxer/mpeg4_demuxer_plugin.cpp
@@ -2553,3 +2635,3 @@
25532635 cacheSample->sampleIndex = sampleIndex;
25542636 }
2555- cacheQueue_.Push(trackId, cacheSample);
2637+ (void)PushTrackCache(trackId, cacheSample);
rchdlee
rchdlee5 天前评论:

(void)PushTrackCache(trackId, cacheSample); 静默丢弃了 Push 失败的返回值。当 track 不存在或 cache 为空(例如某些未走 InitCurrentTrackForTrak/ParseCover 创建缓存的路径)时,sample 会被无声丢弃且无日志。建议至少在失败时 MEDIA_LOG_W 记录 trackId,便于定位丢帧问题。

reviewed by agent

likedislike
rchdlee
rchdlee成员5 天前进行代码检视1
services/media_engine/plugins/demuxer/mpeg4_demuxer/mpeg4_box_parser.cpp
@@ -5287,4 +5288,1 @@
5287- ctx->offset = atomEndOffset;
5288- return Status::OK;
5289- }
52905288 // 使用函数指针查找和调用解析函数
rchdlee
rchdlee5 天前评论:

删除 ShouldParseAtomForFastInit 白名单后,FAST_INIT 模式将解析全部 atom,fastinit 不再“fast”。虽然这能修复 meta 解析遗漏,但属于较粗粒度的改法。建议确认对 fastinit 启动耗时的影响可接受;若影响较大,可改为仅把缺失的 meta 相关 box 加入白名单而非整体移除过滤。

reviewed by agent

likedislike
rchdlee
rchdlee成员5 天前进行代码检视1
services/media_engine/plugins/demuxer/common/avc_parser_impl.cpp
@@ -582,3 +582,3 @@
582582 continue;
583583 }
584- if (nalSize < 0x02 || nalSize > MAX_RBSP_SKIP_BYTES ||
584+ if (nalSize < 0x01 || nalSize > MAX_RBSP_SKIP_BYTES ||
rchdlee
rchdlee5 天前评论:

上方 581 行已对 nalSize == 0 执行 continue,此处 nalSize < 0x01 的下界判断对无符号 nalSize 恒为 false,已成为死代码。本次实际语义变更是允许 nalSize == 1 通过。建议移除冗余的下界比较或改为注释说明意图,避免误导后续维护者。

reviewed by agent

likedislike
rchdleerchdlee成员
5 天前 解决了最后一个问题
rchdleerchdlee成员
5 天前 通过审查
openharmony_ciopenharmony_ci成员
5 天前 关闭了关联的issue
openharmony_ciopenharmony_ci成员
5 天前 合入了pull request,合并节点 SHA:1df1301cb052df16159ce546fbd2cb5ef7223f9a
openharmony_ciopenharmony_ci成员
5 天前 删除了label:waiting_for_review
openharmony_ciopenharmony_ci成员
5 天前 添加了label:merged