已开启
avmemory AshmemGetSize 校验 + Format move 语义与 AnyCast 取值安全化 #2749
avmemory AshmemGetSize 校验 + Format move 语义与 AnyCast 取值安全化 #2749
已开启
lzm创建于 5 天前
lzm
lzm
5 天前

Fixes #1339

变更说明

avmemory 子类补 AshmemGetSize==capacity 校验并改 memFlag 枚举比较;Format 修正 move 语义并对 AnyCast 取值安全化,详见关联 Issue。

改动文件

  • src/buffer/avbuffer/av_hardware_memory.cpp:memFlag 直接以 MemoryFlag 枚举比较,日志保留 uint32 打印。
  • src/buffer/avbuffer/av_shared_memory_ext.cpp:Init() 与 Init(parcel) 增加 AshmemGetSize(fd_)==capacity_ 校验;移除基址 offset_ 二次对齐;memFlag 枚举比较。
  • src/meta/format.cpp:move 构造/赋值改 std::move 并重置 moved-from meta_、清空 formatVecMap_;GetFormatMap/Stringify 改用 GetMetaData 安全取值、AnyCast<vector<uint8_t>> 判空;GetValueType 补 bool/vector<int32_t>/vector<int64_t>。

自测

编译通过。

likedislike
合并受阻
lzmlzm
5 天前 关联了issue:[Bug] avmemory 缺 AshmemGetSize 校验 + Format move 语义错误与 AnyCast 不安全取值
lzm
lzm
5 天前 评论:

start build

likedislike
openharmony_ciopenharmony_ci成员
5 天前 添加了label:waiting_on_author
openharmony_ci
openharmony_ci成员
5 天前 评论:

首次触发
门禁构建开始,包含静态检查、代码编译和测试【hispark_taurus_Linux编译, hispark_taurus_LiteOS编译, dayu200测试, dayu200编译, dayu200_tdd编译, dayu600_7885编译, master_inner_build编译, x86_64_virt编译, dayu600_7885测试, ohos-host_mini_tdd编译, hispark_taurus_LiteOS测试】,预计在60分钟内完成,门禁结果会同步发送到注册邮箱。您可以通过如下链接跟踪门禁进展:http://dcp.openharmony.cn/workbench/cicd/detail/6a8c2d4b64650f998b709b68/runlist

likedislike
openharmony_ci
openharmony_ci成员
5 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
openharmony_ciopenharmony_ci成员
5 天前 添加了label:dco检查成功
openharmony_ciopenharmony_ci成员
5 天前 添加了label:编译成功
lzmlzm
5 天前 推送  1 个提交:00723642-告警修复
lzm
lzm
5 天前 评论:

start build

likedislike
openharmony_ciopenharmony_ci成员
5 天前 删除了label:编译成功
openharmony_ci
openharmony_ci成员
5 天前 评论:

代码有更新,重置PR验证状态

likedislike
openharmony_ci
openharmony_ci成员
5 天前 评论:

本地或库上代码有更新,全量重新构建,重置所有关联PR的验证状态
门禁构建开始,包含静态检查、代码编译和测试【hispark_taurus_LiteOS测试, dayu200编译, hispark_taurus_Linux编译, x86_64_virt编译, ohos-host_mini_tdd编译, dayu600_7885编译, dayu600_7885测试, hispark_taurus_LiteOS编译, dayu200_tdd编译, master_inner_build编译, dayu200测试】,预计在60分钟内完成,门禁结果会同步发送到注册邮箱。您可以通过如下链接跟踪门禁进展:http://dcp.openharmony.cn/workbench/cicd/detail/6a8c3e8164650f998b778eac/runlist

likedislike
openharmony_ci
openharmony_ci成员
5 天前 评论:

监测到PR: https://gitcode.com/openharmony/multimedia_media_foundation/merge_requests/2749 代码有更新,当前正在执行的门禁任务已自动中止,如有需要,可重新触发

likedislike
openharmony_ci
openharmony_ci成员
5 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
openharmony_ciopenharmony_ci成员
5 天前 添加了label:编译成功
openharmony_ciopenharmony_ci成员
5 天前 添加了label:静态检查成功
openharmony_ciopenharmony_ci成员
5 天前 添加了label:冒烟测试成功
openharmony_ciopenharmony_ci成员
5 天前 通过测试
openharmony_ci
openharmony_ci成员
5 天前 评论:

代码门禁通过
您可以通过如下链接查看门禁报告:http://dcp.openharmony.cn/workbench/cicd/detail/6a8c3e8164650f998b778eac/runlist

静态检查:

# check type result report
1 codeCheck pass >>>

编译测试:
# Device build result test result package
1 hispark_taurus_LiteOS success success >>>
2 hispark_taurus_Linux success NA >>>
3 dayu200 success success >>>
4 dayu200_tdd success NA >>>
5 master_inner_build success(IGNORE) NA >>>
6 ohos-host_mini_tdd success NA >>>
7 dayu600_7885 success success >>>
8 x86_64_virt success NA >>>

likedislike
openharmony_ciopenharmony_ci成员
5 天前 删除了label:waiting_on_author
openharmony_ciopenharmony_ci成员
5 天前 添加了label:waiting_for_review
openharmony_ci
openharmony_ci成员
5 天前 评论:

您好,Committer @liuyuehua1 @acefighteryuan @zhang-wanpeng5 ,请分配检视人员检视该PR,可以通过命令"assign [@someone_id]"分配检视人员,也可以直接评论"assign"分配给自己进行检视。


Hello, Committer @liuyuehua1 @acefighteryuan @zhang-wanpeng5 . Please assign someone to review the PR. You can assign a reviewer by using the command "assign [@someone_id]", or you can comment "assign" to review the PR by yourself.

likedislike
lzmlzm
4 天前 测试状态已重置,测试人: openharmony_ci
lzmlzm
4 天前 强制推送  13 个提交:3af54875-10 commits from branch master7b317761-avmemory memFlag enum 比较与 AshmemGetSize 校验,8359e4a6-format move 语义修正与 AnyCast 取值安全化,c442443d-告警修复
openharmony_ciopenharmony_ci成员
4 天前 删除了label:编译成功
openharmony_ciopenharmony_ci成员
4 天前 删除了label:静态检查成功
openharmony_ciopenharmony_ci成员
4 天前 删除了label:冒烟测试成功
openharmony_ci
openharmony_ci成员
4 天前 评论:

代码有更新,重置PR验证状态

likedislike
openharmony_ciopenharmony_ci成员
4 天前 删除了label:waiting_for_review
openharmony_ciopenharmony_ci成员
4 天前 添加了label:waiting_on_author
openharmony_ci
openharmony_ci成员
4 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
lzmlzm
4 天前 推送  1 个提交:339ada85-函数超50行,添加INT64_VECTOR类型
openharmony_ci
openharmony_ci成员
4 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
lzmlzm
3 天前 强制推送  5 个提交:cf2856ff-format: move 语义修正(std::move + rhs 重置),6d20b2d2-format: AnyCast 取值安全化与 GetValueType/ADDR-buffer 加固,33bd9b73-告警修复,5ac17ae9-函数超50行,添加INT64_VECTOR类型,2bd23d80-format: AnyCast 取值补 null-safe 指针兜底(修复 raw-int Any 回归)
openharmony_ci
openharmony_ci成员
3 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
lzmlzm
3 天前 强制推送  1 个提交:09edf07b-format: AnyCast 取值安全化与加固(null-safe 指针兜底 + GetValueType/ADDR-buffer + 重构)
openharmony_ci
openharmony_ci成员
3 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
lzmlzm
3 天前 强制推送  3 个提交:cc7251bc-format: 增加 FORMAT_TYPE_INT64_VECTOR 类型,e650a607-format: Put*/Stringify 重构为 adapter 分发表,574d0080-format: AnyCast 取值安全加固(null-safe 指针兜底)
openharmony_ci
openharmony_ci成员
3 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike
lzmlzm
2 天前 强制推送  2 个提交:9c40490e-format: Put*/Stringify 重构为 adapter 分发表,db70740e-format: AnyCast 取值安全加固(null-safe 指针兜底)
openharmony_ci
openharmony_ci成员
2 天前 评论:

感谢提交 Pull Requests!如果您提交的PR已经开发完毕,请评论 "start build" 触发门禁,更多交互操作,请访问OpenHarmony社区支持命令清单。如果需要调整订阅PR、Issue的变更状态,请访问订阅链接


Thanks for submitting the pull request. If your Pull Request has already been developed, you can leave a "start build" comment to trigger the gated system. For more commands, please visit OpenHarmony Command List. If you need to change the subscription of a Pull Request or Issue, please visit the link.

likedislike