当前Pull Request已关闭, 关闭人@zhaoxiaohu
Welcome To openEuler Community
Hey @Z1142143860Z , thanks for your contribution to the community.
Bot Usage Manual
I'm the Bot here serving you. You can find the instructions on how to interact with me at Here . That means you can comment below every pull request or issue to trigger Bot Commands.
Contact Guide
If you have any questions, please contact the SIG: Base-service ,
and any of the maintainers: @dillon_chen, @licihua, @overweight, @shenyangyang, @zhujianwei001 ,
and any of the committers: @jiayi0118, @licunlong, @protkhn, @shenyangyang, @xujing99, @yue-yuankun .
CLA Signature Guide
@Z1142143860Z , thanks for your pull request.
The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
| Commit | Reason |
|---|---|
| 4057b327 fix(dracut.sh): remove microcode... | the email used in the commit is an invalid email! please check all commits. |
To sign CLA, click here.
To check if your email is configured correctly, refer to the FAQs.
Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.
门禁正在运行， 您可以通过以下链接查看实时门禁检查结果.
若您对门禁结果含义不清晰或者遇到问题不知如何解决，可参考门禁指导手册
门禁入口及编码规范检查: multiarch/src-openeuler/trigger/dracut/22/console
当前仓库存在以下 保护分支 ：
评论 /sync <branch1> <branch2> ... 可将当前 PR 修改同步到其它分支（创建同步 PR）：
a) 如果当前 PR 是 Open 状态，同步操作将延迟到 PR 被合并时执行
b) 如果当前 PR 已经 Merged，将立即执行同步操作
注意：
- /sync 命令可以指定同步到多个分支，仅最后一个 /sync 命令生效
- 如果创建的同步 PR 不正确，可通过向同步 PR 的源分支提交轻量级 PR 完善，或使用 /close 命令关闭
x86_64架构构建及构建后检查：multiarch/src-openeuler/x86-64/dracut/22/console
aarch64架构构建及构建后检查：multiarch/src-openeuler/aarch64/dracut/22/console
| Check Name | Build Result | Build Details | |
|---|---|---|---|
| check_binary_file | ✅SUCCESS | #22 | |
| check_package_yaml_file | ✅SUCCESS | ||
| check_repo_in_maintain | ✅SUCCESS | ||
| check_consistency | ✅SUCCESS | ||
| check_spec_file | ✅SUCCESS | ||
| x86_64 | check_build | ✅SUCCESS | #22 |
| check_install | ✅SUCCESS | ||
| check_license | ✅SUCCESS | ||
| aarch64 | check_build | ✅SUCCESS | #22 |
| check_install | ✅SUCCESS | ||
| check_license | ✅SUCCESS | ||
如下为接口变更检查结果，目标分支为openEuler-22.03-LTS-SP4，请PR提交者check差异信息
| Arch Name | Check Items | Rpm Name | Check Result | Build Details |
|---|---|---|---|---|
| compare_package(x86_64) | add_rpms | ✅SUCCESS | #22 | |
| delete_rpms | ✅SUCCESS | |||
| rpm_cmd | ✅SUCCESS | |||
| rpm_config | ✅SUCCESS | |||
| rpm_files | ✅SUCCESS | |||
| rpm_provides | ✅SUCCESS | |||
| rpm_requires | ✅SUCCESS | |||
| rpm_service | ✅SUCCESS | |||
| rpm_symbol | ✅SUCCESS | |||
| compare_package(aarch64) | add_rpms | ✅SUCCESS | #22 | |
| delete_rpms | ✅SUCCESS | |||
| rpm_cmd | ✅SUCCESS | |||
| rpm_config | ✅SUCCESS | |||
| rpm_files | ✅SUCCESS | |||
| rpm_provides | ✅SUCCESS | |||
| rpm_requires | ✅SUCCESS | |||
| rpm_service | ✅SUCCESS | |||
| rpm_symbol | ✅SUCCESS |
这个改法是不是不太合适，假设某个异常场景内核config有CONFIG_MICROCODE_INTEL没有CONFIG_MICROCODE_AMD ，且$(get_cpu_vendor) == "AMD"，那逻辑就是不对的了。
本质上说这个修改的逻辑破坏了原有语义。如果想兼容高版本内核，还是需要确保原有逻辑不要有变更吧
这个有问题，我之前提的这个已经删除了，重新健的分支，重提的：
if [[ $early_microcode == yes ]]; then
if [[ $hostonly ]]; then
if [[ $(get_cpu_vendor) == "AMD" ]]; then
- check_kernel_config CONFIG_MICROCODE_AMD || unset early_microcode
+ # 6.x kernels use CONFIG_MICROCODE, 5.x kernels use CONFIG_MICROCODE_AMD
+ check_kernel_config CONFIG_MICROCODE_AMD || check_kernel_config CONFIG_MICROCODE || unset early_microcode
elif [[ $(get_cpu_vendor) == "Intel" ]]; then
- check_kernel_config CONFIG_MICROCODE_INTEL || unset early_microcode
+ # 6.x kernels use CONFIG_MICROCODE, 5.x kernels use CONFIG_MICROCODE_INTEL
+ check_kernel_config CONFIG_MICROCODE_INTEL || check_kernel_config CONFIG_MICROCODE || unset early_microcode
else
unset early_microcode
fi
else
! check_kernel_config CONFIG_MICROCODE_AMD \
&& ! check_kernel_config CONFIG_MICROCODE_INTEL \
+ && ! check_kernel_config CONFIG_MICROCODE \
&& unset early_microcode
fi
# Do not complain on non-x86 architectures as it makes no sense
case $(uname -m) in
x86_64 | i?86)
[[ $early_microcode != yes ]] \
- && dwarn "Disabling early microcode, because kernel does not support it. CONFIG_MICROCODE_[AMD|INTEL]!=y"
+ && dwarn "Disabling early microcode, because kernel does not support it. [5.x kernels]CONFIG_MICROCODE_[AMD|INTEL]!=y or [6.x kernels]"
;;
另外可以关联下issue，以及需要使用cla认证过的邮箱进行pr提交
zhaoxiaohu代码是 pull/184 的代码，不是重新提的185 的逻辑（重新建了相同分支名，不知道是不是这个原因）。需要关闭重新提交
fix(dracut.sh): remove microcode check based on CONFIG_MICROCODE_[AMD|INTEL]