From 8fc521393e13dd1a55afc9859a20c76e80e6bc9d Mon Sep 17 00:00:00 2001
From: Mike Yuan <me@yhndnzj.com>
Date: Wed, 19 Jun 2024 21:28:05 +0200
Subject: [PATCH 0770/1160] test-install-root: introduce test case for #33411

(cherry picked from commit 9fb5a8ca24e677e10f8c2b8973b5e2a11676bda0)
(cherry picked from commit 7684f528392ddb94455c924ec820be2c8de6989a)
---
 src/test/test-install-root.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/src/test/test-install-root.c b/src/test/test-install-root.c
index efd75b2a67..2a6d94ba42 100644
--- a/src/test/test-install-root.c
+++ b/src/test/test-install-root.c
@@ -29,6 +29,8 @@ TEST(basic_mask_and_enable) {
         assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "d.service", NULL) == -ENOENT);
         assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "e.service", NULL) == -ENOENT);
         assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "f.service", NULL) == -ENOENT);
+        assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "g.service", NULL) == -ENOENT);
+        assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "h.service", NULL) == -ENOENT);
 
         p = strjoina(root, "/usr/lib/systemd/system/a.service");
         assert_se(write_string_file(p,
@@ -197,6 +199,24 @@ TEST(basic_mask_and_enable) {
         changes = NULL; n_changes = 0;
 
         assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "f.service", &state) >= 0 && state == UNIT_FILE_ENABLED);
+
+        /* Test enabling units with only Alias= (unit_file_enable should return > 0 to indicate we did
+         * something, #33411) */
+
+        p = strjoina(root, SYSTEM_CONFIG_UNIT_DIR "/g.service");
+        assert_se(write_string_file(p,
+                                    "[Install]\n"
+                                    "Alias=h.service\n", WRITE_STRING_FILE_CREATE) >= 0);
+
+        assert_se(unit_file_enable(RUNTIME_SCOPE_SYSTEM, 0, root, STRV_MAKE("g.service"), &changes, &n_changes) >= 0);
+        install_changes_free(changes, n_changes);
+        changes = NULL; n_changes = 0;
+
+        assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "g.service", &state) >= 0);
+        assert_se(state == UNIT_FILE_ENABLED);
+
+        assert_se(unit_file_get_state(RUNTIME_SCOPE_SYSTEM, root, "h.service", &state) >= 0);
+        assert_se(state == UNIT_FILE_ALIAS);
 }
 
 TEST(linked_units) {
-- 
2.33.0