| fix: hide dashboard result preview for unsupported queries (Flotilla) (#6557) ## Summary The results preview tab was added to the dashboard in #6327 but only supports Swordfish queries since Flotilla never calls on_result_out. This hides the tab for Flotilla queries (rather than misleadingly displaying a disabled tab which will never become enabled) until we add support for them (follow-up: #6559). Note: for a while running Flotilla queries would actually panic the dashboard server process in RecordBatch::from_ipc_stream, but this was coincidentally fixed on main by #6541. This PR addresses the remaining issues: avoiding the empty serialization in the first place, and hiding the broken UI. ## Test plan - [x] cargo check passes for daft-context, daft-dashboard - [x] tsc --noEmit passes for dashboard frontend - [x] Manual: run a Flotilla query and verify dashboard doesn't panic, Results tab is hidden - [x] Manual: run a Swordfish query and verify Results tab still works --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> | 6 个月前 |
| feat(dashboard): add query result preview tab (#6327) ## Summary - Adds a **Results** tab to the query detail page that displays a preview of the query's output as an HTML table - New REST endpoint GET /client/query/{id}/results returns repr_html() + row count for finished queries - Fixes a pre-existing bug where the operator_info SSE handler hardcoded status: "Executing", resetting terminal states (Finished/Finalizing) back to Executing Stacked on #6326. ## Test plan - [x] Run a query via the dashboard, verify the Results tab activates once the query finishes - [x] Click the Results tab and confirm the HTML table renders with correct data - [x] Verify column headers and cell values with special characters (e.g. <, >, &) are properly escaped (no XSS — repr_html uses html_escape::encode_text) - [x] Confirm the tab stays disabled while the query is still executing 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> | 7 个月前 |
| feat(dashboard): Individual Query Page (#5367) | 1 年前 |
| chore(dashboard): add README with build and architecture notes (#6323) ## Summary - Adds a README.md to src/daft-dashboard/ documenting the non-obvious build requirement: the frontend is statically embedded in the Rust binary via include_dir!, so **any frontend change requires make build**. - Includes a brief architecture overview (backend, frontend, state). ## Test plan - [x] Verify README renders correctly on GitHub 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> | 7 个月前 |
| chore: Replace Bun with Node / NPM (#6202) ## Changes Made I've been seeing a lot of issues with Bun interop recently, especially with Next.js (https://github.com/vercel/next.js/issues/85234). But in general, a lot of times when there is a problem with Bun, we have to bump the min version, which causes at lot of turmoil for OSS developers. IMO, there's not much benefit to using Bun in our use case, so we should just use Node / NPM instead for stability. I chose Node 22 LTS cause: 1) Had a small problem with Node 20. I think I can bump the version back down to 20 if you want, but 2) Node 20 will EOL in April this year, Node 22 has till next year 3) Can also do Node 24 if wanted, but 22 is still pretty common | 8 个月前 |