| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
feat: migrate first batch of daft functions (#5086) ## Changes Made First phase of our daft.functions migration + Expression namespacing deprecation! These changes should all be uncontroversial, and all of [the comments about them](https://www.notion.so/Expressions-Migration-Tasks-246091bd8634806a8f24eb573d8d3b3e?source=copy_link) have been resolved. Thus, I'm hoping that the reviews for this PR will be a little easier since they should only need to focus on the structural changes rather than the naming ones. I'm leaving the ones with unresolved discussions for future PRs, but this covers something like 95% of expressions. In addition, since the existing tests call the expression methods, which in turn call daft.functions, passing those tests should indicate both that the new functions work and that the existing methods have not been broken. All of the functions are straightforward Python-only changes except for two: - daft.functions.length has to work on binary, string, as well as list types. prior to that they were three separate functions, so I had to write a new scalar function on the Rust side - similarly, daft.functions.concat works for both string and binary, whereas the original functions were separate. I implemented this one by implementing Expression.__add__ between two binary expressions, and then just used the add implementation in the new concat scalar function ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes #123" --> ## Checklist - [x] Documented in API Docs (if applicable) - [x] Documented in User Guide (if applicable) - [x] If adding a new documentation page, doc is added to docs/mkdocs.yml navigation - [x] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review) --------- Co-authored-by: Srinivas Lade <srinulade1@gmail.com> | 1 年前 | |
feat: migrate first batch of daft functions (#5086) ## Changes Made First phase of our daft.functions migration + Expression namespacing deprecation! These changes should all be uncontroversial, and all of [the comments about them](https://www.notion.so/Expressions-Migration-Tasks-246091bd8634806a8f24eb573d8d3b3e?source=copy_link) have been resolved. Thus, I'm hoping that the reviews for this PR will be a little easier since they should only need to focus on the structural changes rather than the naming ones. I'm leaving the ones with unresolved discussions for future PRs, but this covers something like 95% of expressions. In addition, since the existing tests call the expression methods, which in turn call daft.functions, passing those tests should indicate both that the new functions work and that the existing methods have not been broken. All of the functions are straightforward Python-only changes except for two: - daft.functions.length has to work on binary, string, as well as list types. prior to that they were three separate functions, so I had to write a new scalar function on the Rust side - similarly, daft.functions.concat works for both string and binary, whereas the original functions were separate. I implemented this one by implementing Expression.__add__ between two binary expressions, and then just used the add implementation in the new concat scalar function ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes #123" --> ## Checklist - [x] Documented in API Docs (if applicable) - [x] Documented in User Guide (if applicable) - [x] If adding a new documentation page, doc is added to docs/mkdocs.yml navigation - [x] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review) --------- Co-authored-by: Srinivas Lade <srinulade1@gmail.com> | 1 年前 | |
docs: Generate files for llms.txt (#4937) ## Changes Made For each markdown page, generate a .txt equivalent for our llms.txt | 1 年前 | |
docs: Generate files for llms.txt (#4937) ## Changes Made For each markdown page, generate a .txt equivalent for our llms.txt | 1 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 1 年前 | ||
| 1 年前 | ||
| 1 年前 | ||
| 1 年前 |