已合并
fix(hccl): rename HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET to HCCL_COMM_QOS_CONFIG_NOT_SET #33141
wuyouqi1创建于 4月3日
fix(hccl): rename HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET to HCCL_COMM_QOS_CONFIG_NOT_SET #33141
已合并
wuyouqi1创建于 4月3日
2 个文件变更+2-2
@@ -446,7 +446,7 @@ inline void HcclCommConfigInit(HcclCommConfig *config)
446 config->hcclRetryEnable[0] = '\0';446 config->hcclRetryEnable[0] = '\0';
447 config->hcclRetryParams[0] = '\0';447 config->hcclRetryParams[0] = '\0';
448 config->hcclBufferName[0] = '\0';448 config->hcclBufferName[0] = '\0';
449- config->hcclQos = HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET;449+ config->hcclQos = HCCL_COMM_QOS_CONFIG_NOT_SET;
450}450}
451 451 
452/**452/**
@@ -127,7 +127,7 @@ const uint32_t HCCL_COMM_DEFAULT_OP_EXPANSION_MODE = 0;
127const uint32_t HCCL_COMM_TRAFFIC_CLASS_CONFIG_NOT_SET = 0xffffffff;127const uint32_t HCCL_COMM_TRAFFIC_CLASS_CONFIG_NOT_SET = 0xffffffff;
128const uint32_t HCCL_COMM_SERVICE_LEVEL_CONFIG_NOT_SET = 0xffffffff;128const uint32_t HCCL_COMM_SERVICE_LEVEL_CONFIG_NOT_SET = 0xffffffff;
129const int32_t HCCL_COMM_EXECTIMEOUT_CONFIG_NOT_SET = 0xffffffff;129const int32_t HCCL_COMM_EXECTIMEOUT_CONFIG_NOT_SET = 0xffffffff;
130-const uint32_t HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET = 0xffffffff;130+const uint32_t HCCL_COMM_QOS_CONFIG_NOT_SET = 0xffffffff;
ascend-robot
ascend-robotascend-robot4月3日
命名规范/拼写错误: 第130行将常量名从'HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET'修改为'HCCL_COMM_QOS_CONFIG_NOT_SET',移除了冗余的'HCCL_'前缀。这个修改是正确的,因为它与上下文中其他类似常量的命名模式保持一致(例如HCCL_COMM_TRAFFIC_CLASS_CONFIG_NOT_SET、HCCL_COMM_SERVICE_LEVEL_CONFIG_NOT_SET)。然而,需要检查代码库中所有引用旧常量名的地方是否都已相应更新,以避免编译错误或逻辑错误。
问题类型: 命名规范/拼写错误
文件路径: third_party/hccl/inc/hccl/hccl_types.h
行号: 130
问题代码:
const uint32_t HCCL_COMM_QOS_CONFIG_NOT_SET = 0xffffffff;
修改建议:
1. 确认本次修改是重命名而非新增常量。2. 在代码库中全局搜索'HCCL_COMM_HCCL_QOS_CONFIG_NOT_SET',确保所有引用点都已更新为新的常量名'HCCL_COMM_QOS_CONFIG_NOT_SET'。3. 检查是否有头文件包含顺序或条件编译可能导致某些编译单元看到不同的定义。
---
此评论由代码审查工具自动生成
likedislike
wuyouqi1
wuyouqi1
4月8日 评论:
131 131 
132typedef struct HcclCommConfigDef {132typedef struct HcclCommConfigDef {
133 char reserved[HCCL_COMM_CONFIG_INFO_BYTES];133 char reserved[HCCL_COMM_CONFIG_INFO_BYTES];