Closed
[Documentation|文档反馈]: 修复 confusion_transpose_d 失效 TODO 注释与头文件保护宏注释不一致 #3806
TangPCAdd on 22 days agoClosed at 22 days ago
22 days ago Added label: documentation
TangPC
22 days ago Comments:
22 days ago Comments:
/assign @pingchuantang


22 days ago Assign pingchuantang as responsible person
22 days ago Close issue
22 days ago Added label: resolved
一、文档链接 (必填)
二、问题文档片段 (必填)
conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp第 14 行:// 修复前 //todo:这些头文件都没有啊 #include "log/log.h" #include "op_common/op_host/util/shape_util.h" #include "register/op_impl_registry.h" #include "op_common/op_host/infershape_broadcast_util.h" // 修复后 #include "log/log.h" #include "op_common/op_host/util/shape_util.h" #include "register/op_impl_registry.h" #include "op_common/op_host/infershape_broadcast_util.h"conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h第 83 行:// 修复前 #endif // CONFUSION_TRANSPOSE_D_TILING_H_ // 修复后 #endif // CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_💡 存在的问题(选填)
confusion_transpose_d_graph_infer.cpp中“这些头文件都没有啊”的 TODO 已失效,上述头文件均为正常编译依赖,保留该注释会误导后续维护者;同时该文件的函数左花括号位置与仓内代码风格不一致、namespace ops闭合写法为};、文件末尾缺少换行,已一并修正。confusion_transpose_d_tiling_arch35.h的#endif注释仍引用旧头文件保护宏名CONFUSION_TRANSPOSE_D_TILING_H_,与实际宏CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_不一致。修复方式:
confusion_transpose_d_graph_infer.cpp:删除失效 TODO,调整函数与命名空间格式,补齐文件末尾换行confusion_transpose_d_tiling_arch35.h:#endif注释更正为CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_关联 PR:https://gitcode.com/cann/ops-math/pull/6497