0
代码
代码
Issues
Pull Requests
讨论
Wiki
分析
0
CCommit BotReformat GN files.
ccbe95fd创建于 2020年1月21日历史提交
文件最后提交记录最后更新时间
all_build_files
Update check_package_boundaries. Before reformatting GN files (see [1] for why this is needed), the presubmit check to ensure targets are not violating package boundaries needs to be fixed because its regular expressions don't always work with the new format. This CL removes the parsing of line numbers to relax the regular expressions without losing any functionality. Error before this CL: *************** <PATH>/webrtc/src/BUILD.gn:674 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:675 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:676 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:677 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn:678 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** Error after this CL: *************** <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Ia39387d089a0c56a2c3ad9a7264c20eb5a38ac93 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166535 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30331} 6 年前
circular_dependency
Reformat GN files. gn format recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334} 6 年前
common_prefix
Reformat GN files. gn format recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334} 6 年前
dangerous_filename
Reformat GN files. gn format recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334} 6 年前
multiple_errors_multiple_targets
Update check_package_boundaries. Before reformatting GN files (see [1] for why this is needed), the presubmit check to ensure targets are not violating package boundaries needs to be fixed because its regular expressions don't always work with the new format. This CL removes the parsing of line numbers to relax the regular expressions without losing any functionality. Error before this CL: *************** <PATH>/webrtc/src/BUILD.gn:674 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:675 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:676 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:677 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn:678 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** Error after this CL: *************** <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Ia39387d089a0c56a2c3ad9a7264c20eb5a38ac93 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166535 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30331} 6 年前
multiple_errors_single_target
Update check_package_boundaries. Before reformatting GN files (see [1] for why this is needed), the presubmit check to ensure targets are not violating package boundaries needs to be fixed because its regular expressions don't always work with the new format. This CL removes the parsing of line numbers to relax the regular expressions without losing any functionality. Error before this CL: *************** <PATH>/webrtc/src/BUILD.gn:674 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:675 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:676 in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn:677 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn:678 in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** Error after this CL: *************** <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java' crosses boundary of package 'examples'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java' crosses boundary of package 'sdk'. <PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests': Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java' crosses boundary of package 'sdk'. *************** [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Ia39387d089a0c56a2c3ad9a7264c20eb5a38ac93 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166535 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30331} 6 年前
no_errors
Reformat GN files. gn format recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334} 6 年前