ccbe95fd创建于 2020年1月21日历史提交
文件最后提交记录最后更新时间
Add gn check presubmit This runs gn gen --check with default args to detect mismatches between #includes and dependencies in the BUILD.gn files, as well as general build errors. Run this before uploading a CL for early detection, otherwise such errors will cause per-platform try jobs to fail. Bug: webrtc:8279 Change-Id: Ib87e2e3f40b8d1146ea5c1202fb113508a3f05e3 Reviewed-on: https://webrtc-review.googlesource.com/5482 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20208}8 年前
Reformat GN files. gn format recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334} 6 年前
Add gn check presubmit This runs gn gen --check with default args to detect mismatches between #includes and dependencies in the BUILD.gn files, as well as general build errors. Run this before uploading a CL for early detection, otherwise such errors will cause per-platform try jobs to fail. Bug: webrtc:8279 Change-Id: Ib87e2e3f40b8d1146ea5c1202fb113508a3f05e3 Reviewed-on: https://webrtc-review.googlesource.com/5482 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20208}8 年前