main

TTom Stellard[libc++] Simplify how we define the linker script for libc++

b8f8e453创建于 2022年8月5日历史提交

文件	最后提交记录	最后更新时间
Modules	[libc++] Simplify how we define the linker script for libc++ Trying to be generic didn't work properly because we had to special-case some interface libraries that we didn't want in the linker script. Instead, only look at the ABI and the unwinding libraries explicitly. This should solve the issue reported by @dim in [1]. [1]: https://discourse.llvm.org/t/15-0-0-rc1-has-been-tagged/64174/22 Differential Revision: https://reviews.llvm.org/D131037 (cherry picked from commit b7fb8563974d83f9eb8191fdfbebfd04147a2cbd)	3 年前
caches	[libc++] Drop the legacy debug mode symbols by default Leave the escape hatch in place with a note, but don't include the debug mode symbols by default since we don't support the debug mode in the normal library anymore. This is technically an ABI break for users who were depending on those debug mode symbols in the dylib, however those users will already be broken at compile-time because they must have been using _LIBCPP_DEBUG=2, which is now an error. Differential Revision: https://reviews.llvm.org/D127360	3 年前
config-ix.cmake	[runtimes] [cmake] Fix -Werror detection in common build configs We add --unwindlib=none to CMAKE_REQUIRED_FLAGS to make sure that builds with a yet-incomplete toolchain succeed, to avoid linker failures about missing unwindlib. When this option is added to CMAKE_REQUIRED_FLAGS, it gets added to both compile and link commands in CMake compile tests. If --unwindlib=none is included in compilation commands, it causes warnings about unused arguments, as the flag only is relevant for linking. Due to the warnings in CMake tests, the later CMake test for the -Werror option failed (as the tested -Werror option caused the preexisting warning due to unused --unwindlib=none to become a hard error). Therefore, most CI configurations that build with LIBCXX_ENABLE_WERROR didn't actually end up enabling -Werror after all. When looking at the CI build log of recent CI builds, they do end up printing: -- Performing Test LIBCXX_SUPPORTS_WERROR_FLAG -- Performing Test LIBCXX_SUPPORTS_WERROR_FLAG - Failed -- Performing Test LIBCXX_SUPPORTS_WX_FLAG -- Performing Test LIBCXX_SUPPORTS_WX_FLAG - Failed Thus while the configurations are meant to error out on warnings, they actually haven't done that, due to the interaction of these options. To fix this, remove the individual cases of adding --unwindlib=none into CMAKE_REQUIRED_FLAGS in libcxx and libunwind. runtimes/CMakeLists.txt still adds --unwindlib=none if needed, but not otherwise. (The same issue with enabling -Werror does remain if --unwindlib=none strictly is needed though - that can be fixed separately afterwards.) These individual cases in libunwind and libcxx were added while standalone builds of the runtimes still were supported - but no longer are necessary now. Differential Revision: https://reviews.llvm.org/D124375	4 年前