MMark de Wever[libc++] Don't use static constexpr in headers.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[libc++] Move everything related solely to _LIBCPP_ASSERT to its own file This is the first step towards disentangling the debug mode and assertions in libc++. This patch doesn't make any functional change: it simply moves _LIBCPP_ASSERT-related stuff to its own file so as to make it clear that libc++ assertions and the debug mode are different things. Future patches will make it possible to enable assertions without enabling the debug mode. Differential Revision: https://reviews.llvm.org/D119769 | 4 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 | |
[libc++] Move everything related solely to _LIBCPP_ASSERT to its own file This is the first step towards disentangling the debug mode and assertions in libc++. This patch doesn't make any functional change: it simply moves _LIBCPP_ASSERT-related stuff to its own file so as to make it clear that libc++ assertions and the debug mode are different things. Future patches will make it possible to enable assertions without enabling the debug mode. Differential Revision: https://reviews.llvm.org/D119769 | 4 年前 | |
[libc++] Don't use static constexpr in headers. This was noticed in the review of D125704. In that commit only the new table has been adapted. This adapts the existing tables. Note since libc++'s charconv is backported to C++11 it's not possible to use inline constexpr variables. The were introduced in C++17. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D126887 | 3 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 | |
[libc++] Replace #include "" with <> in libcxx/src/. NFCI. Our best guess is that the two syntaxes should have exactly equivalent effects, so, let's be consistent with what we do in libcxx/include/. I've left #include "include/x.h" and #include "../y.h" alone because I'm less sure that they're interchangeable, and they aren't inconsistent with libcxx/include/ because libcxx/include/ never does that kind of thing. Also, use the _LIBCPP_PUSH_MACROS/POP_MACROS dance for <__undef_macros>, even though it's technically unnecessary in a standalone .cpp file, just so we have consistently one way to do it. Differential Revision: https://reviews.llvm.org/D119561 | 4 年前 |