MMed Ismail Bennani[lldb/crashlog] Show help when the command is called without any argument
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Python 2/3 compat: StringIO Differential Revision: https://reviews.llvm.org/D59582 llvm-svn: 356910 | 7 年前 | |
[lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom Update examples and docs to demonstrate using __lldb_init_module instead of the idiom that checks for lldb.debugger at the top-level. if __name__ == '__main__': ... elif lldb.debugger: ... Is replaced with: if __name__ == '__main__': ... def __lldb_init_module(debugger, internal_dict): ... This change is for two reasons. First, it's generally encouraged not to only use the convenience singletons (lldb.{debugger,process,target,etc}) interactively from the script command. Second, there's a bug where registering a python class as a command (using command script add -c ...), result in the command not being runnable. Note that registering function-backed commands does not have this bug. Differential Revision: https://reviews.llvm.org/D117237 | 4 年前 | |
[NFC] Remove ASCII lines from comments A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135 | 7 年前 | |
[lldb] NFC remove DISALLOW_COPY_AND_ASSIGN Summary: This is how I applied my clang-tidy check (see https://reviews.llvm.org/D80531) in order to remove DISALLOW_COPY_AND_ASSIGN and have deleted copy ctors and deleted assignment operators instead. lang=bash grep DISALLOW_COPY_AND_ASSIGN /opt/notnfs/kkleine/llvm/lldb -r -l | sort | uniq > files for i in $(cat files); do clang-tidy \ --checks="-*,modernize-replace-disallow-copy-and-assign-macro" \ --format-style=LLVM \ --header-filter=.* \ --fix \ -fix-errors \ $i; done Reviewers: espindola, labath, aprantl, teemperor Reviewed By: labath, aprantl, teemperor Subscribers: teemperor, aprantl, labath, emaste, sbc100, aheejin, MaskRay, arphaman, usaxena95, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D80543 | 5 年前 | |
[NFC] Remove ASCII lines from comments A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135 | 7 年前 | |
Update the file headers across all of the LLVM projects in the monorepo to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636 | 7 年前 | |
[lldb/crashlog] Show help when the command is called without any argument This patch changes the crashlog command behavior to print the help message if no argument was provided with the command. rdar://94576026 Differential Revision: https://reviews.llvm.org/D127362 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com> | 3 年前 | |
Python 2/3 compatibility: from __future__ import print_function Differential Revision: https://reviews.llvm.org/D59580 llvm-svn: 356695 | 7 年前 | |
Python 2/3 compat: str vs basestring Differential Revision: https://reviews.llvm.org/D59589 llvm-svn: 356908 | 7 年前 | |
[LLDB][NFC] Fix a typo in comment fix typo in comment: libcstd++ -> libstdc++ Reviewed By: wallace Differential Revision: https://reviews.llvm.org/D117288 | 4 年前 | |
[lldb] Remove LLDB session dir and just store test traces in the respective test build directory Test runs log some of their output to files inside the LLDB session dir. This session dir is shared between all tests, so all the tests have to make sure they choose a unique file name inside that directory. We currently choose by default <test-class-name>-<test-method-name> as the log file name. However, that means that if not every test class in the test suite has a unique class name, then we end up with a race condition as two tests will try to write to the same log file. I already tried in D83767 changing the format to use the test file basename instead (which we already require to be unique for some other functionality), but it seems the code for getting the basename didn't work on Windows. This patch instead just changes that dotest stores the log files in the build directory for the current test. We know that directory is unique for this test, so no need to generate some unique file name now. Also removes all the environment vars and parameters related to the now unused session dir. The new log paths now look like this for a failure in 'TestCppOperators: ./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_dwarf/Failure.log ./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_dsym/Failure.log ./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_gmodules/Failure.log ` Reviewed By: labath Differential Revision: https://reviews.llvm.org/D92498 | 5 年前 |