| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[mlir][pdl] Make pdl the default dialect when parsing/printing PDLDialect being a somewhat user-facing dialect and whose ops contain exclusively other PDL ops in their regions can take advantage of OpAsmOpInterface to provide nicer IR. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D117828 | 4 年前 | |
Switch generatedTypeParser/generatedAttributeParser to return an OptionalParseResult This allows the caller to distinguish between a parse error or an unmatched keyword. It fixes the redundant error that was emitted by the caller when the generated parser would fail. Differential Revision: https://reviews.llvm.org/D98162 | 5 年前 | |
[mlir:PDL] Rework errors for pdl.operations with non-inferrable results We currently emit an error during verification if a pdl.operation with non-inferrable results is used within a rewrite. This allows for catching some errors during compile time, but is slightly broken. For one, the verification at the PDL level assumes that all dialects have been loaded, which is true at run time, but may not be true when the PDL is generated (such as via PDLL). This commit fixes this by not emitting the error if the operation isn't registered, i.e. it uses the mightHave variant of trait/interface methods. Secondly, we currently don't verify when a pdl.operation has no explicit results, but the operation being created is known to expect at least one. This commit adds a heuristic error to detect these cases when possible and fail. We can't always capture when the user made an error, but we can capture the most common case where the user expected an operation to infer its result types (when it actually isn't possible). Differential Revision: https://reviews.llvm.org/D124583 | 4 年前 | |
[mlir:PDL] Fix a syntax ambiguity in pdl.attribute pdl.attribute currently has a syntax ambiguity that leads to the incorrect parsing of pdl.attribute operations with locations that don't also have a constant value. For example: pdl.attribute loc("foo") The above IR is treated as being a pdl.attribute with a constant value containing the location, loc("foo"), which is incorrect. This commit changes the syntax to use = <constant-value> to clearly distinguish when the constant value is present, as opposed to just trying to parse an attribute. Differential Revision: https://reviews.llvm.org/D124582 | 4 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 4 年前 | ||
| 5 年前 | ||
| 4 年前 | ||
| 4 年前 |