Enable the 'Other' remediation group checkbox in completed review reports. Clicking the group checkbox now toggles all selectable ungrouped remediation items, while completed items remain excluded. Add regression coverage for partial selection, select-all, deselection, and completed-item filtering.
Type and Areas
Type: Bug fix, regression fix, UI/UX, test
Areas: Web UI, Deep Review action bar, remediation selection
Motivation / Impact
The completed review report rendered the 'Other' group checkbox, but its handler returned before reaching the selection store for the ungrouped group. Clicking the checkbox therefore had no effect, forcing users to select items one by one.
Route the ungrouped group through the existing toggleGroupRemediation logic and widen the callback types to include that supported group id. Existing protections continue to prevent completed items from being selected.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/btw/DeepReviewActionBar.test.tsx src/flow_chat/store/deepReviewActionBarStore.test.ts src/flow_chat/deep-review/action-bar/RemediationSelectionPanel.test.tsx - passed (47 tests) on the main and release/1.0.6-based branches.
pnpm run type-check:web - passed during the HarmonyOS frontend build after generated API types were created.
git diff --check - passed on both rebased branches.
HarmonyOS unsigned HAP build from the fix worktree - passed; ZIP integrity, bundled mobile Web UI, AArch64 native library, and native provenance checks passed.
Reviewer Notes
PR #160 targets GitCode OpenHarmonyPCDeveloper/BitFun:release/1.0.6; PR #161 targets OpenHarmonyPCDeveloper/BitFun:main. Each branch was fetched and rebased before publishing.
No backend, protocol, or persisted-data shape changes; the fix uses the existing remediation selection store.
Validation was local-only. No HarmonyOS device/WebView replay, remote workspace, remote control, Peer Device Mode, or Detached Dispatch scenario was exercised end to end.
Summary
Fixes OpenBitFun/bitfun_ade#163.
Enable the 'Other' remediation group checkbox in completed review reports. Clicking the group checkbox now toggles all selectable ungrouped remediation items, while completed items remain excluded. Add regression coverage for partial selection, select-all, deselection, and completed-item filtering.
Type and Areas
Type: Bug fix, regression fix, UI/UX, test
Areas: Web UI, Deep Review action bar, remediation selection
Motivation / Impact
The completed review report rendered the 'Other' group checkbox, but its handler returned before reaching the selection store for the ungrouped group. Clicking the checkbox therefore had no effect, forcing users to select items one by one.
Route the
ungroupedgroup through the existingtoggleGroupRemediationlogic and widen the callback types to include that supported group id. Existing protections continue to prevent completed items from being selected.Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/btw/DeepReviewActionBar.test.tsx src/flow_chat/store/deepReviewActionBarStore.test.ts src/flow_chat/deep-review/action-bar/RemediationSelectionPanel.test.tsx- passed (47 tests) on the main and release/1.0.6-based branches.pnpm run type-check:web- passed during the HarmonyOS frontend build after generated API types were created.git diff --check- passed on both rebased branches.Reviewer Notes
OpenHarmonyPCDeveloper/BitFun:release/1.0.6; PR #161 targetsOpenHarmonyPCDeveloper/BitFun:main. Each branch was fetched and rebased before publishing.Checklist