main

GGitHubfix(drivers/device): make I2C::init() idempotent (#27352)

be3f6e22创建于 5月18日历史提交

文件	最后提交记录	最后更新时间
accelerometer	remove clip_limit contraint on INT16_MAX	2 年前
device	fix(drivers/device): make I2C::init() idempotent (#27352) A successful I2C::init() attaches to the bus (per-platform: NuttX i2c_master_s* via px4_i2cbus_initialize, POSIX /dev/i2c-N fd via ::open, QuRT bus fd via _config_i2c_bus). Only the destructor releases it. The init() implementations on all three platforms unconditionally re-attached on every call, so any driver that called init() more than once on the same instance leaked: - NuttX: kmm_malloc() of a fresh i2c_master_s inst, plus an unbalanced increment of the per-port refcount in stm32_i2cbus_initialize() (and the equivalent across other arch ports). The previous inst pointer was overwritten and the matching uninitialize() never ran, so the bus refcount could not reach zero on destruct. - POSIX/QuRT: file descriptor leak (re-open without close). The pattern that triggers this is "init() retried on failure," used in keep_running mode and in drivers like INA228 whose RunImpl re-enters init() whenever a later step (e.g. a register write) failed. Drivers that init() exactly once from instantiate() were unaffected. Mirror what SPI::init() (nuttx/SPI.cpp) already does for its bus-bind step and short-circuit on second-and-later calls. Re-running probe() and CDev::init() on an already-attached device was also avoided here because the existing cleanup path on probe failure would tear down the preserved _dev that earlier callers still depended on. Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>	5 个月前
gyroscope	UAVCAN: Add device tracking and information publishing (#25617) * uavcan: collect node info and publish every second * UORB: Add DeviceInformation Message Format DeviceInformation.msg with standard comment spaces * SENS: add getter for device_id * UAVCAN: add publishing of DeviceInformation based on publised message type, and Node Information * LOG: add deviceInformation * MSG:BAT: fix comment to be inline with the max_instaces * UAVCAN: DeviceInformation, incorporated feedback * UAVCAN: DeviceInformation, incorporated feedback * UAVCAN: DeviceInformation, Fixed bug with Powermonitor --------- Co-authored-by: Beat Küng <beat-kueng@gmx.net>	10 个月前
led	Remove include <log.h> from defines.h The reason for this is that log.h includes drv_hrt.h which sucks in half the project's include files with it, which causes strange build issues	4 年前
magnetometer	UAVCAN: Add device tracking and information publishing (#25617) * uavcan: collect node info and publish every second * UORB: Add DeviceInformation Message Format DeviceInformation.msg with standard comment spaces * SENS: add getter for device_id * UAVCAN: add publishing of DeviceInformation based on publised message type, and Node Information * LOG: add deviceInformation * MSG:BAT: fix comment to be inline with the max_instaces * UAVCAN: DeviceInformation, incorporated feedback * UAVCAN: DeviceInformation, incorporated feedback * UAVCAN: DeviceInformation, Fixed bug with Powermonitor --------- Co-authored-by: Beat Küng <beat-kueng@gmx.net>	10 个月前
mcp_common	fix: use correct address passed with -a flag	8 个月前
rangefinder	rangefinder: remove unused class member (#26212) Signed-off-by: Silvan <silvan@auterion.com>	9 个月前
smbus	Add missing newline at the end of files	2 年前
smbus_sbs	smbus_sbs: switch to battery_info.serial_number	1 年前
CMakeLists.txt	fix(build): restore smbus/smbus_sbs for Linux board targets The previous commit (6b8fd11) gated smbus and smbus_sbs behind PX4_PLATFORM=="nuttx" to prevent clang-tidy errors on SITL, but these libraries depend on device::I2C which has a POSIX implementation (posix/I2C.cpp). Linux boards like bluerobotics_navigator (armhf) and emlid_navio2 (aarch64) enable CONFIG_DRIVERS_BATT_SMBUS, which depends on drivers__smbus — causing CMake to fail with "non-existent target". Move smbus and smbus_sbs back to unconditional add_subdirectory() so they are available on all platforms. Keep mcp_common gated behind NuttX since it includes px4_platform/gpio/mcp.hpp (NuttX-only GPIO headers). Re-add src/lib/drivers/smbus to the Makefile clang-tidy exclude list since the SITL compilation database lacks the I2C platform headers needed for analysis. Signed-off-by: Ramon Roche <mrpollo@gmail.com>	8 个月前