Merged
[CherryPick] adaptor high version gcc g++ #1163
Yuanhao JiAdd on Mar 21
[CherryPick] adaptor high version gcc g++ #1163
Merged
Yuanhao JiAdd on Mar 21
Yuanhao Ji
Mar 21

描述

关联的Issue

测试

文档更新

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for Yuanhao Ji's contribution.)
Yuanhao JiYuanhao Ji
Mar 21 Created pull request, commit d0db022a
Yuanhao JiYuanhao Ji
Mar 21 Associated issue: [Requirement|需求建议]: collcomm与comm内部代码channel相关实现分层优化
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
pkg_inc ✅ lilin_137, yanyefeng (2/2) ✅ yanyefeng (1/1)
repo-cann/hcomm ✅ yanyefeng, lilin_137 (2/2) ✅ yanyefeng (1/1)
src ✅ yanyefeng, lilin_137 (2/2) ✅ yanyefeng (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

jiyuanhao, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Set leabclove,ccl_ligang,yanzhenghang,yanyefeng,wenxuemin,yangxiaoyuan,laodazhao1,chenke2026,zhongqin2020,Innoecho,chenyia,temper7620,zhangxp1030,lilin_137,lilianlin_hw as approver
CANN-robotCANN-robotCollaborators
Mar 21 Added label: cann-cla/yes
CANN-robotCANN-robotCollaborators
Mar 21 Set leabclove,ccl_ligang,yanzhenghang,yanyefeng,wenxuemin,chenke2026,Innoecho,temper7620 as approver
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

🔵 source code change are detected, tasks labels is removed in this pull request!

likedislike
Yuanhao Ji
Yuanhao Ji
Mar 21 Comments:

/compile

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Added label: ci-pipeline-running
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

流水线任务触发成功
任务链接 [d78378cb5ec64ec3af021945020e02ae][流水线指导]

任务名称状态日志下载链接
codecheck ✅ SUCCESS >>>>>
SCA ✅ SUCCESS >>>>>
anti_virus ✅ SUCCESS >>>>>
Check_Pr ✅ SUCCESS >>>>>
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
pre_comment ✅ SUCCESS >>>>>
UT_Test ❌ FAILED >>>>>
ST_Test ❌ FAILED
Smoke_A900_npupool ⚪ ABORTED

[2026-03-21 11:11:07]    CI执行失败

likedislike
Yuanhao JiYuanhao Ji
Mar 21 Associated issue: [Bug-Report|缺陷反馈]: 强制转换编译报错implicit conversion from 'enum transport_mode_t' to 'urma_transport_mode_t' {aka 'enum urma_transport_mode'}
6 event messages are collapsed here。 See more
CANN-robotCANN-robotCollaborators
Mar 21 Added label: stat/needs-squash
Yuanhao Ji
Yuanhao Ji
Mar 21 Comments:

/compile

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Set yangxiaoyuan,laodazhao1,zhongqin2020,chenyia,zhangxp1030,lilin_137,lilianlin_hw as approver
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

🔵 source code change are detected, tasks labels is removed in this pull request!

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Removed label: ci-pipeline-failed
CANN-robotCANN-robotCollaborators
Mar 21 Added label: ci-pipeline-running
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

流水线任务触发成功
任务链接 [4a9d5f340ef84e7c83c02abacb6c226b][流水线指导]

任务名称状态日志下载链接
codecheck ✅ SUCCESS >>>>>
SCA ✅ SUCCESS >>>>>
anti_virus ✅ SUCCESS >>>>>
Check_Pr ✅ SUCCESS >>>>>
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
pre_comment ✅ SUCCESS >>>>>
UT_Test ❌ FAILED >>>>>
ST_Test ❌ FAILED
Smoke_A900_npupool ⚪ ABORTED

[2026-03-21 11:27:45]    CI执行失败

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Mar 21 Added label: ci-pipeline-failed
Yuanhao JiYuanhao Ji
Mar 21 Pre merge succeeded (commit_id: 7dbc2b28ae381943a154d2bd53429d1c36c19618)
Yuanhao JiYuanhao Ji
Mar 21 Force-pushed 1 commits:ba8409db-tmp: build_third_party
Yuanhao JiYuanhao Ji
Mar 21 Pre merge succeeded (commit_id: 0d18a647ca7f6151aeb67aa702e2f4a77f6bc738)
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

🔵 source code change are detected, tasks labels is removed in this pull request!

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Removed label: ci-pipeline-failed
Yuanhao Ji
Yuanhao Ji
Mar 21 Comments:

/compile

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Added label: ci-pipeline-running
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

流水线任务触发成功
任务链接 [bb97acc9899b4ff68571dc1b55e0bffb][流水线指导]

任务名称状态日志下载链接
codecheck ✅ SUCCESS >>>>>
SCA ✅ SUCCESS >>>>>
anti_virus ✅ SUCCESS >>>>>
Check_Pr ✅ SUCCESS >>>>>
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
pre_comment ✅ SUCCESS >>>>>
UT_Test ✅ SUCCESS >>>>>
ST_Test ✅ SUCCESS
Smoke_A900_npupool ✅ SUCCESS >>>>>

[2026-03-21 12:15:14]    CI执行结束

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Mar 21 Added label: ci-pipeline-passed
philo
philoCollaborators
Mar 21 Comments:

/approve

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Added label: approved
lilin_137CollaboratorsMar 21Start code review2
src/legacy/framework/communicator/communicator_impl.cc
@@ -353,7 +353,7 @@ void CommunicatorImpl::TraceOpInfo(const CollOpParams &opParams) const
353353 HcclSendRecvItem *sendRecvItems
354354 = static_cast<HcclSendRecvItem *>(opParams.batchSendRecvDataDes.sendRecvItemsPtr);
355355 for (u32 i = 0; i < itemNum; ++i) {
356- if ((sendRecvItems + i) == nullptr || (sendRecvItems + i)->buf == nullptr) {
lilin_137Mar 21Comments:

请确认这个修改是否能保障逻辑正常

likedislike
Yuanhao Ji
Yuanhao Ji
Mar 21 Comments:

此处主要修改编译告警,如果首地址不为nullptr,则偏移后的地址也不会为nullptr,因此编译器会有告警

但此处需要检查数组首地址指针是否为nullptr,static_cast 的参数不为 nullptr,所以数组首地址也不为nullptr

Llilin_137Collaborators
Mar 21 Resolved final issue
lilin_137Collaborators
Mar 21 Comments:

/lgtm

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Added label: lgtm
CANN-robot
CANN-robotCollaborators
Mar 21 Comments:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: yanyefeng.
Reviewers who wrote a comment of /lgtm are: lilin_137, yanyefeng.

likedislike
CANN-robotCANN-robotCollaborators
Mar 21 Merged pull request